Remove trailing whitespace from the repo#9065
Merged
ghpvnist merged 1 commit intopytorch:masterfrom May 8, 2025
Merged
Conversation
ghpvnist
requested review from
ManfeiBai,
lsy323,
mikegre-google,
tengyifei and
zpcore
as code owners
tengyifei
approved these changes
Apr 30, 2025
Collaborator
|
@zpcore ptal, ty! |
lsy323
approved these changes
May 8, 2025
qihqi
approved these changes
May 8, 2025
Collaborator
Author
|
@tengyifei Do we need to increase tolerance for this particular GPU test? I think I've seen this test fail for multiple PRs. |
Collaborator
I don't think so. That looks like a legit bug to me. Because the delta is not small. In any case, we can merge this without blocking on GPU tests. If we want to do something with the tolerance, that should be done in a separate PR. |
Collaborator
|
@ghpvnist feel free to squash and merge |
Collaborator
|
Specifically the number is very close to 113/125 |
zhanyong-wan
pushed a commit
to zhanyong-wan/pytorch-xla
that referenced
this pull request
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nuking trailing whitespaces using regex
s/\s+$//closes #9101