Fixes pytorch/xla#7398 #9047
Open
Fixes pytorch/xla#7398 #9047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qihqi
reviewed
Apr 27, 2025
torchax/test/test_ops.py
Outdated
| @@ -204,6 +203,10 @@ def test_reference_eager(self, device, dtype, op): | |||
|
|
|||
| # print("[DEBUG] sample_input: ", sample_input) | |||
|
|
|||
| if op.name == "cat": | |||
There was a problem hiding this comment.
should edit here: https://github.com/pytorch/xla/blob/master/torchax/torchax/ops/jaten.py#L1200 and filter out the empty tensor instead of skipping the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix:
ERROR: test_reference_eager_cat_cpu_float32 (main.TestOpInfoCPU) [torchax_eval]
Traceback (most recent call last):
File "/home/qianminj/qianminj123/xla/torchax/test/test_ops.py", line 140, in run_export_and_compare
res2 = func(input2, *args2, **kwargs2)
File "/home/qianminj/anaconda3/envs/torchax/lib/python3.10/site-packages/torch/testing/_internal/opinfo/core.py", line 1178, in call
return self.op(*args, **kwargs)
File "/home/qianminj/xla/torchax/torchax/tensor.py", line 266, in torch_function
return func(*args, **(kwargs or {}))
File "/home/qianminj/xla/torchax/torchax/tensor.py", line 289, in torch_dispatch
return self.env.dispatch(func, types, args, kwargs)
File "/home/qianminj/xla/torchax/torchax/tensor.py", line 526, in dispatch
res = op.func(*args, **kwargs)
File "/home/qianminj/xla/torchax/torchax/ops/jaten.py", line 1201, in _aten_cat
return jnp.concatenate(tensors, dims)
File "/home/qianminj/anaconda3/envs/torchax/lib/python3.10/site-packages/jax/_src/numpy/lax_numpy.py", line 4638, in concatenate
axis = _canonicalize_axis(axis, np.ndim(arrays[0]))
File "/home/qianminj/anaconda3/envs/torchax/lib/python3.10/site-packages/jax/_src/util.py", line 376, in canonicalize_axis
raise ValueError(f"axis {axis} is out of bounds for array of dimension {num_dims}")
ValueError: axis 1 is out of bounds for array of dimension 1
======================================================================
ERROR: test_reference_eager_cat_cpu_int64 (main.TestOpInfoCPU) [torchax_eval]
Traceback (most recent call last):
File "/home/qianminj/qianminj123/xla/torchax/test/test_ops.py", line 140, in run_export_and_compare
res2 = func(input2, *args2, **kwargs2)
File "/home/qianminj/anaconda3/envs/torchax/lib/python3.10/site-packages/torch/testing/_internal/opinfo/core.py", line 1178, in call
return self.op(*args, **kwargs)
File "/home/qianminj/xla/torchax/torchax/tensor.py", line 266, in torch_function
return func(*args, **(kwargs or {}))
File "/home/qianminj/xla/torchax/torchax/tensor.py", line 289, in torch_dispatch
return self.env.dispatch(func, types, args, kwargs)
File "/home/qianminj/xla/torchax/torchax/tensor.py", line 526, in dispatch
res = op.func(*args, **kwargs)
File "/home/qianminj/xla/torchax/torchax/ops/jaten.py", line 1201, in _aten_cat
return jnp.concatenate(tensors, dims)
File "/home/qianminj/anaconda3/envs/torchax/lib/python3.10/site-packages/jax/_src/numpy/lax_numpy.py", line 4638, in concatenate
axis = _canonicalize_axis(axis, np.ndim(arrays[0]))
File "/home/qianminj/anaconda3/envs/torchax/lib/python3.10/site-packages/jax/_src/util.py", line 376, in canonicalize_axis
raise ValueError(f"axis {axis} is out of bounds for array of dimension {num_dims}")
ValueError: axis 1 is out of bounds for array of dimension 1
Ran 2 tests in 4.274s
FAILED (errors=2)
After the fix:
Ran 2 tests in 2.877s
OK