Uncaught Dense Kernel incompatibility in OSS #3061
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76233463 |
aporialiao
added a commit
to aporialiao/torchrec
that referenced
this pull request
Jun 8, 2025
Summary: Rollback Plan: Differential Revision: D76233463
aporialiao
force-pushed
the
export-D76233463
branch
from
0a2c7a9 to
f0bec75
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76233463 |
aporialiao
added a commit
to aporialiao/torchrec
that referenced
this pull request
Jun 9, 2025
Summary: Rollback Plan: Differential Revision: D76233463
aporialiao
force-pushed
the
export-D76233463
branch
from
f0bec75 to
ef365b6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76233463 |
Summary: This is tricky - a small edge case that can't be reproduced locally - OSS environment will expose where compute kernel may be detected as "fused" when not passed in. This will cause the unit test to occasionally change the kernel type in resharding (due to the new plan passed in). Passing in the kernel type in the new plan generation fixes this. Differential Revision: D76233463
aporialiao
force-pushed
the
export-D76233463
branch
from
ef365b6 to
f93e68a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76233463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D76233463