-
Notifications
You must be signed in to change notification settings - Fork 45
Variable FPS tests #761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Variable FPS tests #761
Conversation
Signed-off-by: yexiaochuan <[email protected]>
Signed-off-by: yexiaochuan <[email protected]>
python3 "$TORCHCODEC_PATH/test/convert_image_to_tensor.py" "$bmp" | ||
rm -f "$bmp" | ||
done | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive by. I realized we had this logic twice: here and again at the end of the script. We only want it once. The dupe was introduced back in #448.
Status: the current video in the PR is failing on CUDA with errors similar to what we fixed with #448. I want to re-create the video, but I am unable to. The comment in the script uses the command:
But I don't have libx264 in my environment. I do have libopenh264, but when I use that to encode the video, I see the warnings:
And the resulting video does not have a variable frame rate. Shelving this for now until we can reliably recreate a variable framer rate video. |
Creating a new PR based off of #669. I can't push to that PR, so we need a new one.
This PR adds a new video which has variable FPS, commits some reference frames from it, and then uses it in two tests. Notably we only test with exact seeking mode. These tests would fail in approximate mode because we would get the wrong frames.