Support buffer size argument in broadcast_str util
#988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D72077879 |
supergeorge23
added a commit
to supergeorge23/tnt
that referenced
this pull request
Apr 4, 2025
Summary: This commit adds a new test case to the DistributedTest class to test the broadcast_str function with a fixed buffer size. The test case checks that the broadcasted value is correct when the fixed buffer size is larger than, equal to, and smaller than the length of the input string. Note: This commit also includes some minor changes to the existing test cases to make them more robust. Changes: - Added new test case test_broadcast_str_fixed_buffer_size to DistributedTest - Updated existing test cases to use spawn_multi_process instead of spawn Error: The test case is currently failing due to an "enforce fail" error in the Gloo backend. Further investigation is needed to determine the root cause of this error. Differential Revision: D72077879
supergeorge23
force-pushed
the
export-D72077879
branch
from
9fbf875 to
ac5ba0e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72077879 |
supergeorge23
added a commit
to supergeorge23/tnt
that referenced
this pull request
Apr 4, 2025
Summary: Pull Request resolved: pytorch#988 This commit adds a new test case to the DistributedTest class to test the broadcast_str function with a fixed buffer size. The test case checks that the broadcasted value is correct when the fixed buffer size is larger than, equal to, and smaller than the length of the input string. Note: This commit also includes some minor changes to the existing test cases to make them more robust. Changes: - Added new test case test_broadcast_str_fixed_buffer_size to DistributedTest - Updated existing test cases to use spawn_multi_process instead of spawn Error: The test case is currently failing due to an "enforce fail" error in the Gloo backend. Further investigation is needed to determine the root cause of this error. Differential Revision: D72077879
supergeorge23
force-pushed
the
export-D72077879
branch
from
ac5ba0e to
02a4b1c
Compare
supergeorge23
added a commit
to supergeorge23/tnt
that referenced
this pull request
Apr 8, 2025
Summary: This commit adds a new test case to the DistributedTest class to test the broadcast_str function with a fixed buffer size. The test case checks that the broadcasted value is correct when the fixed buffer size is larger than, equal to, and smaller than the length of the input string. Note: This commit also includes some minor changes to the existing test cases to make them more robust. Changes: - Added new test case test_broadcast_str_fixed_buffer_size to DistributedTest - Updated existing test cases to use spawn_multi_process instead of spawn Error: The test case is currently failing due to an "enforce fail" error in the Gloo backend. Further investigation is needed to determine the root cause of this error. Differential Revision: D72077879
supergeorge23
force-pushed
the
export-D72077879
branch
from
02a4b1c to
8b7ae21
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72077879 |
supergeorge23
force-pushed
the
export-D72077879
branch
from
8b7ae21 to
82a9ed5
Compare
supergeorge23
added a commit
to supergeorge23/tnt
that referenced
this pull request
Apr 8, 2025
Summary: Pull Request resolved: pytorch#988 This commit adds a new test case to the DistributedTest class to test the broadcast_str function with a fixed buffer size. The test case checks that the broadcasted value is correct when the fixed buffer size is larger than, equal to, and smaller than the length of the input string. Note: This commit also includes some minor changes to the existing test cases to make them more robust. Changes: - Added new test case test_broadcast_str_fixed_buffer_size to DistributedTest - Updated existing test cases to use spawn_multi_process instead of spawn Error: The test case is currently failing due to an "enforce fail" error in the Gloo backend. Further investigation is needed to determine the root cause of this error. Differential Revision: D72077879
supergeorge23
added a commit
to supergeorge23/tnt
that referenced
this pull request
Apr 8, 2025
Summary: This commit adds a new test case to the DistributedTest class to test the broadcast_str function with a fixed buffer size. The test case checks that the broadcasted value is correct when the fixed buffer size is larger than, equal to, and smaller than the length of the input string. Note: This commit also includes some minor changes to the existing test cases to make them more robust. Changes: - Added new test case test_broadcast_str_fixed_buffer_size to DistributedTest - Updated existing test cases to use spawn_multi_process instead of spawn Error: The test case is currently failing due to an "enforce fail" error in the Gloo backend. Further investigation is needed to determine the root cause of this error. Differential Revision: D72077879
supergeorge23
force-pushed
the
export-D72077879
branch
from
82a9ed5 to
ecd4605
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72077879 |
supergeorge23
added a commit
to supergeorge23/tnt
that referenced
this pull request
Apr 8, 2025
Summary: Pull Request resolved: pytorch#988 This commit adds a new test case to the DistributedTest class to test the broadcast_str function with a fixed buffer size. The test case checks that the broadcasted value is correct when the fixed buffer size is larger than, equal to, and smaller than the length of the input string. Note: This commit also includes some minor changes to the existing test cases to make them more robust. Changes: - Added new test case test_broadcast_str_fixed_buffer_size to DistributedTest - Updated existing test cases to use spawn_multi_process instead of spawn Error: The test case is currently failing due to an "enforce fail" error in the Gloo backend. Further investigation is needed to determine the root cause of this error. Differential Revision: D72077879
supergeorge23
force-pushed
the
export-D72077879
branch
from
ecd4605 to
e4e64b1
Compare
supergeorge23
added a commit
to supergeorge23/tnt
that referenced
this pull request
Apr 8, 2025
Summary: This commit adds a new test case to the DistributedTest class to test the broadcast_str function with a fixed buffer size. The test case checks that the broadcasted value is correct when the fixed buffer size is larger than, equal to, and smaller than the length of the input string. Note: This commit also includes some minor changes to the existing test cases to make them more robust. Changes: - Added new test case test_broadcast_str_fixed_buffer_size to DistributedTest - Updated existing test cases to use spawn_multi_process instead of spawn Error: The test case is currently failing due to an "enforce fail" error in the Gloo backend. Further investigation is needed to determine the root cause of this error. Differential Revision: D72077879
supergeorge23
force-pushed
the
export-D72077879
branch
from
e4e64b1 to
8b3bd47
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72077879 |
supergeorge23
force-pushed
the
export-D72077879
branch
from
8b3bd47 to
9a6c8c7
Compare
supergeorge23
added a commit
to supergeorge23/tnt
that referenced
this pull request
Apr 8, 2025
Summary: Pull Request resolved: pytorch#988 This commit adds a new test case to the DistributedTest class to test the broadcast_str function with a fixed buffer size. The test case checks that the broadcasted value is correct when the fixed buffer size is larger than, equal to, and smaller than the length of the input string. Note: This commit also includes some minor changes to the existing test cases to make them more robust. Changes: - Added new test case test_broadcast_str_fixed_buffer_size to DistributedTest - Updated existing test cases to use spawn_multi_process instead of spawn Error: The test case is currently failing due to an "enforce fail" error in the Gloo backend. Further investigation is needed to determine the root cause of this error. Differential Revision: D72077879
supergeorge23
added a commit
to supergeorge23/tnt
that referenced
this pull request
Apr 9, 2025
Summary: This commit adds a new test case to the DistributedTest class to test the broadcast_str function with a fixed buffer size. The test case checks that the broadcasted value is correct when the fixed buffer size is larger than, equal to, and smaller than the length of the input string. Note: This commit also includes some minor changes to the existing test cases to make them more robust. Changes: - Added new test case test_broadcast_str_fixed_buffer_size to DistributedTest - Updated existing test cases to use spawn_multi_process instead of spawn Error: The test case is currently failing due to an "enforce fail" error in the Gloo backend. Further investigation is needed to determine the root cause of this error. Differential Revision: D72077879
supergeorge23
force-pushed
the
export-D72077879
branch
2 times, most recently
from
84f901b to
1839e10
Compare
supergeorge23
added a commit
to supergeorge23/tnt
that referenced
this pull request
Apr 9, 2025
Summary: Pull Request resolved: pytorch#988 This commit adds a new test case to the DistributedTest class to test the broadcast_str function with a fixed buffer size. The test case checks that the broadcasted value is correct when the fixed buffer size is larger than, equal to, and smaller than the length of the input string. Note: This commit also includes some minor changes to the existing test cases to make them more robust. Changes: - Added new test case test_broadcast_str_fixed_buffer_size to DistributedTest - Updated existing test cases to use spawn_multi_process instead of spawn Error: The test case is currently failing due to an "enforce fail" error in the Gloo backend. Further investigation is needed to determine the root cause of this error. Differential Revision: D72077879
|
This pull request was exported from Phabricator. Differential Revision: D72077879 |
supergeorge23
added a commit
to supergeorge23/tnt
that referenced
this pull request
Apr 9, 2025
Summary: This commit adds a new test case to the DistributedTest class to test the broadcast_str function with a fixed buffer size. The test case checks that the broadcasted value is correct when the fixed buffer size is larger than, equal to, and smaller than the length of the input string. Note: This commit also includes some minor changes to the existing test cases to make them more robust. Changes: - Added new test case test_broadcast_str_fixed_buffer_size to DistributedTest - Updated existing test cases to use spawn_multi_process instead of spawn Error: The test case is currently failing due to an "enforce fail" error in the Gloo backend. Further investigation is needed to determine the root cause of this error. Differential Revision: D72077879
supergeorge23
force-pushed
the
export-D72077879
branch
from
1839e10 to
5c55a3a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72077879 |
supergeorge23
added a commit
to supergeorge23/tnt
that referenced
this pull request
Apr 9, 2025
Summary: Pull Request resolved: pytorch#988 This commit adds a new test case to the DistributedTest class to test the broadcast_str function with a fixed buffer size. The test case checks that the broadcasted value is correct when the fixed buffer size is larger than, equal to, and smaller than the length of the input string. Note: This commit also includes some minor changes to the existing test cases to make them more robust. Changes: - Added new test case test_broadcast_str_fixed_buffer_size to DistributedTest - Updated existing test cases to use spawn_multi_process instead of spawn Error: The test case is currently failing due to an "enforce fail" error in the Gloo backend. Further investigation is needed to determine the root cause of this error. Differential Revision: D72077879
supergeorge23
force-pushed
the
export-D72077879
branch
from
5c55a3a to
c05ffed
Compare
supergeorge23
added a commit
to supergeorge23/tnt
that referenced
this pull request
Apr 10, 2025
Summary: This commit adds a new test case to the DistributedTest class to test the broadcast_str function with a fixed buffer size. The test case checks that the broadcasted value is correct when the fixed buffer size is larger than, equal to, and smaller than the length of the input string. Note: This commit also includes some minor changes to the existing test cases to make them more robust. Changes: - Added new test case test_broadcast_str_fixed_buffer_size to DistributedTest - Updated existing test cases to use spawn_multi_process instead of spawn Error: The test case is currently failing due to an "enforce fail" error in the Gloo backend. Further investigation is needed to determine the root cause of this error. Reviewed By: JKSenthil Differential Revision: D72077879
supergeorge23
force-pushed
the
export-D72077879
branch
from
c05ffed to
cf896b2
Compare
Summary: Pull Request resolved: pytorch#988 This commit adds a new test case to the DistributedTest class to test the broadcast_str function with a fixed buffer size. The test case checks that the broadcasted value is correct when the fixed buffer size is larger than, equal to, and smaller than the length of the input string. Note: This commit also includes some minor changes to the existing test cases to make them more robust. Changes: - Added new test case test_broadcast_str_fixed_buffer_size to DistributedTest - Updated existing test cases to use spawn_multi_process instead of spawn Error: The test case is currently failing due to an "enforce fail" error in the Gloo backend. Further investigation is needed to determine the root cause of this error. Reviewed By: JKSenthil Differential Revision: D72077879
|
This pull request was exported from Phabricator. Differential Revision: D72077879 |
supergeorge23
force-pushed
the
export-D72077879
branch
from
cf896b2 to
a36ad75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This commit adds a new test case to the DistributedTest class to test the
broadcast_str function with a fixed buffer size. The test case checks that
the broadcasted value is correct when the fixed buffer size is larger than,
equal to, and smaller than the length of the input string.
Note: This commit also includes some minor changes to the existing test cases
to make them more robust.
Changes:
Error:
The test case is currently failing due to an "enforce fail" error in the Gloo
backend. Further investigation is needed to determine the root cause of this
error.
Differential Revision: D72077879