Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] Remove deprec specs from tests #2767

Open
wants to merge 2 commits into
base: gh/vmoens/85/base
Choose a base branch
from
Open

[BE] Remove deprec specs from tests #2767

wants to merge 2 commits into from
+57 −55

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Feb 7, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@vmoens
Update
d23c54d 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2767

Note: Links to docs will display an error until the docs builds have been completed.

❌ 11 New Failures, 1 Unrelated Failure

As of commit 7993d4d with merge base b27ee6d (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens added a commit that referenced this pull request Feb 7, 2025
@vmoens
[BE] Remove deprec specs from tests
a6a4f54 
ghstack-source-id: 4cb5741c9d507550db1d5a2ac46f32e66df1b547
Pull Request resolved: #2767
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 149. Improved: $\large\color{#35bf28}4$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_simple 0.5915s 0.5086s 1.9660 Ops/s 1.9975 Ops/s $\color{#d91a1a}-1.58\%$
test_transformed 1.1020s 1.0070s 0.9930 Ops/s 1.0114 Ops/s $\color{#d91a1a}-1.82\%$
test_serial 1.6469s 1.5409s 0.6490 Ops/s 0.6562 Ops/s $\color{#d91a1a}-1.10\%$
test_parallel 1.3645s 1.2833s 0.7792 Ops/s 0.7707 Ops/s $\color{#35bf28}+1.10\%$
test_step_mdp_speed[True-True-True-True-True] 0.2087ms 30.8664μs 32.3977 KOps/s 32.8828 KOps/s $\color{#d91a1a}-1.48\%$
test_step_mdp_speed[True-True-True-True-False] 52.9900μs 18.1422μs 55.1202 KOps/s 54.6693 KOps/s $\color{#35bf28}+0.82\%$
test_step_mdp_speed[True-True-True-False-True] 45.4650μs 17.1972μs 58.1491 KOps/s 57.0935 KOps/s $\color{#35bf28}+1.85\%$
test_step_mdp_speed[True-True-True-False-False] 41.5880μs 10.4649μs 95.5571 KOps/s 98.0118 KOps/s $\color{#d91a1a}-2.50\%$
test_step_mdp_speed[True-True-False-True-True] 63.9010μs 32.5755μs 30.6979 KOps/s 30.6364 KOps/s $\color{#35bf28}+0.20\%$
test_step_mdp_speed[True-True-False-True-False] 54.4120μs 20.2315μs 49.4280 KOps/s 50.0416 KOps/s $\color{#d91a1a}-1.23\%$
test_step_mdp_speed[True-True-False-False-True] 50.5950μs 19.3734μs 51.6171 KOps/s 52.0770 KOps/s $\color{#d91a1a}-0.88\%$
test_step_mdp_speed[True-True-False-False-False] 33.7340μs 12.0781μs 82.7948 KOps/s 82.2442 KOps/s $\color{#35bf28}+0.67\%$
test_step_mdp_speed[True-False-True-True-True] 67.9380μs 34.9425μs 28.6185 KOps/s 28.6678 KOps/s $\color{#d91a1a}-0.17\%$
test_step_mdp_speed[True-False-True-True-False] 48.9420μs 22.2015μs 45.0420 KOps/s 45.3167 KOps/s $\color{#d91a1a}-0.61\%$
test_step_mdp_speed[True-False-True-False-True] 50.8860μs 19.5004μs 51.2809 KOps/s 51.8311 KOps/s $\color{#d91a1a}-1.06\%$
test_step_mdp_speed[True-False-True-False-False] 33.7340μs 12.1418μs 82.3601 KOps/s 81.9571 KOps/s $\color{#35bf28}+0.49\%$
test_step_mdp_speed[True-False-False-True-True] 66.1450μs 36.5272μs 27.3768 KOps/s 27.7060 KOps/s $\color{#d91a1a}-1.19\%$
test_step_mdp_speed[True-False-False-True-False] 72.4460μs 23.9528μs 41.7488 KOps/s 42.4933 KOps/s $\color{#d91a1a}-1.75\%$
test_step_mdp_speed[True-False-False-False-True] 53.4010μs 21.0491μs 47.5080 KOps/s 47.7195 KOps/s $\color{#d91a1a}-0.44\%$
test_step_mdp_speed[True-False-False-False-False] 40.9670μs 13.8700μs 72.0981 KOps/s 72.2152 KOps/s $\color{#d91a1a}-0.16\%$
test_step_mdp_speed[False-True-True-True-True] 81.0630μs 34.5700μs 28.9268 KOps/s 29.0224 KOps/s $\color{#d91a1a}-0.33\%$
test_step_mdp_speed[False-True-True-True-False] 46.5270μs 21.8462μs 45.7745 KOps/s 45.7547 KOps/s $\color{#35bf28}+0.04\%$
test_step_mdp_speed[False-True-True-False-True] 49.9840μs 22.2680μs 44.9074 KOps/s 45.0831 KOps/s $\color{#d91a1a}-0.39\%$
test_step_mdp_speed[False-True-True-False-False] 38.6920μs 13.5183μs 73.9737 KOps/s 74.1872 KOps/s $\color{#d91a1a}-0.29\%$
test_step_mdp_speed[False-True-False-True-True] 76.3730μs 36.1544μs 27.6592 KOps/s 27.7654 KOps/s $\color{#d91a1a}-0.38\%$
test_step_mdp_speed[False-True-False-True-False] 60.0430μs 23.8346μs 41.9558 KOps/s 42.4468 KOps/s $\color{#d91a1a}-1.16\%$
test_step_mdp_speed[False-True-False-False-True] 2.6738ms 24.0739μs 41.5387 KOps/s 42.0034 KOps/s $\color{#d91a1a}-1.11\%$
test_step_mdp_speed[False-True-False-False-False] 77.0650μs 15.1999μs 65.7899 KOps/s 66.0279 KOps/s $\color{#d91a1a}-0.36\%$
test_step_mdp_speed[False-False-True-True-True] 93.2350μs 38.1009μs 26.2461 KOps/s 26.5421 KOps/s $\color{#d91a1a}-1.12\%$
test_step_mdp_speed[False-False-True-True-False] 67.5870μs 25.5564μs 39.1291 KOps/s 39.2421 KOps/s $\color{#d91a1a}-0.29\%$
test_step_mdp_speed[False-False-True-False-True] 53.8910μs 23.6169μs 42.3426 KOps/s 42.5721 KOps/s $\color{#d91a1a}-0.54\%$
test_step_mdp_speed[False-False-True-False-False] 55.9350μs 15.2971μs 65.3718 KOps/s 66.1746 KOps/s $\color{#d91a1a}-1.21\%$
test_step_mdp_speed[False-False-False-True-True] 89.1780μs 39.6690μs 25.2086 KOps/s 25.3528 KOps/s $\color{#d91a1a}-0.57\%$
test_step_mdp_speed[False-False-False-True-False] 56.3160μs 27.5438μs 36.3058 KOps/s 37.3333 KOps/s $\color{#d91a1a}-2.75\%$
test_step_mdp_speed[False-False-False-False-True] 53.5410μs 25.0487μs 39.9222 KOps/s 39.8196 KOps/s $\color{#35bf28}+0.26\%$
test_step_mdp_speed[False-False-False-False-False] 73.0470μs 17.0365μs 58.6976 KOps/s 59.7221 KOps/s $\color{#d91a1a}-1.72\%$
test_values[generalized_advantage_estimate-True-True] 10.1007ms 9.8183ms 101.8503 Ops/s 97.7710 Ops/s $\color{#35bf28}+4.17\%$
test_values[vec_generalized_advantage_estimate-True-True] 26.8106ms 24.0273ms 41.6192 Ops/s 41.7590 Ops/s $\color{#d91a1a}-0.33\%$
test_values[td0_return_estimate-False-False] 0.2446ms 0.1817ms 5.5024 KOps/s 5.6311 KOps/s $\color{#d91a1a}-2.28\%$
test_values[td1_return_estimate-False-False] 26.9448ms 24.4986ms 40.8187 Ops/s 40.4706 Ops/s $\color{#35bf28}+0.86\%$
test_values[vec_td1_return_estimate-False-False] 26.4438ms 24.1211ms 41.4575 Ops/s 41.3609 Ops/s $\color{#35bf28}+0.23\%$
test_values[td_lambda_return_estimate-True-False] 38.6481ms 35.3244ms 28.3090 Ops/s 28.2880 Ops/s $\color{#35bf28}+0.07\%$
test_values[vec_td_lambda_return_estimate-True-False] 26.5810ms 24.2819ms 41.1829 Ops/s 40.9454 Ops/s $\color{#35bf28}+0.58\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 9.8255ms 8.5032ms 117.6034 Ops/s 115.0552 Ops/s $\color{#35bf28}+2.21\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.2445ms 1.8962ms 527.3835 Ops/s 487.3906 Ops/s $\textbf{\color{#35bf28}+8.21\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4632ms 0.3695ms 2.7065 KOps/s 2.7134 KOps/s $\color{#d91a1a}-0.25\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 38.8168ms 38.4046ms 26.0385 Ops/s 24.8330 Ops/s $\color{#35bf28}+4.85\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.1516ms 3.4438ms 290.3741 Ops/s 290.8517 Ops/s $\color{#d91a1a}-0.16\%$
test_dqn_speed[False-None] 5.9364ms 1.4501ms 689.6038 Ops/s 697.5784 Ops/s $\color{#d91a1a}-1.14\%$
test_dqn_speed[False-backward] 1.9855ms 1.9217ms 520.3749 Ops/s 522.2949 Ops/s $\color{#d91a1a}-0.37\%$
test_dqn_speed[True-None] 0.6996ms 0.4872ms 2.0528 KOps/s 2.0071 KOps/s $\color{#35bf28}+2.28\%$
test_dqn_speed[True-backward] 1.0583ms 0.9184ms 1.0888 KOps/s 797.1968 Ops/s $\textbf{\color{#35bf28}+36.58\%}$
test_dqn_speed[reduce-overhead-None] 0.6227ms 0.4820ms 2.0746 KOps/s 2.0377 KOps/s $\color{#35bf28}+1.81\%$
test_dqn_speed[reduce-overhead-backward] 1.0449ms 0.9215ms 1.0852 KOps/s 1.0808 KOps/s $\color{#35bf28}+0.41\%$
test_ddpg_speed[False-None] 3.8986ms 2.9034ms 344.4189 Ops/s 336.2451 Ops/s $\color{#35bf28}+2.43\%$
test_ddpg_speed[False-backward] 4.4241ms 4.0431ms 247.3333 Ops/s 242.6562 Ops/s $\color{#35bf28}+1.93\%$
test_ddpg_speed[True-None] 1.6631ms 1.2288ms 813.7771 Ops/s 801.3813 Ops/s $\color{#35bf28}+1.55\%$
test_ddpg_speed[True-backward] 2.1994ms 2.1227ms 471.0916 Ops/s 465.9146 Ops/s $\color{#35bf28}+1.11\%$
test_ddpg_speed[reduce-overhead-None] 2.0413ms 1.2300ms 813.0156 Ops/s 798.4656 Ops/s $\color{#35bf28}+1.82\%$
test_ddpg_speed[reduce-overhead-backward] 2.2156ms 2.1647ms 461.9606 Ops/s 465.5103 Ops/s $\color{#d91a1a}-0.76\%$
test_sac_speed[False-None] 8.6967ms 8.1185ms 123.1758 Ops/s 121.4381 Ops/s $\color{#35bf28}+1.43\%$
test_sac_speed[False-backward] 11.1305ms 10.8440ms 92.2172 Ops/s 91.4777 Ops/s $\color{#35bf28}+0.81\%$
test_sac_speed[True-None] 3.7533ms 2.1133ms 473.2026 Ops/s 468.2653 Ops/s $\color{#35bf28}+1.05\%$
test_sac_speed[True-backward] 4.5845ms 3.8333ms 260.8747 Ops/s 264.3029 Ops/s $\color{#d91a1a}-1.30\%$
test_sac_speed[reduce-overhead-None] 2.3133ms 2.1059ms 474.8533 Ops/s 470.5618 Ops/s $\color{#35bf28}+0.91\%$
test_sac_speed[reduce-overhead-backward] 4.0370ms 3.8090ms 262.5334 Ops/s 259.0885 Ops/s $\color{#35bf28}+1.33\%$
test_redq_speed[False-None] 15.0281ms 12.8662ms 77.7232 Ops/s 77.3771 Ops/s $\color{#35bf28}+0.45\%$
test_redq_speed[False-backward] 25.0684ms 22.2682ms 44.9070 Ops/s 45.0207 Ops/s $\color{#d91a1a}-0.25\%$
test_redq_speed[True-None] 5.3882ms 4.7881ms 208.8509 Ops/s 204.6054 Ops/s $\color{#35bf28}+2.07\%$
test_redq_speed[True-backward] 12.5131ms 12.0987ms 82.6532 Ops/s 81.6630 Ops/s $\color{#35bf28}+1.21\%$
test_redq_speed[reduce-overhead-None] 6.7661ms 4.9140ms 203.5016 Ops/s 198.9501 Ops/s $\color{#35bf28}+2.29\%$
test_redq_speed[reduce-overhead-backward] 13.4571ms 12.1664ms 82.1936 Ops/s 80.2895 Ops/s $\color{#35bf28}+2.37\%$
test_redq_deprec_speed[False-None] 14.6291ms 12.9684ms 77.1106 Ops/s 76.3352 Ops/s $\color{#35bf28}+1.02\%$
test_redq_deprec_speed[False-backward] 21.2224ms 18.4963ms 54.0650 Ops/s 53.3122 Ops/s $\color{#35bf28}+1.41\%$
test_redq_deprec_speed[True-None] 4.6929ms 3.8500ms 259.7381 Ops/s 258.5831 Ops/s $\color{#35bf28}+0.45\%$
test_redq_deprec_speed[True-backward] 8.8697ms 8.2003ms 121.9460 Ops/s 118.9376 Ops/s $\color{#35bf28}+2.53\%$
test_redq_deprec_speed[reduce-overhead-None] 4.4209ms 3.8338ms 260.8374 Ops/s 258.4618 Ops/s $\color{#35bf28}+0.92\%$
test_redq_deprec_speed[reduce-overhead-backward] 9.5620ms 8.2327ms 121.4663 Ops/s 121.3141 Ops/s $\color{#35bf28}+0.13\%$
test_td3_speed[False-None] 10.6017ms 8.1843ms 122.1847 Ops/s 121.4667 Ops/s $\color{#35bf28}+0.59\%$
test_td3_speed[False-backward] 11.0116ms 10.5818ms 94.5021 Ops/s 93.7343 Ops/s $\color{#35bf28}+0.82\%$
test_td3_speed[True-None] 3.3739ms 1.8376ms 544.1934 Ops/s 552.2588 Ops/s $\color{#d91a1a}-1.46\%$
test_td3_speed[True-backward] 3.4511ms 3.3796ms 295.8961 Ops/s 285.5489 Ops/s $\color{#35bf28}+3.62\%$
test_td3_speed[reduce-overhead-None] 2.0696ms 1.7952ms 557.0290 Ops/s 548.9244 Ops/s $\color{#35bf28}+1.48\%$
test_td3_speed[reduce-overhead-backward] 3.4442ms 3.3753ms 296.2656 Ops/s 287.0100 Ops/s $\color{#35bf28}+3.22\%$
test_cql_speed[False-None] 38.3627ms 36.4582ms 27.4287 Ops/s 27.0511 Ops/s $\color{#35bf28}+1.40\%$
test_cql_speed[False-backward] 49.8789ms 47.0078ms 21.2731 Ops/s 20.9314 Ops/s $\color{#35bf28}+1.63\%$
test_cql_speed[True-None] 17.7448ms 15.8708ms 63.0090 Ops/s 61.2115 Ops/s $\color{#35bf28}+2.94\%$
test_cql_speed[True-backward] 24.7266ms 23.1912ms 43.1198 Ops/s 42.1834 Ops/s $\color{#35bf28}+2.22\%$
test_cql_speed[reduce-overhead-None] 17.2411ms 16.2016ms 61.7222 Ops/s 62.0439 Ops/s $\color{#d91a1a}-0.52\%$
test_cql_speed[reduce-overhead-backward] 24.8200ms 23.0098ms 43.4597 Ops/s 43.6404 Ops/s $\color{#d91a1a}-0.41\%$
test_a2c_speed[False-None] 8.3767ms 7.2606ms 137.7301 Ops/s 138.1024 Ops/s $\color{#d91a1a}-0.27\%$
test_a2c_speed[False-backward] 16.6454ms 14.5413ms 68.7696 Ops/s 69.5523 Ops/s $\color{#d91a1a}-1.13\%$
test_a2c_speed[True-None] 4.0762ms 3.7164ms 269.0776 Ops/s 265.0175 Ops/s $\color{#35bf28}+1.53\%$
test_a2c_speed[True-backward] 11.3145ms 10.1873ms 98.1612 Ops/s 98.3011 Ops/s $\color{#d91a1a}-0.14\%$
test_a2c_speed[reduce-overhead-None] 4.4203ms 3.7982ms 263.2851 Ops/s 267.6952 Ops/s $\color{#d91a1a}-1.65\%$
test_a2c_speed[reduce-overhead-backward] 11.8570ms 10.9137ms 91.6282 Ops/s 98.1860 Ops/s $\textbf{\color{#d91a1a}-6.68\%}$
test_ppo_speed[False-None] 9.6900ms 7.9325ms 126.0644 Ops/s 132.5737 Ops/s $\color{#d91a1a}-4.91\%$
test_ppo_speed[False-backward] 17.9483ms 15.5868ms 64.1567 Ops/s 67.5467 Ops/s $\textbf{\color{#d91a1a}-5.02\%}$
test_ppo_speed[True-None] 5.6499ms 4.3703ms 228.8155 Ops/s 240.4404 Ops/s $\color{#d91a1a}-4.83\%$
test_ppo_speed[True-backward] 11.5899ms 10.9582ms 91.2555 Ops/s 99.5190 Ops/s $\textbf{\color{#d91a1a}-8.30\%}$
test_ppo_speed[reduce-overhead-None] 4.9600ms 4.1373ms 241.7009 Ops/s 240.9901 Ops/s $\color{#35bf28}+0.29\%$
test_ppo_speed[reduce-overhead-backward] 11.4665ms 10.2803ms 97.2737 Ops/s 99.0109 Ops/s $\color{#d91a1a}-1.75\%$
test_reinforce_speed[False-None] 8.0272ms 6.7010ms 149.2320 Ops/s 148.4009 Ops/s $\color{#35bf28}+0.56\%$
test_reinforce_speed[False-backward] 11.4927ms 10.1092ms 98.9201 Ops/s 98.9300 Ops/s $\color{#d91a1a}-0.01\%$
test_reinforce_speed[True-None] 3.8196ms 3.1554ms 316.9187 Ops/s 312.1392 Ops/s $\color{#35bf28}+1.53\%$
test_reinforce_speed[True-backward] 9.9652ms 9.3297ms 107.1848 Ops/s 109.5070 Ops/s $\color{#d91a1a}-2.12\%$
test_reinforce_speed[reduce-overhead-None] 3.5562ms 3.1149ms 321.0336 Ops/s 321.3170 Ops/s $\color{#d91a1a}-0.09\%$
test_reinforce_speed[reduce-overhead-backward] 10.5461ms 9.3260ms 107.2267 Ops/s 107.2267 Ops/s $-0.00\%$
test_iql_speed[False-None] 38.5575ms 33.8543ms 29.5384 Ops/s 30.1838 Ops/s $\color{#d91a1a}-2.14\%$
test_iql_speed[False-backward] 50.0635ms 46.4406ms 21.5329 Ops/s 21.5684 Ops/s $\color{#d91a1a}-0.16\%$
test_iql_speed[True-None] 13.3875ms 11.6847ms 85.5821 Ops/s 87.4023 Ops/s $\color{#d91a1a}-2.08\%$
test_iql_speed[True-backward] 24.5781ms 23.1681ms 43.1629 Ops/s 44.5375 Ops/s $\color{#d91a1a}-3.09\%$
test_iql_speed[reduce-overhead-None] 12.5582ms 11.7613ms 85.0246 Ops/s 89.3205 Ops/s $\color{#d91a1a}-4.81\%$
test_iql_speed[reduce-overhead-backward] 25.3840ms 23.0633ms 43.3589 Ops/s 43.6470 Ops/s $\color{#d91a1a}-0.66\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 8.0196ms 5.1378ms 194.6344 Ops/s 192.8696 Ops/s $\color{#35bf28}+0.92\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9873ms 0.5275ms 1.8957 KOps/s 1.8807 KOps/s $\color{#35bf28}+0.79\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8631ms 0.5060ms 1.9764 KOps/s 2.0069 KOps/s $\color{#d91a1a}-1.52\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 7.8427ms 4.8892ms 204.5344 Ops/s 212.2549 Ops/s $\color{#d91a1a}-3.64\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.9014ms 0.5117ms 1.9543 KOps/s 1.9860 KOps/s $\color{#d91a1a}-1.60\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8086ms 0.4933ms 2.0272 KOps/s 2.0567 KOps/s $\color{#d91a1a}-1.44\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.5020ms 1.6871ms 592.7497 Ops/s 585.7804 Ops/s $\color{#35bf28}+1.19\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.2732ms 1.5885ms 629.5328 Ops/s 628.5124 Ops/s $\color{#35bf28}+0.16\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 7.6410ms 4.8117ms 207.8286 Ops/s 208.4654 Ops/s $\color{#d91a1a}-0.31\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.3462ms 0.6601ms 1.5150 KOps/s 1.5402 KOps/s $\color{#d91a1a}-1.63\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0737ms 0.6328ms 1.5804 KOps/s 1.5500 KOps/s $\color{#35bf28}+1.96\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.4304ms 4.7461ms 210.6982 Ops/s 213.5141 Ops/s $\color{#d91a1a}-1.32\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8582ms 0.5311ms 1.8828 KOps/s 1.9522 KOps/s $\color{#d91a1a}-3.55\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7146ms 0.4954ms 2.0185 KOps/s 2.0190 KOps/s $\color{#d91a1a}-0.03\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 7.5624ms 4.7304ms 211.3964 Ops/s 213.8127 Ops/s $\color{#d91a1a}-1.13\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8617ms 0.5127ms 1.9504 KOps/s 1.9619 KOps/s $\color{#d91a1a}-0.59\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6958ms 0.4900ms 2.0407 KOps/s 2.0309 KOps/s $\color{#35bf28}+0.48\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.0589ms 4.8712ms 205.2877 Ops/s 206.3542 Ops/s $\color{#d91a1a}-0.52\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.4873ms 0.6706ms 1.4911 KOps/s 1.5207 KOps/s $\color{#d91a1a}-1.95\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8596ms 0.6339ms 1.5774 KOps/s 1.5779 KOps/s $\color{#d91a1a}-0.03\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 5.9902ms 4.3324ms 230.8164 Ops/s 230.8525 Ops/s $\color{#d91a1a}-0.02\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 7.0807ms 2.3930ms 417.8840 Ops/s 429.6970 Ops/s $\color{#d91a1a}-2.75\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.9147ms 1.2080ms 827.8005 Ops/s 730.5159 Ops/s $\textbf{\color{#35bf28}+13.32\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.4385s 13.0370ms 76.7048 Ops/s 225.7784 Ops/s $\textbf{\color{#d91a1a}-66.03\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 11.7038ms 2.5583ms 390.8778 Ops/s 391.0448 Ops/s $\color{#d91a1a}-0.04\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.7380ms 1.2690ms 788.0246 Ops/s 729.4981 Ops/s $\textbf{\color{#35bf28}+8.02\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 6.0696ms 4.4418ms 225.1318 Ops/s 218.4355 Ops/s $\color{#35bf28}+3.07\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 5.2079ms 2.4669ms 405.3676 Ops/s 400.2084 Ops/s $\color{#35bf28}+1.29\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 6.6882ms 1.5461ms 646.7919 Ops/s 668.5910 Ops/s $\color{#d91a1a}-3.26\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 12.8661ms 12.5290ms 79.8149 Ops/s 77.4850 Ops/s $\color{#35bf28}+3.01\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 15.2675ms 14.4045ms 69.4227 Ops/s 68.9073 Ops/s $\color{#35bf28}+0.75\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 35.9304ms 21.7449ms 45.9877 Ops/s 47.1957 Ops/s $\color{#d91a1a}-2.56\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 15.9648ms 14.6286ms 68.3594 Ops/s 67.4608 Ops/s $\color{#35bf28}+1.33\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 23.2501ms 21.1444ms 47.2937 Ops/s 47.5834 Ops/s $\color{#d91a1a}-0.61\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 17.0772ms 15.7571ms 63.4636 Ops/s 61.9530 Ops/s $\color{#35bf28}+2.44\%$

@vmoens vmoens added the BE Better errors, logs, docs or test utils label Feb 10, 2025
@vmoens
Update
7993d4d 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 10, 2025
@vmoens
[BE] Remove deprec specs from tests
a0145cc 
ghstack-source-id: e09b03b4e6c8d4ff0d7cc75ef54fe26de5af71e7
Pull Request resolved: #2767
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 149. Improved: $\large\color{#35bf28}9$. Worsened: $\large\color{#d91a1a}16$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_simple 0.8925s 0.8040s 1.2437 Ops/s 1.2535 Ops/s $\color{#d91a1a}-0.78\%$
test_transformed 1.5065s 1.4109s 0.7088 Ops/s 0.7136 Ops/s $\color{#d91a1a}-0.67\%$
test_serial 2.3964s 2.3089s 0.4331 Ops/s 0.4323 Ops/s $\color{#35bf28}+0.19\%$
test_parallel 1.9415s 1.8617s 0.5371 Ops/s 0.5349 Ops/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[True-True-True-True-True] 0.2193ms 39.3253μs 25.4289 KOps/s 25.3907 KOps/s $\color{#35bf28}+0.15\%$
test_step_mdp_speed[True-True-True-True-False] 64.1910μs 23.8124μs 41.9950 KOps/s 42.4751 KOps/s $\color{#d91a1a}-1.13\%$
test_step_mdp_speed[True-True-True-False-True] 56.1810μs 22.4244μs 44.5943 KOps/s 45.1728 KOps/s $\color{#d91a1a}-1.28\%$
test_step_mdp_speed[True-True-True-False-False] 44.0910μs 12.9583μs 77.1709 KOps/s 76.5333 KOps/s $\color{#35bf28}+0.83\%$
test_step_mdp_speed[True-True-False-True-True] 0.1023ms 42.4996μs 23.5296 KOps/s 23.1005 KOps/s $\color{#35bf28}+1.86\%$
test_step_mdp_speed[True-True-False-True-False] 58.2500μs 25.6383μs 39.0042 KOps/s 38.8225 KOps/s $\color{#35bf28}+0.47\%$
test_step_mdp_speed[True-True-False-False-True] 56.9010μs 25.1943μs 39.6915 KOps/s 39.9777 KOps/s $\color{#d91a1a}-0.72\%$
test_step_mdp_speed[True-True-False-False-False] 40.8610μs 15.2998μs 65.3601 KOps/s 63.8470 KOps/s $\color{#35bf28}+2.37\%$
test_step_mdp_speed[True-False-True-True-True] 0.1008ms 45.3009μs 22.0746 KOps/s 21.8258 KOps/s $\color{#35bf28}+1.14\%$
test_step_mdp_speed[True-False-True-True-False] 63.2510μs 28.1885μs 35.4755 KOps/s 35.6492 KOps/s $\color{#d91a1a}-0.49\%$
test_step_mdp_speed[True-False-True-False-True] 59.1510μs 24.7326μs 40.4325 KOps/s 40.5110 KOps/s $\color{#d91a1a}-0.19\%$
test_step_mdp_speed[True-False-True-False-False] 46.1210μs 15.4243μs 64.8327 KOps/s 64.4886 KOps/s $\color{#35bf28}+0.53\%$
test_step_mdp_speed[True-False-False-True-True] 95.3320μs 47.2620μs 21.1586 KOps/s 20.8432 KOps/s $\color{#35bf28}+1.51\%$
test_step_mdp_speed[True-False-False-True-False] 73.9410μs 30.6672μs 32.6081 KOps/s 32.9518 KOps/s $\color{#d91a1a}-1.04\%$
test_step_mdp_speed[True-False-False-False-True] 69.0110μs 26.9886μs 37.0527 KOps/s 36.7003 KOps/s $\color{#35bf28}+0.96\%$
test_step_mdp_speed[True-False-False-False-False] 49.6700μs 17.7478μs 56.3451 KOps/s 55.3901 KOps/s $\color{#35bf28}+1.72\%$
test_step_mdp_speed[False-True-True-True-True] 79.5110μs 45.4609μs 21.9969 KOps/s 22.0377 KOps/s $\color{#d91a1a}-0.19\%$
test_step_mdp_speed[False-True-True-True-False] 73.2010μs 28.2185μs 35.4377 KOps/s 34.9259 KOps/s $\color{#35bf28}+1.47\%$
test_step_mdp_speed[False-True-True-False-True] 69.5510μs 28.9665μs 34.5226 KOps/s 34.5959 KOps/s $\color{#d91a1a}-0.21\%$
test_step_mdp_speed[False-True-True-False-False] 46.1010μs 17.2218μs 58.0660 KOps/s 57.6928 KOps/s $\color{#35bf28}+0.65\%$
test_step_mdp_speed[False-True-False-True-True] 89.9110μs 47.5613μs 21.0255 KOps/s 21.0335 KOps/s $\color{#d91a1a}-0.04\%$
test_step_mdp_speed[False-True-False-True-False] 81.0710μs 30.4173μs 32.8760 KOps/s 32.1426 KOps/s $\color{#35bf28}+2.28\%$
test_step_mdp_speed[False-True-False-False-True] 3.2515ms 31.4612μs 31.7852 KOps/s 31.3363 KOps/s $\color{#35bf28}+1.43\%$
test_step_mdp_speed[False-True-False-False-False] 51.2810μs 19.4616μs 51.3833 KOps/s 50.8456 KOps/s $\color{#35bf28}+1.06\%$
test_step_mdp_speed[False-False-True-True-True] 83.8820μs 50.0206μs 19.9918 KOps/s 19.8447 KOps/s $\color{#35bf28}+0.74\%$
test_step_mdp_speed[False-False-True-True-False] 85.0210μs 32.9939μs 30.3086 KOps/s 30.4625 KOps/s $\color{#d91a1a}-0.51\%$
test_step_mdp_speed[False-False-True-False-True] 65.2110μs 30.5545μs 32.7284 KOps/s 32.3272 KOps/s $\color{#35bf28}+1.24\%$
test_step_mdp_speed[False-False-True-False-False] 50.2310μs 19.3111μs 51.7838 KOps/s 50.8732 KOps/s $\color{#35bf28}+1.79\%$
test_step_mdp_speed[False-False-False-True-True] 95.4420μs 51.2207μs 19.5233 KOps/s 19.3082 KOps/s $\color{#35bf28}+1.11\%$
test_step_mdp_speed[False-False-False-True-False] 74.9210μs 34.7523μs 28.7751 KOps/s 28.4503 KOps/s $\color{#35bf28}+1.14\%$
test_step_mdp_speed[False-False-False-False-True] 72.2610μs 31.7623μs 31.4838 KOps/s 31.0773 KOps/s $\color{#35bf28}+1.31\%$
test_step_mdp_speed[False-False-False-False-False] 63.2210μs 21.6709μs 46.1447 KOps/s 46.7977 KOps/s $\color{#d91a1a}-1.40\%$
test_values[generalized_advantage_estimate-True-True] 24.6132ms 24.2160ms 41.2950 Ops/s 41.2393 Ops/s $\color{#35bf28}+0.14\%$
test_values[vec_generalized_advantage_estimate-True-True] 0.1258s 3.4085ms 293.3841 Ops/s 338.2523 Ops/s $\textbf{\color{#d91a1a}-13.26\%}$
test_values[td0_return_estimate-False-False] 0.1053ms 79.9260μs 12.5116 KOps/s 12.6714 KOps/s $\color{#d91a1a}-1.26\%$
test_values[td1_return_estimate-False-False] 54.4745ms 54.1164ms 18.4787 Ops/s 18.5315 Ops/s $\color{#d91a1a}-0.28\%$
test_values[vec_td1_return_estimate-False-False] 1.3481ms 1.0774ms 928.1552 Ops/s 933.4082 Ops/s $\color{#d91a1a}-0.56\%$
test_values[td_lambda_return_estimate-True-False] 85.9163ms 85.4762ms 11.6992 Ops/s 11.5368 Ops/s $\color{#35bf28}+1.41\%$
test_values[vec_td_lambda_return_estimate-True-False] 1.2899ms 1.0705ms 934.1058 Ops/s 938.5318 Ops/s $\color{#d91a1a}-0.47\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.2319ms 24.0697ms 41.5461 Ops/s 41.6637 Ops/s $\color{#d91a1a}-0.28\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.0118ms 0.7433ms 1.3454 KOps/s 1.3633 KOps/s $\color{#d91a1a}-1.32\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7568ms 0.6589ms 1.5178 KOps/s 1.5071 KOps/s $\color{#35bf28}+0.71\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5348ms 1.4782ms 676.5082 Ops/s 677.7043 Ops/s $\color{#d91a1a}-0.18\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.7317ms 0.6756ms 1.4801 KOps/s 1.4919 KOps/s $\color{#d91a1a}-0.79\%$
test_dqn_speed[False-None] 7.0509ms 1.5456ms 647.0136 Ops/s 650.4903 Ops/s $\color{#d91a1a}-0.53\%$
test_dqn_speed[False-backward] 2.4385ms 2.1580ms 463.3852 Ops/s 464.4113 Ops/s $\color{#d91a1a}-0.22\%$
test_dqn_speed[True-None] 0.6803ms 0.5498ms 1.8190 KOps/s 1.8192 KOps/s $\color{#d91a1a}-0.01\%$
test_dqn_speed[True-backward] 1.2942ms 1.2230ms 817.6878 Ops/s 891.3004 Ops/s $\textbf{\color{#d91a1a}-8.26\%}$
test_dqn_speed[reduce-overhead-None] 0.9798ms 0.5651ms 1.7696 KOps/s 1.7750 KOps/s $\color{#d91a1a}-0.30\%$
test_dqn_speed[reduce-overhead-backward] 1.1647ms 1.0604ms 943.0332 Ops/s 1.0490 KOps/s $\textbf{\color{#d91a1a}-10.10\%}$
test_ddpg_speed[False-None] 3.2694ms 2.8910ms 345.9058 Ops/s 342.4732 Ops/s $\color{#35bf28}+1.00\%$
test_ddpg_speed[False-backward] 4.6821ms 4.2635ms 234.5495 Ops/s 238.9145 Ops/s $\color{#d91a1a}-1.83\%$
test_ddpg_speed[True-None] 1.7477ms 1.3341ms 749.5963 Ops/s 753.7427 Ops/s $\color{#d91a1a}-0.55\%$
test_ddpg_speed[True-backward] 2.6526ms 2.5643ms 389.9676 Ops/s 413.8316 Ops/s $\textbf{\color{#d91a1a}-5.77\%}$
test_ddpg_speed[reduce-overhead-None] 1.7451ms 1.3369ms 747.9790 Ops/s 747.0198 Ops/s $\color{#35bf28}+0.13\%$
test_ddpg_speed[reduce-overhead-backward] 2.2171ms 2.0604ms 485.3485 Ops/s 524.4536 Ops/s $\textbf{\color{#d91a1a}-7.46\%}$
test_sac_speed[False-None] 8.6309ms 8.1587ms 122.5687 Ops/s 119.8522 Ops/s $\color{#35bf28}+2.27\%$
test_sac_speed[False-backward] 11.7505ms 11.2773ms 88.6740 Ops/s 89.2970 Ops/s $\color{#d91a1a}-0.70\%$
test_sac_speed[True-None] 2.2362ms 1.8251ms 547.9143 Ops/s 543.4594 Ops/s $\color{#35bf28}+0.82\%$
test_sac_speed[True-backward] 4.1644ms 3.7382ms 267.5079 Ops/s 279.3395 Ops/s $\color{#d91a1a}-4.24\%$
test_sac_speed[reduce-overhead-None] 21.4350ms 11.9717ms 83.5301 Ops/s 83.2828 Ops/s $\color{#35bf28}+0.30\%$
test_sac_speed[reduce-overhead-backward] 1.8244ms 1.7669ms 565.9618 Ops/s 601.5841 Ops/s $\textbf{\color{#d91a1a}-5.92\%}$
test_redq_speed[False-None] 7.9847ms 7.5062ms 133.2233 Ops/s 130.4183 Ops/s $\color{#35bf28}+2.15\%$
test_redq_speed[False-backward] 12.1938ms 11.7293ms 85.2565 Ops/s 87.1179 Ops/s $\color{#d91a1a}-2.14\%$
test_redq_speed[True-None] 2.6797ms 2.3034ms 434.1494 Ops/s 429.5381 Ops/s $\color{#35bf28}+1.07\%$
test_redq_speed[True-backward] 4.6395ms 4.1986ms 238.1756 Ops/s 246.2492 Ops/s $\color{#d91a1a}-3.28\%$
test_redq_speed[reduce-overhead-None] 2.4906ms 2.3251ms 430.0914 Ops/s 425.3939 Ops/s $\color{#35bf28}+1.10\%$
test_redq_speed[reduce-overhead-backward] 4.6479ms 4.1895ms 238.6944 Ops/s 237.0753 Ops/s $\color{#35bf28}+0.68\%$
test_redq_deprec_speed[False-None] 9.4704ms 9.1183ms 109.6692 Ops/s 108.9791 Ops/s $\color{#35bf28}+0.63\%$
test_redq_deprec_speed[False-backward] 12.8500ms 12.3513ms 80.9628 Ops/s 81.4485 Ops/s $\color{#d91a1a}-0.60\%$
test_redq_deprec_speed[True-None] 2.7002ms 2.6156ms 382.3156 Ops/s 374.1625 Ops/s $\color{#35bf28}+2.18\%$
test_redq_deprec_speed[True-backward] 4.6076ms 4.4620ms 224.1136 Ops/s 229.1803 Ops/s $\color{#d91a1a}-2.21\%$
test_redq_deprec_speed[reduce-overhead-None] 3.0275ms 2.6221ms 381.3723 Ops/s 377.2667 Ops/s $\color{#35bf28}+1.09\%$
test_redq_deprec_speed[reduce-overhead-backward] 4.8223ms 4.4669ms 223.8698 Ops/s 228.7520 Ops/s $\color{#d91a1a}-2.13\%$
test_td3_speed[False-None] 8.3703ms 8.0361ms 124.4390 Ops/s 124.2267 Ops/s $\color{#35bf28}+0.17\%$
test_td3_speed[False-backward] 11.1954ms 10.5851ms 94.4721 Ops/s 96.6643 Ops/s $\color{#d91a1a}-2.27\%$
test_td3_speed[True-None] 1.6712ms 1.6322ms 612.6747 Ops/s 594.7641 Ops/s $\color{#35bf28}+3.01\%$
test_td3_speed[True-backward] 3.4753ms 3.3223ms 300.9929 Ops/s 298.5699 Ops/s $\color{#35bf28}+0.81\%$
test_td3_speed[reduce-overhead-None] 51.0323ms 26.2286ms 38.1263 Ops/s 38.6978 Ops/s $\color{#d91a1a}-1.48\%$
test_td3_speed[reduce-overhead-backward] 1.5210ms 1.4779ms 676.6318 Ops/s 665.1173 Ops/s $\color{#35bf28}+1.73\%$
test_cql_speed[False-None] 17.5430ms 16.9376ms 59.0402 Ops/s 58.8451 Ops/s $\color{#35bf28}+0.33\%$
test_cql_speed[False-backward] 22.8314ms 22.3805ms 44.6817 Ops/s 44.8314 Ops/s $\color{#d91a1a}-0.33\%$
test_cql_speed[True-None] 3.6785ms 3.2653ms 306.2530 Ops/s 306.2611 Ops/s $-0.00\%$
test_cql_speed[True-backward] 6.4162ms 5.7021ms 175.3751 Ops/s 180.1420 Ops/s $\color{#d91a1a}-2.65\%$
test_cql_speed[reduce-overhead-None] 21.8663ms 13.1389ms 76.1098 Ops/s 76.1181 Ops/s $\color{#d91a1a}-0.01\%$
test_cql_speed[reduce-overhead-backward] 2.1780ms 1.9837ms 504.1105 Ops/s 536.1536 Ops/s $\textbf{\color{#d91a1a}-5.98\%}$
test_a2c_speed[False-None] 3.4528ms 3.2094ms 311.5875 Ops/s 309.5769 Ops/s $\color{#35bf28}+0.65\%$
test_a2c_speed[False-backward] 6.8803ms 6.3365ms 157.8161 Ops/s 162.1921 Ops/s $\color{#d91a1a}-2.70\%$
test_a2c_speed[True-None] 1.5949ms 1.3383ms 747.1954 Ops/s 736.2472 Ops/s $\color{#35bf28}+1.49\%$
test_a2c_speed[True-backward] 3.1105ms 3.0153ms 331.6382 Ops/s 339.3960 Ops/s $\color{#d91a1a}-2.29\%$
test_a2c_speed[reduce-overhead-None] 17.0351ms 8.9533ms 111.6907 Ops/s 113.0535 Ops/s $\color{#d91a1a}-1.21\%$
test_a2c_speed[reduce-overhead-backward] 2.1215ms 1.6197ms 617.4146 Ops/s 674.1802 Ops/s $\textbf{\color{#d91a1a}-8.42\%}$
test_ppo_speed[False-None] 3.8203ms 3.7295ms 268.1356 Ops/s 264.0376 Ops/s $\color{#35bf28}+1.55\%$
test_ppo_speed[False-backward] 7.5589ms 7.1651ms 139.5645 Ops/s 145.4913 Ops/s $\color{#d91a1a}-4.07\%$
test_ppo_speed[True-None] 1.4620ms 1.4162ms 706.1091 Ops/s 698.8766 Ops/s $\color{#35bf28}+1.03\%$
test_ppo_speed[True-backward] 3.2425ms 3.1995ms 312.5528 Ops/s 323.2272 Ops/s $\color{#d91a1a}-3.30\%$
test_ppo_speed[reduce-overhead-None] 1.0438ms 0.9612ms 1.0404 KOps/s 1.0079 KOps/s $\color{#35bf28}+3.23\%$
test_ppo_speed[reduce-overhead-backward] 1.7011ms 1.5624ms 640.0425 Ops/s 676.4403 Ops/s $\textbf{\color{#d91a1a}-5.38\%}$
test_reinforce_speed[False-None] 2.4861ms 2.3040ms 434.0189 Ops/s 425.7847 Ops/s $\color{#35bf28}+1.93\%$
test_reinforce_speed[False-backward] 3.8744ms 3.4827ms 287.1322 Ops/s 297.3259 Ops/s $\color{#d91a1a}-3.43\%$
test_reinforce_speed[True-None] 1.3455ms 1.2863ms 777.4419 Ops/s 750.5340 Ops/s $\color{#35bf28}+3.59\%$
test_reinforce_speed[True-backward] 3.5183ms 3.0561ms 327.2106 Ops/s 323.6065 Ops/s $\color{#35bf28}+1.11\%$
test_reinforce_speed[reduce-overhead-None] 18.9181ms 10.0660ms 99.3442 Ops/s 101.4745 Ops/s $\color{#d91a1a}-2.10\%$
test_reinforce_speed[reduce-overhead-backward] 1.7618ms 1.6283ms 614.1369 Ops/s 611.1899 Ops/s $\color{#35bf28}+0.48\%$
test_iql_speed[False-None] 9.7315ms 9.2649ms 107.9337 Ops/s 106.3461 Ops/s $\color{#35bf28}+1.49\%$
test_iql_speed[False-backward] 13.6348ms 13.1400ms 76.1035 Ops/s 75.2294 Ops/s $\color{#35bf28}+1.16\%$
test_iql_speed[True-None] 2.3835ms 2.2127ms 451.9265 Ops/s 442.0898 Ops/s $\color{#35bf28}+2.23\%$
test_iql_speed[True-backward] 4.8248ms 4.7161ms 212.0410 Ops/s 205.5747 Ops/s $\color{#35bf28}+3.15\%$
test_iql_speed[reduce-overhead-None] 18.9301ms 11.0991ms 90.0977 Ops/s 89.7313 Ops/s $\color{#35bf28}+0.41\%$
test_iql_speed[reduce-overhead-backward] 1.9595ms 1.8866ms 530.0631 Ops/s 497.5789 Ops/s $\textbf{\color{#35bf28}+6.53\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.7383ms 6.3662ms 157.0799 Ops/s 155.5426 Ops/s $\color{#35bf28}+0.99\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6377ms 0.2926ms 3.4177 KOps/s 3.4873 KOps/s $\color{#d91a1a}-2.00\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.4950ms 0.2468ms 4.0514 KOps/s 3.4531 KOps/s $\textbf{\color{#35bf28}+17.33\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.2602ms 6.0413ms 165.5277 Ops/s 165.2079 Ops/s $\color{#35bf28}+0.19\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8919ms 0.2996ms 3.3376 KOps/s 2.8202 KOps/s $\textbf{\color{#35bf28}+18.35\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5496ms 0.2788ms 3.5870 KOps/s 4.1217 KOps/s $\textbf{\color{#d91a1a}-12.97\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.4999ms 1.2687ms 788.2202 Ops/s 791.2408 Ops/s $\color{#d91a1a}-0.38\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.5322ms 1.1941ms 837.4442 Ops/s 849.4886 Ops/s $\color{#d91a1a}-1.42\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.3468ms 6.2578ms 159.8011 Ops/s 160.1731 Ops/s $\color{#d91a1a}-0.23\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.8329ms 0.4528ms 2.2087 KOps/s 2.3741 KOps/s $\textbf{\color{#d91a1a}-6.97\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.5558ms 0.3868ms 2.5855 KOps/s 2.5733 KOps/s $\color{#35bf28}+0.47\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.2355ms 6.1136ms 163.5690 Ops/s 163.2454 Ops/s $\color{#35bf28}+0.20\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0766ms 0.3253ms 3.0739 KOps/s 3.3745 KOps/s $\textbf{\color{#d91a1a}-8.91\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 1.3413ms 0.3362ms 2.9745 KOps/s 3.4962 KOps/s $\textbf{\color{#d91a1a}-14.92\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 8.5341ms 6.0902ms 164.1995 Ops/s 164.0044 Ops/s $\color{#35bf28}+0.12\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9366ms 0.3134ms 3.1906 KOps/s 3.0162 KOps/s $\textbf{\color{#35bf28}+5.78\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5358ms 0.2817ms 3.5502 KOps/s 3.1867 KOps/s $\textbf{\color{#35bf28}+11.41\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.3858ms 6.2197ms 160.7798 Ops/s 159.1948 Ops/s $\color{#35bf28}+1.00\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.1892ms 0.4895ms 2.0429 KOps/s 2.4384 KOps/s $\textbf{\color{#d91a1a}-16.22\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.6428ms 0.4612ms 2.1681 KOps/s 2.4693 KOps/s $\textbf{\color{#d91a1a}-12.20\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 6.9771ms 5.4495ms 183.5026 Ops/s 175.1342 Ops/s $\color{#35bf28}+4.78\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 9.8698ms 2.0571ms 486.1320 Ops/s 437.8330 Ops/s $\textbf{\color{#35bf28}+11.03\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 7.0246ms 1.1905ms 840.0154 Ops/s 839.2422 Ops/s $\color{#35bf28}+0.09\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 7.0834ms 5.5569ms 179.9571 Ops/s 177.5459 Ops/s $\color{#35bf28}+1.36\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 10.2212ms 2.0846ms 479.7198 Ops/s 426.8529 Ops/s $\textbf{\color{#35bf28}+12.39\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 3.3637ms 1.1343ms 881.5664 Ops/s 849.1939 Ops/s $\color{#35bf28}+3.81\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.5005s 15.6373ms 63.9495 Ops/s 171.3158 Ops/s $\textbf{\color{#d91a1a}-62.67\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 4.1487ms 1.8366ms 544.4958 Ops/s 35.0642 Ops/s $\textbf{\color{#35bf28}+1452.86\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.2619ms 1.1954ms 836.5532 Ops/s 779.2737 Ops/s $\textbf{\color{#35bf28}+7.35\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 13.3399ms 12.9688ms 77.1082 Ops/s 75.9822 Ops/s $\color{#35bf28}+1.48\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 18.1345ms 16.6455ms 60.0764 Ops/s 59.0929 Ops/s $\color{#35bf28}+1.66\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 18.2313ms 17.6676ms 56.6006 Ops/s 55.3072 Ops/s $\color{#35bf28}+2.34\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 18.8885ms 17.3221ms 57.7298 Ops/s 57.9665 Ops/s $\color{#d91a1a}-0.41\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 18.2572ms 17.7655ms 56.2889 Ops/s 55.6282 Ops/s $\color{#35bf28}+1.19\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 20.6046ms 18.1852ms 54.9897 Ops/s 52.9910 Ops/s $\color{#35bf28}+3.77\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BE Better errors, logs, docs or test utils CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot