-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deprecation] Gracing old *Spec with v0.8 versioning #2751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2025
Merged
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2751
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 3, 2025
vmoens
added a commit
that referenced
this pull request
Feb 3, 2025
ghstack-source-id: 97201fdbf4e46fb780286c8b5eaa4b2bf44dde9e Pull Request resolved: #2751
vmoens
added a commit
that referenced
this pull request
Feb 3, 2025
ghstack-source-id: ec0a353dac40be0e01f6bcfbd27c12d1fb528112 Pull Request resolved: #2751
|
Name | Max | Mean | Ops | Ops on Repo HEAD
|
Change |
---|---|---|---|---|---|
test_simple | 0.5422s | 0.4521s | 2.2117 Ops/s | 2.1835 Ops/s | |
test_transformed | 0.9711s | 0.8888s | 1.1251 Ops/s | 1.0687 Ops/s | |
test_serial | 1.4674s | 1.3709s | 0.7294 Ops/s | 0.7169 Ops/s | |
test_parallel | 1.2994s | 1.2010s | 0.8326 Ops/s | 0.8213 Ops/s | |
test_step_mdp_speed[True-True-True-True-True] | 0.1264ms | 30.7902μs | 32.4779 KOps/s | 33.4234 KOps/s | |
test_step_mdp_speed[True-True-True-True-False] | 60.6630μs | 17.6478μs | 56.6643 KOps/s | 56.7185 KOps/s | |
test_step_mdp_speed[True-True-True-False-True] | 44.9740μs | 17.0425μs | 58.6768 KOps/s | 58.8888 KOps/s | |
test_step_mdp_speed[True-True-True-False-False] | 45.1340μs | 9.8979μs | 101.0320 KOps/s | 100.3681 KOps/s | |
test_step_mdp_speed[True-True-False-True-True] | 0.1104ms | 31.9772μs | 31.2723 KOps/s | 31.3523 KOps/s | |
test_step_mdp_speed[True-True-False-True-False] | 46.5980μs | 19.2921μs | 51.8347 KOps/s | 50.8268 KOps/s | |
test_step_mdp_speed[True-True-False-False-True] | 49.5920μs | 18.8839μs | 52.9552 KOps/s | 53.2992 KOps/s | |
test_step_mdp_speed[True-True-False-False-False] | 0.6018ms | 11.7180μs | 85.3390 KOps/s | 84.7242 KOps/s | |
test_step_mdp_speed[True-False-True-True-True] | 71.4740μs | 33.8040μs | 29.5823 KOps/s | 29.4134 KOps/s | |
test_step_mdp_speed[True-False-True-True-False] | 48.8210μs | 21.4050μs | 46.7181 KOps/s | 47.0335 KOps/s | |
test_step_mdp_speed[True-False-True-False-True] | 46.4360μs | 18.8765μs | 52.9758 KOps/s | 53.7323 KOps/s | |
test_step_mdp_speed[True-False-True-False-False] | 46.9670μs | 11.6698μs | 85.6912 KOps/s | 84.6826 KOps/s | |
test_step_mdp_speed[True-False-False-True-True] | 76.5130μs | 35.6120μs | 28.0804 KOps/s | 28.4195 KOps/s | |
test_step_mdp_speed[True-False-False-True-False] | 47.8590μs | 23.1232μs | 43.2466 KOps/s | 42.8846 KOps/s | |
test_step_mdp_speed[True-False-False-False-True] | 57.2870μs | 20.4482μs | 48.9040 KOps/s | 49.1908 KOps/s | |
test_step_mdp_speed[True-False-False-False-False] | 38.0310μs | 13.4505μs | 74.3465 KOps/s | 74.3014 KOps/s | |
test_step_mdp_speed[False-True-True-True-True] | 76.7530μs | 33.9322μs | 29.4705 KOps/s | 29.9140 KOps/s | |
test_step_mdp_speed[False-True-True-True-False] | 51.4960μs | 21.3685μs | 46.7978 KOps/s | 46.9924 KOps/s | |
test_step_mdp_speed[False-True-True-False-True] | 51.2350μs | 21.4067μs | 46.7144 KOps/s | 47.3663 KOps/s | |
test_step_mdp_speed[False-True-True-False-False] | 36.8990μs | 13.0070μs | 76.8815 KOps/s | 76.0788 KOps/s | |
test_step_mdp_speed[False-True-False-True-True] | 80.0100μs | 35.8222μs | 27.9156 KOps/s | 28.1913 KOps/s | |
test_step_mdp_speed[False-True-False-True-False] | 52.9990μs | 22.9629μs | 43.5485 KOps/s | 43.3902 KOps/s | |
test_step_mdp_speed[False-True-False-False-True] | 2.5417ms | 23.3043μs | 42.9106 KOps/s | 43.2755 KOps/s | |
test_step_mdp_speed[False-True-False-False-False] | 53.7400μs | 14.7560μs | 67.7690 KOps/s | 66.9520 KOps/s | |
test_step_mdp_speed[False-False-True-True-True] | 84.6380μs | 37.3628μs | 26.7646 KOps/s | 26.9466 KOps/s | |
test_step_mdp_speed[False-False-True-True-False] | 0.7144ms | 24.6400μs | 40.5844 KOps/s | 40.0134 KOps/s | |
test_step_mdp_speed[False-False-True-False-True] | 76.2360μs | 23.5495μs | 42.4638 KOps/s | 43.1218 KOps/s | |
test_step_mdp_speed[False-False-True-False-False] | 42.1190μs | 14.7690μs | 67.7093 KOps/s | 66.9353 KOps/s | |
test_step_mdp_speed[False-False-False-True-True] | 71.4430μs | 38.4745μs | 25.9912 KOps/s | 25.3703 KOps/s | |
test_step_mdp_speed[False-False-False-True-False] | 55.6740μs | 26.2574μs | 38.0845 KOps/s | 37.5893 KOps/s | |
test_step_mdp_speed[False-False-False-False-True] | 62.0760μs | 24.8849μs | 40.1849 KOps/s | 40.5582 KOps/s | |
test_step_mdp_speed[False-False-False-False-False] | 72.7220μs | 16.2399μs | 61.5766 KOps/s | 60.3467 KOps/s | |
test_values[generalized_advantage_estimate-True-True] | 10.1259ms | 9.7704ms | 102.3502 Ops/s | 103.7433 Ops/s | |
test_values[vec_generalized_advantage_estimate-True-True] | 25.9605ms | 23.9269ms | 41.7940 Ops/s | 41.0944 Ops/s | |
test_values[td0_return_estimate-False-False] | 0.2301ms | 0.1850ms | 5.4051 KOps/s | 5.6843 KOps/s | |
test_values[td1_return_estimate-False-False] | 25.9433ms | 23.5133ms | 42.5291 Ops/s | 42.2193 Ops/s | |
test_values[vec_td1_return_estimate-False-False] | 25.0689ms | 24.1821ms | 41.3529 Ops/s | 40.7413 Ops/s | |
test_values[td_lambda_return_estimate-True-False] | 37.0155ms | 34.0573ms | 29.3623 Ops/s | 29.3521 Ops/s | |
test_values[vec_td_lambda_return_estimate-True-False] | 26.0550ms | 24.1628ms | 41.3860 Ops/s | 41.1246 Ops/s | |
test_gae_speed[generalized_advantage_estimate-False-1-512] | 8.5942ms | 8.3506ms | 119.7524 Ops/s | 119.2840 Ops/s | |
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] | 2.2503ms | 1.7703ms | 564.8824 Ops/s | 524.8695 Ops/s | |
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] | 0.4656ms | 0.3597ms | 2.7798 KOps/s | 2.7087 KOps/s | |
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] | 42.5029ms | 41.5124ms | 24.0892 Ops/s | 21.2543 Ops/s | |
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] | 4.4382ms | 3.4267ms | 291.8253 Ops/s | 290.1160 Ops/s | |
test_dqn_speed[False-None] | 5.8178ms | 1.3758ms | 726.8440 Ops/s | 707.0747 Ops/s | |
test_dqn_speed[False-backward] | 1.9255ms | 1.8605ms | 537.4879 Ops/s | 528.6901 Ops/s | |
test_dqn_speed[True-None] | 0.7769ms | 0.4858ms | 2.0586 KOps/s | 2.0717 KOps/s | |
test_dqn_speed[True-backward] | 0.9513ms | 0.8922ms | 1.1208 KOps/s | 1.0935 KOps/s | |
test_dqn_speed[reduce-overhead-None] | 0.9275ms | 0.4863ms | 2.0562 KOps/s | 2.0283 KOps/s | |
test_dqn_speed[reduce-overhead-backward] | 1.0948ms | 0.9068ms | 1.1028 KOps/s | 1.0848 KOps/s | |
test_ddpg_speed[False-None] | 3.2082ms | 2.8425ms | 351.8057 Ops/s | 348.0763 Ops/s | |
test_ddpg_speed[False-backward] | 4.0872ms | 3.9889ms | 250.6988 Ops/s | 249.0576 Ops/s | |
test_ddpg_speed[True-None] | 1.4918ms | 1.2114ms | 825.5213 Ops/s | 815.5732 Ops/s | |
test_ddpg_speed[True-backward] | 2.1931ms | 2.0947ms | 477.3871 Ops/s | 466.7790 Ops/s | |
test_ddpg_speed[reduce-overhead-None] | 1.6529ms | 1.2169ms | 821.7639 Ops/s | 809.7616 Ops/s | |
test_ddpg_speed[reduce-overhead-backward] | 2.1799ms | 2.1059ms | 474.8541 Ops/s | 464.1395 Ops/s | |
test_sac_speed[False-None] | 9.0136ms | 7.8501ms | 127.3872 Ops/s | 124.5295 Ops/s | |
test_sac_speed[False-backward] | 11.2717ms | 10.6166ms | 94.1920 Ops/s | 92.5471 Ops/s | |
test_sac_speed[True-None] | 2.7609ms | 2.0755ms | 481.8035 Ops/s | 473.3975 Ops/s | |
test_sac_speed[True-backward] | 3.8112ms | 3.7411ms | 267.3034 Ops/s | 266.6852 Ops/s | |
test_sac_speed[reduce-overhead-None] | 2.6380ms | 2.0702ms | 483.0430 Ops/s | 468.9802 Ops/s | |
test_sac_speed[reduce-overhead-backward] | 3.8378ms | 3.7534ms | 266.4234 Ops/s | 264.5264 Ops/s | |
test_redq_speed[False-None] | 14.4541ms | 12.5808ms | 79.4861 Ops/s | 77.5183 Ops/s | |
test_redq_speed[False-backward] | 23.3050ms | 22.0286ms | 45.3956 Ops/s | 44.9683 Ops/s | |
test_redq_speed[True-None] | 5.3387ms | 4.7174ms | 211.9814 Ops/s | 209.6956 Ops/s | |
test_redq_speed[True-backward] | 13.5211ms | 12.0425ms | 83.0395 Ops/s | 83.1444 Ops/s | |
test_redq_speed[reduce-overhead-None] | 5.2545ms | 4.7223ms | 211.7602 Ops/s | 209.4196 Ops/s | |
test_redq_speed[reduce-overhead-backward] | 13.1965ms | 12.0161ms | 83.2215 Ops/s | 83.6053 Ops/s | |
test_redq_deprec_speed[False-None] | 14.0320ms | 12.5775ms | 79.5070 Ops/s | 76.3539 Ops/s | |
test_redq_deprec_speed[False-backward] | 19.7091ms | 18.2580ms | 54.7706 Ops/s | 54.6562 Ops/s | |
test_redq_deprec_speed[True-None] | 4.5104ms | 3.8446ms | 260.1038 Ops/s | 260.3947 Ops/s | |
test_redq_deprec_speed[True-backward] | 9.1694ms | 8.1843ms | 122.1857 Ops/s | 122.4589 Ops/s | |
test_redq_deprec_speed[reduce-overhead-None] | 4.2927ms | 3.7688ms | 265.3340 Ops/s | 261.5795 Ops/s | |
test_redq_deprec_speed[reduce-overhead-backward] | 8.7090ms | 8.1046ms | 123.3869 Ops/s | 122.3213 Ops/s | |
test_td3_speed[False-None] | 8.1589ms | 7.7854ms | 128.4448 Ops/s | 122.1800 Ops/s | |
test_td3_speed[False-backward] | 10.5448ms | 10.1527ms | 98.4960 Ops/s | 94.4637 Ops/s | |
test_td3_speed[True-None] | 1.9272ms | 1.7596ms | 568.3194 Ops/s | 557.9168 Ops/s | |
test_td3_speed[True-backward] | 3.3921ms | 3.3250ms | 300.7497 Ops/s | 295.7843 Ops/s | |
test_td3_speed[reduce-overhead-None] | 1.9440ms | 1.7620ms | 567.5464 Ops/s | 551.9491 Ops/s | |
test_td3_speed[reduce-overhead-backward] | 3.3873ms | 3.3280ms | 300.4812 Ops/s | 293.2294 Ops/s | |
test_cql_speed[False-None] | 40.1148ms | 36.2310ms | 27.6007 Ops/s | 27.2165 Ops/s | |
test_cql_speed[False-backward] | 49.1376ms | 46.0081ms | 21.7353 Ops/s | 21.0708 Ops/s | |
test_cql_speed[True-None] | 16.9323ms | 15.7514ms | 63.4866 Ops/s | 62.6828 Ops/s | |
test_cql_speed[True-backward] | 24.2140ms | 22.7599ms | 43.9370 Ops/s | 44.2715 Ops/s | |
test_cql_speed[reduce-overhead-None] | 16.9189ms | 15.8926ms | 62.9223 Ops/s | 62.3757 Ops/s | |
test_cql_speed[reduce-overhead-backward] | 23.5556ms | 22.6036ms | 44.2408 Ops/s | 44.2349 Ops/s | |
test_a2c_speed[False-None] | 8.3758ms | 7.0567ms | 141.7092 Ops/s | 139.0579 Ops/s | |
test_a2c_speed[False-backward] | 15.1353ms | 14.0782ms | 71.0316 Ops/s | 69.4393 Ops/s | |
test_a2c_speed[True-None] | 3.8905ms | 3.6507ms | 273.9170 Ops/s | 268.6422 Ops/s | |
test_a2c_speed[True-backward] | 10.7676ms | 10.1360ms | 98.6584 Ops/s | 98.1527 Ops/s | |
test_a2c_speed[reduce-overhead-None] | 4.5686ms | 3.6776ms | 271.9155 Ops/s | 270.3429 Ops/s | |
test_a2c_speed[reduce-overhead-backward] | 11.5991ms | 10.1074ms | 98.9378 Ops/s | 98.1996 Ops/s | |
test_ppo_speed[False-None] | 8.3831ms | 7.3596ms | 135.8775 Ops/s | 133.9827 Ops/s | |
test_ppo_speed[False-backward] | 15.9486ms | 14.6061ms | 68.4645 Ops/s | 68.5556 Ops/s | |
test_ppo_speed[True-None] | 4.3332ms | 4.0460ms | 247.1582 Ops/s | 246.0603 Ops/s | |
test_ppo_speed[True-backward] | 10.6062ms | 9.9927ms | 100.0727 Ops/s | 100.5906 Ops/s | |
test_ppo_speed[reduce-overhead-None] | 4.4732ms | 4.0491ms | 246.9679 Ops/s | 245.6017 Ops/s | |
test_ppo_speed[reduce-overhead-backward] | 10.8980ms | 9.9323ms | 100.6815 Ops/s | 99.7657 Ops/s | |
test_reinforce_speed[False-None] | 7.3001ms | 6.4740ms | 154.4643 Ops/s | 153.0735 Ops/s | |
test_reinforce_speed[False-backward] | 9.8438ms | 9.6885ms | 103.2147 Ops/s | 101.2734 Ops/s | |
test_reinforce_speed[True-None] | 3.8373ms | 3.0120ms | 332.0061 Ops/s | 330.5718 Ops/s | |
test_reinforce_speed[True-backward] | 9.8919ms | 8.9465ms | 111.7761 Ops/s | 110.5945 Ops/s | |
test_reinforce_speed[reduce-overhead-None] | 3.3533ms | 3.0022ms | 333.0941 Ops/s | 330.5399 Ops/s | |
test_reinforce_speed[reduce-overhead-backward] | 10.4248ms | 8.9425ms | 111.8253 Ops/s | 111.4389 Ops/s | |
test_iql_speed[False-None] | 0.2809s | 40.0614ms | 24.9617 Ops/s | 30.4420 Ops/s | |
test_iql_speed[False-backward] | 48.1314ms | 45.2606ms | 22.0943 Ops/s | 22.0912 Ops/s | |
test_iql_speed[True-None] | 12.0383ms | 11.1201ms | 89.9275 Ops/s | 89.0274 Ops/s | |
test_iql_speed[True-backward] | 22.7707ms | 21.6142ms | 46.2658 Ops/s | 45.5143 Ops/s | |
test_iql_speed[reduce-overhead-None] | 12.5043ms | 11.1688ms | 89.5353 Ops/s | 87.3343 Ops/s | |
test_iql_speed[reduce-overhead-backward] | 22.7735ms | 21.7914ms | 45.8897 Ops/s | 45.4066 Ops/s | |
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] | 6.0390ms | 4.7624ms | 209.9780 Ops/s | 210.1910 Ops/s | |
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] | 0.9451ms | 0.5054ms | 1.9788 KOps/s | 1.9390 KOps/s | |
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] | 0.6996ms | 0.4778ms | 2.0930 KOps/s | 2.0300 KOps/s | |
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] | 5.4655ms | 4.4986ms | 222.2912 Ops/s | 215.0591 Ops/s | |
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] | 2.7112ms | 0.4985ms | 2.0059 KOps/s | 2.0107 KOps/s | |
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] | 0.7720ms | 0.4755ms | 2.1031 KOps/s | 2.0806 KOps/s | |
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] | 2.4216ms | 1.6344ms | 611.8622 Ops/s | 602.6389 Ops/s | |
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] | 1.7406ms | 1.5351ms | 651.4073 Ops/s | 635.8777 Ops/s | |
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] | 4.7872ms | 4.6269ms | 216.1270 Ops/s | 207.8164 Ops/s | |
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] | 1.0563ms | 0.6418ms | 1.5582 KOps/s | 1.5471 KOps/s | |
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] | 0.9584ms | 0.6100ms | 1.6393 KOps/s | 1.5964 KOps/s | |
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] | 4.7895ms | 4.5379ms | 220.3683 Ops/s | 217.3199 Ops/s | |
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] | 1.2694ms | 0.5040ms | 1.9842 KOps/s | 1.9565 KOps/s | |
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] | 0.7955ms | 0.4869ms | 2.0538 KOps/s | 2.0445 KOps/s | |
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] | 5.0152ms | 4.4777ms | 223.3305 Ops/s | 220.1912 Ops/s | |
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] | 2.1636ms | 0.4981ms | 2.0075 KOps/s | 2.0054 KOps/s | |
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] | 0.6766ms | 0.4703ms | 2.1262 KOps/s | 2.0476 KOps/s | |
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] | 6.1536ms | 4.6399ms | 215.5221 Ops/s | 215.3487 Ops/s | |
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] | 1.3375ms | 0.6335ms | 1.5786 KOps/s | 1.5302 KOps/s | |
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] | 0.7740ms | 0.6113ms | 1.6360 KOps/s | 1.6110 KOps/s | |
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] | 5.8435ms | 4.2129ms | 237.3680 Ops/s | 241.7355 Ops/s | |
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] | 7.3660ms | 2.3100ms | 432.9044 Ops/s | 425.9975 Ops/s | |
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] | 6.1007ms | 1.3649ms | 732.6410 Ops/s | 789.7557 Ops/s | |
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] | 5.4710ms | 4.2123ms | 237.4013 Ops/s | 35.9268 Ops/s | |
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] | 7.2071ms | 2.3126ms | 432.4170 Ops/s | 464.2506 Ops/s | |
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] | 1.8714ms | 1.1696ms | 854.9780 Ops/s | 749.0724 Ops/s | |
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] | 0.4347s | 12.9865ms | 77.0028 Ops/s | 224.4134 Ops/s | |
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] | 9.8904ms | 2.5136ms | 397.8281 Ops/s | 411.3473 Ops/s | |
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] | 2.1772ms | 1.4284ms | 700.0995 Ops/s | 677.4530 Ops/s | |
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] | 11.7432ms | 11.3114ms | 88.4064 Ops/s | 85.0623 Ops/s | |
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] | 15.3937ms | 13.8592ms | 72.1543 Ops/s | 71.8813 Ops/s | |
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] | 21.2162ms | 20.2398ms | 49.4075 Ops/s | 49.0083 Ops/s | |
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] | 15.2626ms | 14.1046ms | 70.8989 Ops/s | 69.6219 Ops/s | |
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] | 21.9023ms | 20.1662ms | 49.5879 Ops/s | 48.7754 Ops/s | |
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] | 16.2039ms | 15.3252ms | 65.2520 Ops/s | 63.4861 Ops/s |
|
Name | Max | Mean | Ops | Ops on Repo HEAD
|
Change |
---|---|---|---|---|---|
test_simple | 0.8331s | 0.7457s | 1.3410 Ops/s | 1.3226 Ops/s | |
test_transformed | 1.4170s | 1.3322s | 0.7506 Ops/s | 0.7673 Ops/s | |
test_serial | 2.2484s | 2.1759s | 0.4596 Ops/s | 0.4616 Ops/s | |
test_parallel | 1.9424s | 1.8971s | 0.5271 Ops/s | 0.5351 Ops/s | |
test_step_mdp_speed[True-True-True-True-True] | 0.1346ms | 39.4855μs | 25.3257 KOps/s | 25.6420 KOps/s | |
test_step_mdp_speed[True-True-True-True-False] | 64.8030μs | 23.4188μs | 42.7008 KOps/s | 43.0386 KOps/s | |
test_step_mdp_speed[True-True-True-False-True] | 54.2630μs | 22.4862μs | 44.4717 KOps/s | 44.7840 KOps/s | |
test_step_mdp_speed[True-True-True-False-False] | 47.2030μs | 13.0061μs | 76.8872 KOps/s | 77.6982 KOps/s | |
test_step_mdp_speed[True-True-False-True-True] | 76.0640μs | 42.9325μs | 23.2924 KOps/s | 23.3259 KOps/s | |
test_step_mdp_speed[True-True-False-True-False] | 69.5240μs | 25.5653μs | 39.1155 KOps/s | 39.5846 KOps/s | |
test_step_mdp_speed[True-True-False-False-True] | 76.3140μs | 25.0944μs | 39.8495 KOps/s | 40.8683 KOps/s | |
test_step_mdp_speed[True-True-False-False-False] | 50.3930μs | 15.5064μs | 64.4895 KOps/s | 64.7274 KOps/s | |
test_step_mdp_speed[True-False-True-True-True] | 82.9250μs | 45.0451μs | 22.2000 KOps/s | 22.1610 KOps/s | |
test_step_mdp_speed[True-False-True-True-False] | 68.6430μs | 28.1766μs | 35.4905 KOps/s | 35.6142 KOps/s | |
test_step_mdp_speed[True-False-True-False-True] | 71.3830μs | 24.4693μs | 40.8675 KOps/s | 40.5244 KOps/s | |
test_step_mdp_speed[True-False-True-False-False] | 65.4530μs | 15.3640μs | 65.0873 KOps/s | 65.0465 KOps/s | |
test_step_mdp_speed[True-False-False-True-True] | 0.1085ms | 46.1105μs | 21.6871 KOps/s | 21.2187 KOps/s | |
test_step_mdp_speed[True-False-False-True-False] | 0.4233ms | 30.5537μs | 32.7293 KOps/s | 32.5060 KOps/s | |
test_step_mdp_speed[True-False-False-False-True] | 0.4126ms | 26.6695μs | 37.4961 KOps/s | 35.8969 KOps/s | |
test_step_mdp_speed[True-False-False-False-False] | 51.8930μs | 17.6526μs | 56.6487 KOps/s | 54.9500 KOps/s | |
test_step_mdp_speed[False-True-True-True-True] | 0.4371ms | 45.2462μs | 22.1013 KOps/s | 22.4696 KOps/s | |
test_step_mdp_speed[False-True-True-True-False] | 0.4153ms | 28.3049μs | 35.3295 KOps/s | 35.6003 KOps/s | |
test_step_mdp_speed[False-True-True-False-True] | 2.6082ms | 29.0234μs | 34.4550 KOps/s | 35.3277 KOps/s | |
test_step_mdp_speed[False-True-True-False-False] | 0.4031ms | 17.2680μs | 57.9106 KOps/s | 58.2366 KOps/s | |
test_step_mdp_speed[False-True-False-True-True] | 88.8440μs | 47.6745μs | 20.9756 KOps/s | 20.6517 KOps/s | |
test_step_mdp_speed[False-True-False-True-False] | 0.4154ms | 30.5496μs | 32.7336 KOps/s | 33.3461 KOps/s | |
test_step_mdp_speed[False-True-False-False-True] | 0.4196ms | 31.6186μs | 31.6269 KOps/s | 31.1991 KOps/s | |
test_step_mdp_speed[False-True-False-False-False] | 0.4110ms | 19.1155μs | 52.3136 KOps/s | 49.0298 KOps/s | |
test_step_mdp_speed[False-False-True-True-True] | 0.4436ms | 50.4641μs | 19.8161 KOps/s | 19.8372 KOps/s | |
test_step_mdp_speed[False-False-True-True-False] | 71.4040μs | 33.3401μs | 29.9939 KOps/s | 30.9501 KOps/s | |
test_step_mdp_speed[False-False-True-False-True] | 0.4210ms | 31.4136μs | 31.8333 KOps/s | 33.0881 KOps/s | |
test_step_mdp_speed[False-False-True-False-False] | 0.4080ms | 19.4069μs | 51.5280 KOps/s | 52.2581 KOps/s | |
test_step_mdp_speed[False-False-False-True-True] | 0.4417ms | 52.0148μs | 19.2253 KOps/s | 19.7702 KOps/s | |
test_step_mdp_speed[False-False-False-True-False] | 0.4157ms | 35.4361μs | 28.2198 KOps/s | 28.6182 KOps/s | |
test_step_mdp_speed[False-False-False-False-True] | 66.0230μs | 32.9336μs | 30.3641 KOps/s | 30.6057 KOps/s | |
test_step_mdp_speed[False-False-False-False-False] | 0.4166ms | 21.7317μs | 46.0158 KOps/s | 46.4479 KOps/s | |
test_values[generalized_advantage_estimate-True-True] | 26.0642ms | 25.5851ms | 39.0853 Ops/s | 38.7180 Ops/s | |
test_values[vec_generalized_advantage_estimate-True-True] | 0.1057s | 3.0219ms | 330.9156 Ops/s | 295.6867 Ops/s | |
test_values[td0_return_estimate-False-False] | 0.1071ms | 81.0409μs | 12.3394 KOps/s | 12.1889 KOps/s | |
test_values[td1_return_estimate-False-False] | 57.6439ms | 56.9781ms | 17.5506 Ops/s | 17.4302 Ops/s | |
test_values[vec_td1_return_estimate-False-False] | 1.3107ms | 1.0966ms | 911.9222 Ops/s | 910.3535 Ops/s | |
test_values[td_lambda_return_estimate-True-False] | 94.1184ms | 90.3863ms | 11.0636 Ops/s | 11.0489 Ops/s | |
test_values[vec_td_lambda_return_estimate-True-False] | 1.3670ms | 1.0972ms | 911.3850 Ops/s | 917.3982 Ops/s | |
test_gae_speed[generalized_advantage_estimate-False-1-512] | 25.8538ms | 25.4327ms | 39.3195 Ops/s | 37.5368 Ops/s | |
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] | 1.0350ms | 0.7712ms | 1.2966 KOps/s | 1.2728 KOps/s | |
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] | 0.8179ms | 0.6844ms | 1.4612 KOps/s | 1.4073 KOps/s | |
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] | 1.5865ms | 1.4999ms | 666.7223 Ops/s | 657.0025 Ops/s | |
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] | 0.7610ms | 0.6991ms | 1.4303 KOps/s | 1.3824 KOps/s | |
test_dqn_speed[False-None] | 1.8868ms | 1.5381ms | 650.1712 Ops/s | 638.7910 Ops/s | |
test_dqn_speed[False-backward] | 2.3391ms | 2.1567ms | 463.6627 Ops/s | 468.9972 Ops/s | |
test_dqn_speed[True-None] | 0.9715ms | 0.5625ms | 1.7779 KOps/s | 1.7671 KOps/s | |
test_dqn_speed[True-backward] | 1.2833ms | 1.2395ms | 806.7796 Ops/s | 864.8065 Ops/s | |
test_dqn_speed[reduce-overhead-None] | 0.6698ms | 0.5977ms | 1.6731 KOps/s | 1.6996 KOps/s | |
test_dqn_speed[reduce-overhead-backward] | 1.1118ms | 1.0699ms | 934.6542 Ops/s | 1.0267 KOps/s | |
test_ddpg_speed[False-None] | 3.2689ms | 2.9083ms | 343.8492 Ops/s | 339.9103 Ops/s | |
test_ddpg_speed[False-backward] | 4.7161ms | 4.3011ms | 232.4990 Ops/s | 241.6606 Ops/s | |
test_ddpg_speed[True-None] | 1.7602ms | 1.3570ms | 736.9002 Ops/s | 739.8904 Ops/s | |
test_ddpg_speed[True-backward] | 2.6749ms | 2.6124ms | 382.7851 Ops/s | 406.0546 Ops/s | |
test_ddpg_speed[reduce-overhead-None] | 1.5371ms | 1.3684ms | 730.7612 Ops/s | 730.3859 Ops/s | |
test_ddpg_speed[reduce-overhead-backward] | 2.1164ms | 2.0363ms | 491.0831 Ops/s | 523.2268 Ops/s | |
test_sac_speed[False-None] | 8.5271ms | 8.0985ms | 123.4791 Ops/s | 124.3708 Ops/s | |
test_sac_speed[False-backward] | 11.7951ms | 11.3163ms | 88.3684 Ops/s | 90.6642 Ops/s | |
test_sac_speed[True-None] | 1.9856ms | 1.8498ms | 540.6133 Ops/s | 532.8731 Ops/s | |
test_sac_speed[True-backward] | 3.8888ms | 3.7532ms | 266.4408 Ops/s | 276.0777 Ops/s | |
test_sac_speed[reduce-overhead-None] | 21.3247ms | 12.0003ms | 83.3315 Ops/s | 83.2914 Ops/s | |
test_sac_speed[reduce-overhead-backward] | 2.2493ms | 1.7863ms | 559.8060 Ops/s | 590.7896 Ops/s | |
test_redq_speed[False-None] | 7.9837ms | 7.5636ms | 132.2125 Ops/s | 131.5456 Ops/s | |
test_redq_speed[False-backward] | 12.1117ms | 11.7791ms | 84.8962 Ops/s | 86.7153 Ops/s | |
test_redq_speed[True-None] | 2.4772ms | 2.3150ms | 431.9688 Ops/s | 412.7115 Ops/s | |
test_redq_speed[True-backward] | 4.5914ms | 4.2179ms | 237.0823 Ops/s | 244.7235 Ops/s | |
test_redq_speed[reduce-overhead-None] | 2.5157ms | 2.3344ms | 428.3801 Ops/s | 405.7114 Ops/s | |
test_redq_speed[reduce-overhead-backward] | 4.5877ms | 4.2239ms | 236.7498 Ops/s | 241.4718 Ops/s | |
test_redq_deprec_speed[False-None] | 9.4102ms | 9.1014ms | 109.8734 Ops/s | 109.0406 Ops/s | |
test_redq_deprec_speed[False-backward] | 12.8452ms | 12.3623ms | 80.8913 Ops/s | 82.6853 Ops/s | |
test_redq_deprec_speed[True-None] | 3.0760ms | 2.6600ms | 375.9443 Ops/s | 370.4694 Ops/s | |
test_redq_deprec_speed[True-backward] | 4.9300ms | 4.5169ms | 221.3894 Ops/s | 218.3660 Ops/s | |
test_redq_deprec_speed[reduce-overhead-None] | 2.8923ms | 2.6535ms | 376.8589 Ops/s | 352.0590 Ops/s | |
test_redq_deprec_speed[reduce-overhead-backward] | 4.4674ms | 4.3566ms | 229.5364 Ops/s | 218.5367 Ops/s | |
test_td3_speed[False-None] | 8.2782ms | 8.0475ms | 124.2625 Ops/s | 124.9210 Ops/s | |
test_td3_speed[False-backward] | 10.8825ms | 10.3915ms | 96.2324 Ops/s | 94.5092 Ops/s | |
test_td3_speed[True-None] | 1.6796ms | 1.6562ms | 603.7749 Ops/s | 577.6802 Ops/s | |
test_td3_speed[True-backward] | 3.3557ms | 3.2189ms | 310.6668 Ops/s | 290.5484 Ops/s | |
test_td3_speed[reduce-overhead-None] | 54.4607ms | 26.5238ms | 37.7020 Ops/s | 36.0362 Ops/s | |
test_td3_speed[reduce-overhead-backward] | 1.4134ms | 1.3491ms | 741.2457 Ops/s | 649.3116 Ops/s | |
test_cql_speed[False-None] | 17.3602ms | 16.9174ms | 59.1106 Ops/s | 59.2257 Ops/s | |
test_cql_speed[False-backward] | 22.6145ms | 22.1145ms | 45.2193 Ops/s | 44.4315 Ops/s | |
test_cql_speed[True-None] | 3.3710ms | 3.2934ms | 303.6411 Ops/s | 299.5196 Ops/s | |
test_cql_speed[True-backward] | 6.0605ms | 5.6048ms | 178.4191 Ops/s | 171.8801 Ops/s | |
test_cql_speed[reduce-overhead-None] | 21.1194ms | 13.2038ms | 75.7358 Ops/s | 56.8894 Ops/s | |
test_cql_speed[reduce-overhead-backward] | 1.9511ms | 1.8285ms | 546.8975 Ops/s | 491.0629 Ops/s | |
test_a2c_speed[False-None] | 3.2989ms | 3.2086ms | 311.6661 Ops/s | 310.9954 Ops/s | |
test_a2c_speed[False-backward] | 6.7494ms | 6.1925ms | 161.4856 Ops/s | 154.2244 Ops/s | |
test_a2c_speed[True-None] | 1.4164ms | 1.3514ms | 739.9773 Ops/s | 734.1682 Ops/s | |
test_a2c_speed[True-backward] | 3.0187ms | 2.9202ms | 342.4376 Ops/s | 332.7847 Ops/s | |
test_a2c_speed[reduce-overhead-None] | 15.8702ms | 9.0503ms | 110.4936 Ops/s | 111.2086 Ops/s | |
test_a2c_speed[reduce-overhead-backward] | 1.5376ms | 1.4651ms | 682.5365 Ops/s | 669.8617 Ops/s | |
test_ppo_speed[False-None] | 3.8370ms | 3.7413ms | 267.2901 Ops/s | 268.2912 Ops/s | |
test_ppo_speed[False-backward] | 7.3762ms | 6.9298ms | 144.3044 Ops/s | 145.4196 Ops/s | |
test_ppo_speed[True-None] | 1.6227ms | 1.4124ms | 708.0043 Ops/s | 699.9398 Ops/s | |
test_ppo_speed[True-backward] | 3.4258ms | 3.2439ms | 308.2756 Ops/s | 303.8933 Ops/s | |
test_ppo_speed[reduce-overhead-None] | 1.0561ms | 0.9666ms | 1.0346 KOps/s | 1.0252 KOps/s | |
test_ppo_speed[reduce-overhead-backward] | 1.6919ms | 1.5599ms | 641.0547 Ops/s | 620.8279 Ops/s | |
test_reinforce_speed[False-None] | 2.4376ms | 2.3027ms | 434.2673 Ops/s | 436.3388 Ops/s | |
test_reinforce_speed[False-backward] | 3.8605ms | 3.4513ms | 289.7430 Ops/s | 289.6390 Ops/s | |
test_reinforce_speed[True-None] | 1.3739ms | 1.3023ms | 767.8712 Ops/s | 750.9550 Ops/s | |
test_reinforce_speed[True-backward] | 3.1277ms | 3.0847ms | 324.1808 Ops/s | 323.4680 Ops/s | |
test_reinforce_speed[reduce-overhead-None] | 18.3099ms | 10.1736ms | 98.2935 Ops/s | 100.0588 Ops/s | |
test_reinforce_speed[reduce-overhead-backward] | 1.7389ms | 1.6127ms | 620.0639 Ops/s | 599.2223 Ops/s | |
test_iql_speed[False-None] | 9.6445ms | 9.2060ms | 108.6247 Ops/s | 106.5105 Ops/s | |
test_iql_speed[False-backward] | 13.6711ms | 13.1679ms | 75.9423 Ops/s | 74.6092 Ops/s | |
test_iql_speed[True-None] | 2.3034ms | 2.2428ms | 445.8673 Ops/s | 431.3280 Ops/s | |
test_iql_speed[True-backward] | 5.3873ms | 4.9643ms | 201.4387 Ops/s | 197.4219 Ops/s | |
test_iql_speed[reduce-overhead-None] | 19.1433ms | 11.3003ms | 88.4932 Ops/s | 88.5802 Ops/s | |
test_iql_speed[reduce-overhead-backward] | 2.1131ms | 2.0673ms | 483.7250 Ops/s | 459.4598 Ops/s | |
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] | 7.9166ms | 6.2975ms | 158.7921 Ops/s | 156.8184 Ops/s | |
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] | 0.5902ms | 0.3430ms | 2.9159 KOps/s | 2.9495 KOps/s | |
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] | 0.5980ms | 0.3253ms | 3.0744 KOps/s | 3.7307 KOps/s | |
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] | 6.3896ms | 6.0357ms | 165.6818 Ops/s | 164.2297 Ops/s | |
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] | 0.5652ms | 0.2593ms | 3.8558 KOps/s | 2.8774 KOps/s | |
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] | 0.6783ms | 0.2382ms | 4.1976 KOps/s | 3.6891 KOps/s | |
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] | 1.4931ms | 1.2711ms | 786.7328 Ops/s | 713.4955 Ops/s | |
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] | 1.4886ms | 1.2346ms | 810.0093 Ops/s | 851.7668 Ops/s | |
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] | 6.3592ms | 6.1836ms | 161.7169 Ops/s | 158.0731 Ops/s | |
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] | 1.1018ms | 0.4520ms | 2.2122 KOps/s | 2.4454 KOps/s | |
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] | 0.6113ms | 0.3990ms | 2.5064 KOps/s | 2.3809 KOps/s | |
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] | 6.1970ms | 6.0545ms | 165.1665 Ops/s | 162.8386 Ops/s | |
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] | 0.7575ms | 0.2995ms | 3.3389 KOps/s | 3.0706 KOps/s | |
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] | 0.5172ms | 0.2796ms | 3.5761 KOps/s | 3.2651 KOps/s | |
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] | 9.4078ms | 6.0906ms | 164.1870 Ops/s | 164.1971 Ops/s | |
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] | 0.6091ms | 0.3324ms | 3.0081 KOps/s | 3.8633 KOps/s | |
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] | 0.5560ms | 0.3198ms | 3.1270 KOps/s | 4.1911 KOps/s | |
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] | 6.3761ms | 6.2188ms | 160.8029 Ops/s | 157.3005 Ops/s | |
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] | 1.1805ms | 0.4107ms | 2.4349 KOps/s | 2.1871 KOps/s | |
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] | 0.6507ms | 0.4057ms | 2.4648 KOps/s | 2.2142 KOps/s | |
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] | 7.2367ms | 5.5136ms | 181.3699 Ops/s | 178.7910 Ops/s | |
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] | 9.5947ms | 2.0791ms | 480.9747 Ops/s | 446.4666 Ops/s | |
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] | 6.8946ms | 1.2321ms | 811.6183 Ops/s | 797.5663 Ops/s | |
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] | 7.1076ms | 5.6494ms | 177.0097 Ops/s | 179.8451 Ops/s | |
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] | 9.9971ms | 2.0925ms | 477.8987 Ops/s | 430.5756 Ops/s | |
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] | 3.5073ms | 1.1556ms | 865.3174 Ops/s | 756.4492 Ops/s | |
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] | 0.4856s | 15.4218ms | 64.8434 Ops/s | 31.7986 Ops/s | |
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] | 3.9772ms | 1.8452ms | 541.9570 Ops/s | 455.0705 Ops/s | |
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] | 2.2524ms | 1.2172ms | 821.5284 Ops/s | 725.4598 Ops/s | |
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] | 13.1510ms | 12.9328ms | 77.3230 Ops/s | 74.7232 Ops/s | |
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] | 18.4643ms | 16.7600ms | 59.6660 Ops/s | 59.1614 Ops/s | |
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] | 18.2872ms | 17.6228ms | 56.7446 Ops/s | 55.6830 Ops/s | |
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] | 18.4702ms | 16.8749ms | 59.2597 Ops/s | 58.3639 Ops/s | |
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] | 18.1551ms | 17.5174ms | 57.0862 Ops/s | 55.6188 Ops/s | |
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] | 19.2176ms | 18.0951ms | 55.2635 Ops/s | 53.5264 Ops/s |
vmoens
added a commit
that referenced
this pull request
Feb 4, 2025
ghstack-source-id: e7c6e0a4b8520da887fe7e602a351c3c72a08c4c Pull Request resolved: #2751
vmoens
added a commit
that referenced
this pull request
Feb 4, 2025
ghstack-source-id: e7c6e0a4b8520da887fe7e602a351c3c72a08c4c Pull Request resolved: #2751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Deprecation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):