Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix compile weakrefs errors #2742

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Feb 3, 2025

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Feb 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2742

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens added a commit that referenced this pull request Feb 3, 2025
ghstack-source-id: ee6daf6bdb4581ce90457dc650a5a2836d1151f6
Pull Request resolved: #2742
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 3, 2025
@vmoens vmoens added the bug Something isn't working label Feb 3, 2025
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 3, 2025
ghstack-source-id: 8469e9aedea3b8c8f29e5e1e9d3b1dcb65364612
Pull Request resolved: #2742
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 3, 2025
ghstack-source-id: c406c21cde6b20a81a5d8b91c05d5fe0bd806455
Pull Request resolved: #2742
vmoens added a commit that referenced this pull request Feb 3, 2025
ghstack-source-id: c406c21cde6b20a81a5d8b91c05d5fe0bd806455
Pull Request resolved: #2742
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 3, 2025
ghstack-source-id: c7a19dfe012f21b0a2bc4e166d208b98b7902940
Pull Request resolved: #2742
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 3, 2025
ghstack-source-id: 3cb4c62f465a3c0581064b3ff89290b9d225eb3f
Pull Request resolved: #2742
@vmoens vmoens merged commit e125d5c into gh/vmoens/85/base Feb 3, 2025
54 of 62 checks passed
vmoens added a commit that referenced this pull request Feb 3, 2025
ghstack-source-id: 3cb4c62f465a3c0581064b3ff89290b9d225eb3f
Pull Request resolved: #2742
@vmoens vmoens deleted the gh/vmoens/85/head branch February 3, 2025 14:07
Copy link

github-actions bot commented Feb 3, 2025

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 149. Improved: $\large\color{#35bf28}28$. Worsened: $\large\color{#d91a1a}11$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_simple 0.8170s 0.7323s 1.3656 Ops/s 1.3471 Ops/s $\color{#35bf28}+1.37\%$
test_transformed 1.3569s 1.2699s 0.7875 Ops/s 0.7446 Ops/s $\textbf{\color{#35bf28}+5.76\%}$
test_serial 2.1059s 2.1043s 0.4752 Ops/s 0.4596 Ops/s $\color{#35bf28}+3.39\%$
test_parallel 1.8455s 1.8243s 0.5482 Ops/s 0.5419 Ops/s $\color{#35bf28}+1.16\%$
test_step_mdp_speed[True-True-True-True-True] 0.2387ms 39.3177μs 25.4338 KOps/s 25.4178 KOps/s $\color{#35bf28}+0.06\%$
test_step_mdp_speed[True-True-True-True-False] 64.5310μs 22.9505μs 43.5720 KOps/s 43.8689 KOps/s $\color{#d91a1a}-0.68\%$
test_step_mdp_speed[True-True-True-False-True] 64.1210μs 21.5571μs 46.3885 KOps/s 46.1836 KOps/s $\color{#35bf28}+0.44\%$
test_step_mdp_speed[True-True-True-False-False] 51.7010μs 12.5979μs 79.3785 KOps/s 80.8671 KOps/s $\color{#d91a1a}-1.84\%$
test_step_mdp_speed[True-True-False-True-True] 84.0320μs 41.9701μs 23.8265 KOps/s 23.7440 KOps/s $\color{#35bf28}+0.35\%$
test_step_mdp_speed[True-True-False-True-False] 94.2020μs 24.1761μs 41.3631 KOps/s 39.4906 KOps/s $\color{#35bf28}+4.74\%$
test_step_mdp_speed[True-True-False-False-True] 59.4410μs 24.1705μs 41.3728 KOps/s 41.8696 KOps/s $\color{#d91a1a}-1.19\%$
test_step_mdp_speed[True-True-False-False-False] 47.1910μs 14.8169μs 67.4904 KOps/s 68.0811 KOps/s $\color{#d91a1a}-0.87\%$
test_step_mdp_speed[True-False-True-True-True] 80.8920μs 43.8211μs 22.8200 KOps/s 22.1897 KOps/s $\color{#35bf28}+2.84\%$
test_step_mdp_speed[True-False-True-True-False] 61.2510μs 27.4508μs 36.4288 KOps/s 36.7361 KOps/s $\color{#d91a1a}-0.84\%$
test_step_mdp_speed[True-False-True-False-True] 61.0520μs 24.1513μs 41.4057 KOps/s 41.6743 KOps/s $\color{#d91a1a}-0.64\%$
test_step_mdp_speed[True-False-True-False-False] 50.2310μs 15.0929μs 66.2564 KOps/s 67.2727 KOps/s $\color{#d91a1a}-1.51\%$
test_step_mdp_speed[True-False-False-True-True] 86.9820μs 46.4422μs 21.5322 KOps/s 21.5515 KOps/s $\color{#d91a1a}-0.09\%$
test_step_mdp_speed[True-False-False-True-False] 62.1410μs 29.2823μs 34.1504 KOps/s 34.9705 KOps/s $\color{#d91a1a}-2.35\%$
test_step_mdp_speed[True-False-False-False-True] 64.0210μs 26.3252μs 37.9864 KOps/s 39.1124 KOps/s $\color{#d91a1a}-2.88\%$
test_step_mdp_speed[True-False-False-False-False] 47.8510μs 17.3306μs 57.7015 KOps/s 60.6215 KOps/s $\color{#d91a1a}-4.82\%$
test_step_mdp_speed[False-True-True-True-True] 80.6020μs 43.6268μs 22.9217 KOps/s 22.4803 KOps/s $\color{#35bf28}+1.96\%$
test_step_mdp_speed[False-True-True-True-False] 60.8920μs 27.3534μs 36.5585 KOps/s 36.6296 KOps/s $\color{#d91a1a}-0.19\%$
test_step_mdp_speed[False-True-True-False-True] 2.6097ms 28.2756μs 35.3662 KOps/s 35.2632 KOps/s $\color{#35bf28}+0.29\%$
test_step_mdp_speed[False-True-True-False-False] 48.7700μs 16.9716μs 58.9219 KOps/s 59.3102 KOps/s $\color{#d91a1a}-0.65\%$
test_step_mdp_speed[False-True-False-True-True] 87.4720μs 46.1860μs 21.6516 KOps/s 21.5689 KOps/s $\color{#35bf28}+0.38\%$
test_step_mdp_speed[False-True-False-True-False] 61.1810μs 29.5945μs 33.7901 KOps/s 33.7777 KOps/s $\color{#35bf28}+0.04\%$
test_step_mdp_speed[False-True-False-False-True] 73.7210μs 29.8483μs 33.5028 KOps/s 32.9548 KOps/s $\color{#35bf28}+1.66\%$
test_step_mdp_speed[False-True-False-False-False] 54.0510μs 19.1736μs 52.1550 KOps/s 53.4868 KOps/s $\color{#d91a1a}-2.49\%$
test_step_mdp_speed[False-False-True-True-True] 93.4220μs 48.0550μs 20.8095 KOps/s 20.6171 KOps/s $\color{#35bf28}+0.93\%$
test_step_mdp_speed[False-False-True-True-False] 82.0010μs 31.8769μs 31.3707 KOps/s 31.0827 KOps/s $\color{#35bf28}+0.93\%$
test_step_mdp_speed[False-False-True-False-True] 68.6610μs 29.7044μs 33.6651 KOps/s 32.9787 KOps/s $\color{#35bf28}+2.08\%$
test_step_mdp_speed[False-False-True-False-False] 48.0110μs 19.0359μs 52.5323 KOps/s 52.8128 KOps/s $\color{#d91a1a}-0.53\%$
test_step_mdp_speed[False-False-False-True-True] 92.0020μs 50.8365μs 19.6709 KOps/s 19.6202 KOps/s $\color{#35bf28}+0.26\%$
test_step_mdp_speed[False-False-False-True-False] 75.9020μs 33.9015μs 29.4973 KOps/s 29.2284 KOps/s $\color{#35bf28}+0.92\%$
test_step_mdp_speed[False-False-False-False-True] 84.6210μs 31.9355μs 31.3131 KOps/s 31.0255 KOps/s $\color{#35bf28}+0.93\%$
test_step_mdp_speed[False-False-False-False-False] 55.9610μs 21.0464μs 47.5141 KOps/s 47.3095 KOps/s $\color{#35bf28}+0.43\%$
test_values[generalized_advantage_estimate-True-True] 25.9453ms 25.5241ms 39.1786 Ops/s 39.4659 Ops/s $\color{#d91a1a}-0.73\%$
test_values[vec_generalized_advantage_estimate-True-True] 0.1003s 2.9105ms 343.5803 Ops/s 336.7808 Ops/s $\color{#35bf28}+2.02\%$
test_values[td0_return_estimate-False-False] 0.1077ms 80.7696μs 12.3809 KOps/s 12.2843 KOps/s $\color{#35bf28}+0.79\%$
test_values[td1_return_estimate-False-False] 58.0976ms 56.6875ms 17.6406 Ops/s 17.6117 Ops/s $\color{#35bf28}+0.16\%$
test_values[vec_td1_return_estimate-False-False] 1.3820ms 1.0923ms 915.4944 Ops/s 916.6853 Ops/s $\color{#d91a1a}-0.13\%$
test_values[td_lambda_return_estimate-True-False] 91.8336ms 89.6985ms 11.1485 Ops/s 11.1882 Ops/s $\color{#d91a1a}-0.35\%$
test_values[vec_td_lambda_return_estimate-True-False] 1.4309ms 1.1030ms 906.6137 Ops/s 919.2807 Ops/s $\color{#d91a1a}-1.38\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 25.5127ms 25.3485ms 39.4501 Ops/s 39.5847 Ops/s $\color{#d91a1a}-0.34\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.0374ms 0.7740ms 1.2920 KOps/s 1.3114 KOps/s $\color{#d91a1a}-1.48\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7981ms 0.6982ms 1.4322 KOps/s 1.4055 KOps/s $\color{#35bf28}+1.90\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5535ms 1.4896ms 671.3313 Ops/s 666.3947 Ops/s $\color{#35bf28}+0.74\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.7628ms 0.6940ms 1.4410 KOps/s 1.3911 KOps/s $\color{#35bf28}+3.58\%$
test_dqn_speed[False-None] 1.6822ms 1.4816ms 674.9528 Ops/s 650.1310 Ops/s $\color{#35bf28}+3.82\%$
test_dqn_speed[False-backward] 2.1450ms 2.1042ms 475.2309 Ops/s 464.4095 Ops/s $\color{#35bf28}+2.33\%$
test_dqn_speed[True-None] 0.5971ms 0.5461ms 1.8313 KOps/s 1.7280 KOps/s $\textbf{\color{#35bf28}+5.98\%}$
test_dqn_speed[True-backward] 1.2605ms 1.2050ms 829.8836 Ops/s 863.0791 Ops/s $\color{#d91a1a}-3.85\%$
test_dqn_speed[reduce-overhead-None] 0.6166ms 0.5578ms 1.7927 KOps/s 1.7458 KOps/s $\color{#35bf28}+2.69\%$
test_dqn_speed[reduce-overhead-backward] 1.0766ms 1.0520ms 950.5834 Ops/s 1.0525 KOps/s $\textbf{\color{#d91a1a}-9.69\%}$
test_ddpg_speed[False-None] 3.1066ms 2.7881ms 358.6661 Ops/s 344.0619 Ops/s $\color{#35bf28}+4.24\%$
test_ddpg_speed[False-backward] 4.6026ms 4.1931ms 238.4865 Ops/s 234.7759 Ops/s $\color{#35bf28}+1.58\%$
test_ddpg_speed[True-None] 1.6576ms 1.3151ms 760.4231 Ops/s 742.4286 Ops/s $\color{#35bf28}+2.42\%$
test_ddpg_speed[True-backward] 2.5741ms 2.5326ms 394.8448 Ops/s 414.4959 Ops/s $\color{#d91a1a}-4.74\%$
test_ddpg_speed[reduce-overhead-None] 1.3897ms 1.3199ms 757.6561 Ops/s 744.3719 Ops/s $\color{#35bf28}+1.78\%$
test_ddpg_speed[reduce-overhead-backward] 2.0336ms 1.9958ms 501.0478 Ops/s 531.5997 Ops/s $\textbf{\color{#d91a1a}-5.75\%}$
test_sac_speed[False-None] 8.2954ms 7.9022ms 126.5463 Ops/s 123.0635 Ops/s $\color{#35bf28}+2.83\%$
test_sac_speed[False-backward] 11.5190ms 11.0747ms 90.2957 Ops/s 89.8831 Ops/s $\color{#35bf28}+0.46\%$
test_sac_speed[True-None] 1.8590ms 1.8066ms 553.5300 Ops/s 521.7884 Ops/s $\textbf{\color{#35bf28}+6.08\%}$
test_sac_speed[True-backward] 4.0841ms 3.6661ms 272.7682 Ops/s 279.8939 Ops/s $\color{#d91a1a}-2.55\%$
test_sac_speed[reduce-overhead-None] 20.5531ms 11.6989ms 85.4780 Ops/s 83.8877 Ops/s $\color{#35bf28}+1.90\%$
test_sac_speed[reduce-overhead-backward] 1.8187ms 1.7636ms 567.0279 Ops/s 607.8359 Ops/s $\textbf{\color{#d91a1a}-6.71\%}$
test_redq_speed[False-None] 7.7106ms 7.3208ms 136.5972 Ops/s 129.3376 Ops/s $\textbf{\color{#35bf28}+5.61\%}$
test_redq_speed[False-backward] 12.0613ms 11.5377ms 86.6727 Ops/s 85.9366 Ops/s $\color{#35bf28}+0.86\%$
test_redq_speed[True-None] 2.3862ms 2.2666ms 441.1836 Ops/s 432.0030 Ops/s $\color{#35bf28}+2.13\%$
test_redq_speed[True-backward] 4.2560ms 4.0909ms 244.4464 Ops/s 243.3061 Ops/s $\color{#35bf28}+0.47\%$
test_redq_speed[reduce-overhead-None] 2.4356ms 2.2889ms 436.8885 Ops/s 426.7496 Ops/s $\color{#35bf28}+2.38\%$
test_redq_speed[reduce-overhead-backward] 4.5409ms 4.1333ms 241.9368 Ops/s 246.8082 Ops/s $\color{#d91a1a}-1.97\%$
test_redq_deprec_speed[False-None] 9.2395ms 8.9070ms 112.2707 Ops/s 107.9589 Ops/s $\color{#35bf28}+3.99\%$
test_redq_deprec_speed[False-backward] 12.7400ms 12.1680ms 82.1827 Ops/s 80.9096 Ops/s $\color{#35bf28}+1.57\%$
test_redq_deprec_speed[True-None] 2.7893ms 2.6180ms 381.9680 Ops/s 376.6590 Ops/s $\color{#35bf28}+1.41\%$
test_redq_deprec_speed[True-backward] 4.5412ms 4.2395ms 235.8747 Ops/s 223.2392 Ops/s $\textbf{\color{#35bf28}+5.66\%}$
test_redq_deprec_speed[reduce-overhead-None] 2.6813ms 2.6037ms 384.0708 Ops/s 376.1574 Ops/s $\color{#35bf28}+2.10\%$
test_redq_deprec_speed[reduce-overhead-backward] 4.7208ms 4.2611ms 234.6816 Ops/s 220.1626 Ops/s $\textbf{\color{#35bf28}+6.59\%}$
test_td3_speed[False-None] 7.8744ms 7.7981ms 128.2363 Ops/s 123.9023 Ops/s $\color{#35bf28}+3.50\%$
test_td3_speed[False-backward] 10.6961ms 10.1475ms 98.5461 Ops/s 94.0424 Ops/s $\color{#35bf28}+4.79\%$
test_td3_speed[True-None] 1.6352ms 1.6132ms 619.8917 Ops/s 587.4145 Ops/s $\textbf{\color{#35bf28}+5.53\%}$
test_td3_speed[True-backward] 3.1669ms 3.1263ms 319.8704 Ops/s 311.3270 Ops/s $\color{#35bf28}+2.74\%$
test_td3_speed[reduce-overhead-None] 48.3999ms 25.0477ms 39.9238 Ops/s 37.7607 Ops/s $\textbf{\color{#35bf28}+5.73\%}$
test_td3_speed[reduce-overhead-backward] 1.3674ms 1.3310ms 751.3022 Ops/s 650.8400 Ops/s $\textbf{\color{#35bf28}+15.44\%}$
test_cql_speed[False-None] 16.7841ms 16.3481ms 61.1693 Ops/s 58.5963 Ops/s $\color{#35bf28}+4.39\%$
test_cql_speed[False-backward] 22.0231ms 21.5735ms 46.3531 Ops/s 43.4912 Ops/s $\textbf{\color{#35bf28}+6.58\%}$
test_cql_speed[True-None] 3.2997ms 3.1944ms 313.0514 Ops/s 303.1547 Ops/s $\color{#35bf28}+3.26\%$
test_cql_speed[True-backward] 5.9004ms 5.4323ms 184.0834 Ops/s 171.1004 Ops/s $\textbf{\color{#35bf28}+7.59\%}$
test_cql_speed[reduce-overhead-None] 21.0713ms 12.9152ms 77.4281 Ops/s 59.3605 Ops/s $\textbf{\color{#35bf28}+30.44\%}$
test_cql_speed[reduce-overhead-backward] 1.9471ms 1.8212ms 549.0809 Ops/s 499.3475 Ops/s $\textbf{\color{#35bf28}+9.96\%}$
test_a2c_speed[False-None] 3.5786ms 3.1270ms 319.7903 Ops/s 309.3829 Ops/s $\color{#35bf28}+3.36\%$
test_a2c_speed[False-backward] 6.6711ms 6.1642ms 162.2267 Ops/s 154.4131 Ops/s $\textbf{\color{#35bf28}+5.06\%}$
test_a2c_speed[True-None] 1.4259ms 1.3229ms 755.8888 Ops/s 753.2855 Ops/s $\color{#35bf28}+0.35\%$
test_a2c_speed[True-backward] 3.0254ms 2.8801ms 347.2114 Ops/s 323.9547 Ops/s $\textbf{\color{#35bf28}+7.18\%}$
test_a2c_speed[reduce-overhead-None] 15.3309ms 8.7917ms 113.7435 Ops/s 115.5297 Ops/s $\color{#d91a1a}-1.55\%$
test_a2c_speed[reduce-overhead-backward] 1.5509ms 1.4437ms 692.6489 Ops/s 684.0939 Ops/s $\color{#35bf28}+1.25\%$
test_ppo_speed[False-None] 3.7196ms 3.6321ms 275.3223 Ops/s 264.8182 Ops/s $\color{#35bf28}+3.97\%$
test_ppo_speed[False-backward] 7.2204ms 6.8521ms 145.9404 Ops/s 143.3791 Ops/s $\color{#35bf28}+1.79\%$
test_ppo_speed[True-None] 1.4709ms 1.3883ms 720.3089 Ops/s 713.6955 Ops/s $\color{#35bf28}+0.93\%$
test_ppo_speed[True-backward] 3.0644ms 2.9964ms 333.7356 Ops/s 310.2350 Ops/s $\textbf{\color{#35bf28}+7.58\%}$
test_ppo_speed[reduce-overhead-None] 1.0163ms 0.9500ms 1.0526 KOps/s 1.0504 KOps/s $\color{#35bf28}+0.21\%$
test_ppo_speed[reduce-overhead-backward] 1.4937ms 1.3860ms 721.4816 Ops/s 628.8990 Ops/s $\textbf{\color{#35bf28}+14.72\%}$
test_reinforce_speed[False-None] 2.4049ms 2.2371ms 447.0101 Ops/s 428.9071 Ops/s $\color{#35bf28}+4.22\%$
test_reinforce_speed[False-backward] 3.7218ms 3.2705ms 305.7609 Ops/s 287.2855 Ops/s $\textbf{\color{#35bf28}+6.43\%}$
test_reinforce_speed[True-None] 1.3438ms 1.2648ms 790.6488 Ops/s 775.2351 Ops/s $\color{#35bf28}+1.99\%$
test_reinforce_speed[True-backward] 3.3689ms 2.8932ms 345.6382 Ops/s 329.4928 Ops/s $\color{#35bf28}+4.90\%$
test_reinforce_speed[reduce-overhead-None] 18.2950ms 9.8641ms 101.3778 Ops/s 105.0782 Ops/s $\color{#d91a1a}-3.52\%$
test_reinforce_speed[reduce-overhead-backward] 1.5111ms 1.4541ms 687.7023 Ops/s 607.3981 Ops/s $\textbf{\color{#35bf28}+13.22\%}$
test_iql_speed[False-None] 9.4001ms 9.0237ms 110.8194 Ops/s 105.9491 Ops/s $\color{#35bf28}+4.60\%$
test_iql_speed[False-backward] 13.4463ms 12.6203ms 79.2372 Ops/s 74.7529 Ops/s $\textbf{\color{#35bf28}+6.00\%}$
test_iql_speed[True-None] 2.3084ms 2.1864ms 457.3792 Ops/s 440.7192 Ops/s $\color{#35bf28}+3.78\%$
test_iql_speed[True-backward] 5.0360ms 4.7259ms 211.6005 Ops/s 208.7207 Ops/s $\color{#35bf28}+1.38\%$
test_iql_speed[reduce-overhead-None] 18.6272ms 10.9405ms 91.4032 Ops/s 92.1844 Ops/s $\color{#d91a1a}-0.85\%$
test_iql_speed[reduce-overhead-backward] 1.9434ms 1.8764ms 532.9365 Ops/s 502.9741 Ops/s $\textbf{\color{#35bf28}+5.96\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.6848ms 6.0926ms 164.1325 Ops/s 161.5552 Ops/s $\color{#35bf28}+1.60\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.4841ms 0.2556ms 3.9124 KOps/s 3.7540 KOps/s $\color{#35bf28}+4.22\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.4611ms 0.2325ms 4.3009 KOps/s 3.2438 KOps/s $\textbf{\color{#35bf28}+32.59\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.1859ms 5.8290ms 171.5571 Ops/s 171.1659 Ops/s $\color{#35bf28}+0.23\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.3912ms 0.3302ms 3.0284 KOps/s 3.7974 KOps/s $\textbf{\color{#d91a1a}-20.25\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5797ms 0.2844ms 3.5162 KOps/s 3.9618 KOps/s $\textbf{\color{#d91a1a}-11.25\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.5961ms 1.3579ms 736.4520 Ops/s 793.3089 Ops/s $\textbf{\color{#d91a1a}-7.17\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.4715ms 1.3017ms 768.2422 Ops/s 767.8040 Ops/s $\color{#35bf28}+0.06\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.1224ms 6.0026ms 166.5948 Ops/s 163.7376 Ops/s $\color{#35bf28}+1.75\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.9928ms 0.4678ms 2.1378 KOps/s 2.3769 KOps/s $\textbf{\color{#d91a1a}-10.06\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.6320ms 0.3927ms 2.5466 KOps/s 2.5751 KOps/s $\color{#d91a1a}-1.11\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.0491ms 5.8872ms 169.8594 Ops/s 167.5996 Ops/s $\color{#35bf28}+1.35\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.1276ms 0.3454ms 2.8955 KOps/s 3.2669 KOps/s $\textbf{\color{#d91a1a}-11.37\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5403ms 0.3217ms 3.1083 KOps/s 3.2156 KOps/s $\color{#d91a1a}-3.34\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.0623ms 5.7730ms 173.2190 Ops/s 169.3700 Ops/s $\color{#35bf28}+2.27\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8134ms 0.2641ms 3.7868 KOps/s 3.5807 KOps/s $\textbf{\color{#35bf28}+5.75\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.4688ms 0.2405ms 4.1579 KOps/s 3.3173 KOps/s $\textbf{\color{#35bf28}+25.34\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.1338ms 5.9792ms 167.2473 Ops/s 159.7991 Ops/s $\color{#35bf28}+4.66\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.1621ms 0.4665ms 2.1436 KOps/s 2.3157 KOps/s $\textbf{\color{#d91a1a}-7.43\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.6816ms 0.4477ms 2.2335 KOps/s 2.5919 KOps/s $\textbf{\color{#d91a1a}-13.83\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 6.9583ms 5.4133ms 184.7289 Ops/s 180.6791 Ops/s $\color{#35bf28}+2.24\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 3.9387ms 1.7981ms 556.1516 Ops/s 438.4098 Ops/s $\textbf{\color{#35bf28}+26.86\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 8.9732ms 1.2327ms 811.1998 Ops/s 848.4732 Ops/s $\color{#d91a1a}-4.39\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 7.5269ms 5.5657ms 179.6705 Ops/s 180.7709 Ops/s $\color{#d91a1a}-0.61\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 8.5308ms 2.0021ms 499.4859 Ops/s 436.7875 Ops/s $\textbf{\color{#35bf28}+14.35\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 7.5705ms 1.2276ms 814.6037 Ops/s 862.0828 Ops/s $\textbf{\color{#d91a1a}-5.51\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.4933s 15.4432ms 64.7535 Ops/s 31.7772 Ops/s $\textbf{\color{#35bf28}+103.77\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 10.4184ms 2.1784ms 459.0427 Ops/s 452.5368 Ops/s $\color{#35bf28}+1.44\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 6.9308ms 1.3160ms 759.8630 Ops/s 753.8488 Ops/s $\color{#35bf28}+0.80\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 13.3190ms 12.7037ms 78.7173 Ops/s 74.6706 Ops/s $\textbf{\color{#35bf28}+5.42\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 18.4642ms 16.5787ms 60.3182 Ops/s 59.8527 Ops/s $\color{#35bf28}+0.78\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 17.6370ms 17.3353ms 57.6857 Ops/s 55.8603 Ops/s $\color{#35bf28}+3.27\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 18.9153ms 16.9881ms 58.8649 Ops/s 60.0170 Ops/s $\color{#d91a1a}-1.92\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 17.7433ms 17.2528ms 57.9617 Ops/s 56.4396 Ops/s $\color{#35bf28}+2.70\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 18.6362ms 17.6659ms 56.6061 Ops/s 54.8329 Ops/s $\color{#35bf28}+3.23\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants