-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Add tests for Tree #2738
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2738
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 8 Unrelated FailuresAs of commit 9a9272b with merge base dbc8e2e ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ghstack-source-id: 8f7aa07a4d36aa3664eaa19cc35bd66fb9e61c24 Pull Request resolved: #2738
I mostly wrote this to become more familiar with Tree. Maybe we don't strictly need these tests since a lot of it is also tested in TestMCTSForest, but I figured it might be good to have some tests that are independent of the MCTSForest API. If you think we don't need this, I'm fine with just closing it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely worth having! Thanks for that
ghstack-source-id: 8f7aa07a4d36aa3664eaa19cc35bd66fb9e61c24 Pull Request resolved: #2738
Stack from ghstack (oldest at bottom):