Skip to content

Commit

Permalink
amend
Browse files Browse the repository at this point in the history
  • Loading branch information
vmoens committed Feb 5, 2025
1 parent 59a557d commit 7e988a9
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/unittest/windows_optdepts/scripts/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ set -ex
this_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"

eval "$(./conda/Scripts/conda.exe 'shell.bash' 'hook')"
conda activate ./env
CALL conda.bat activate ./env

# TODO, refactor the below logic to make it easy to understand how to get correct cuda_version.
if [ "${CU_VERSION:-}" == cpu ] ; then
Expand Down
2 changes: 1 addition & 1 deletion .github/unittest/windows_optdepts/scripts/run_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -e

eval "$(./conda/Scripts/conda.exe 'shell.bash' 'hook')"
conda activate ./env
CALL conda.bat activate ./env

this_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
source "$this_dir/set_cuda_envs.sh"
Expand Down
5 changes: 2 additions & 3 deletions .github/unittest/windows_optdepts/scripts/setup_env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,12 @@ printf "* Creating a test environment\n"
conda create --prefix "${env_dir}" -y python="$PYTHON_VERSION"

printf "* Activating the environment"
conda deactivate
conda activate "${env_dir}"
CALL conda.bat activate "${env_dir}"

printf "Python version"
echo $(which python)
echo $(python --version)
echo $(conda info -e)
echo $(CALL conda.bat info -e)

#conda env update --file "${this_dir}/environment.yml" --prune

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-wheels-m1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- repository: pytorch/rl
smoke-test-script: test/smoke_test.py
package-name: torchrl
name: pytorch/rl
name: ${{ matrix.repository }}
uses: pytorch/test-infra/.github/workflows/build_wheels_macos.yml@main
with:
repository: ${{ matrix.repository }}
Expand Down
12 changes: 10 additions & 2 deletions .github/workflows/test-windows-optdepts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,23 @@ permissions:

jobs:
unittests-cpu:
strategy:
matrix:
python-version:
- "3.10"
runner: ["windows.4xlarge"]
gpu-arch-type: ["cpu"]
fail-fast: false
uses: pytorch/test-infra/.github/workflows/windows_job.yml@main
with:
runner: "windows.4xlarge"
repository: pytorch/rl
runner: ${{ matrix.runner }}
timeout: 40
test-infra-ref: main
script: |
set -euxo pipefail
export PYTHON_VERSION="3.9"
export PYTHON_VERSION=${{ matrix.python-version }}
export CU_VERSION="cpu"
export torch_cuda="False"
Expand Down
1 change: 1 addition & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ per-file-ignores =
examples/*.py: T201
test/opengl_rendering.py: T201
*/**/run-clang-format.py: T201
packaging/*/**.py: T201

exclude = venv
extend-select = B901, C401, C408, C409, TOR0, TOR1, TOR2
Expand Down

0 comments on commit 7e988a9

Please sign in to comment.