amend

pytorch · Feb 5, 2025 · 27296fc · 27296fc
1 parent 59a557d
commit 27296fc
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/.github/unittest/windows_optdepts/scripts/setup_env.sh b/.github/unittest/windows_optdepts/scripts/setup_env.sh
@@ -32,7 +32,6 @@ printf "* Creating a test environment\n"
 conda create --prefix "${env_dir}" -y python="$PYTHON_VERSION"
 
 printf "* Activating the environment"
-conda deactivate
 conda activate "${env_dir}"
 
 printf "Python version"

diff --git a/.github/workflows/build-wheels-m1.yml b/.github/workflows/build-wheels-m1.yml
@@ -34,7 +34,7 @@ jobs:
           - repository: pytorch/rl
             smoke-test-script: test/smoke_test.py
             package-name: torchrl
-    name: pytorch/rl
+    name: ${{ matrix.repository }}
     uses: pytorch/test-infra/.github/workflows/build_wheels_macos.yml@main
     with:
       repository: ${{ matrix.repository }}

diff --git a/.github/workflows/test-windows-optdepts.yml b/.github/workflows/test-windows-optdepts.yml
@@ -21,15 +21,23 @@ permissions:
 
 jobs:
   unittests-cpu:
+    strategy:
+      matrix:
+        python-version:
+          - "3.10"
+        runner: ["windows.4xlarge"]
+        gpu-arch-type: ["cpu"]
+      fail-fast: false
     uses: pytorch/test-infra/.github/workflows/windows_job.yml@main
     with:
-      runner: "windows.4xlarge"
       repository: pytorch/rl
+      runner: ${{ matrix.runner }}
       timeout: 40
+      test-infra-ref: main
       script: |
         set -euxo pipefail
 
-        export PYTHON_VERSION="3.9"
+        export PYTHON_VERSION=${{ matrix.python-version }}
         export CU_VERSION="cpu"
         export torch_cuda="False"
 

diff --git a/setup.cfg b/setup.cfg
@@ -29,6 +29,7 @@ per-file-ignores =
     examples/*.py: T201
     test/opengl_rendering.py: T201
     */**/run-clang-format.py: T201
+    packaging/*/**.py: T201
 
 exclude = venv
 extend-select = B901, C401, C408, C409, TOR0, TOR1, TOR2