Fix CPU PID/TID 0 In Trace #1061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D71510383 |
sraikund16
added a commit
to sraikund16/kineto
that referenced
this pull request
Mar 20, 2025
Summary: When we have PID/TID 0, the trace thinks these events are part of the GPU. To fix this we can override the PID with that of the typical CPU thread and have a warning. Differential Revision: D71510383
sraikund16
force-pushed
the
export-D71510383
branch
from
c5b7be1 to
995de83
Compare
Summary: Pull Request resolved: pytorch#1061 When we have PID/TID 0, the trace thinks these events are part of the GPU. To fix this we can override the PID with that of the typical CPU thread and have a warning. Differential Revision: D71510383
|
This pull request was exported from Phabricator. Differential Revision: D71510383 |
sraikund16
force-pushed
the
export-D71510383
branch
from
995de83 to
4bebdf6
Compare
|
This pull request has been merged in 7cb6ac6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: When we have PID/TID 0, the trace thinks these events are part of the GPU. To fix this we can override the PID with that of the typical CPU thread and have a warning.
Differential Revision: D71510383