Move "baseTimeNanoseconds" and "displayTimeUnit" before "traceEvents"#1054
Closed
jj10306 wants to merge 1 commit intopytorch:mainfrom
Closed
Move "baseTimeNanoseconds" and "displayTimeUnit" before "traceEvents"#1054jj10306 wants to merge 1 commit intopytorch:mainfrom
jj10306 wants to merge 1 commit intopytorch:mainfrom
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70404528 |
jj10306
force-pushed
the
export-D70404528
branch
from
433db29 to
7edf7a1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70404528 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70404528 |
jj10306
force-pushed
the
export-D70404528
branch
2 times, most recently
from
e6e2bc6 to
c7f81d1
Compare
jj10306
added a commit
to jj10306/kineto
that referenced
this pull request
Mar 4, 2025
…pytorch#1054) Summary: `baseTimeNanoseconds` is currently put at the end of the trace after `traceEvents` which makes efficiently parsing this trace metadata with `ijson` difficult. This diff moves "baseTimeNanoseconds" and "displayTimeUnit" before "traceEvents" - we intentionally leave `traceName` at the end of the trace for the time being to avoid having to make a more sprawling change to correctly handle trailing commas. Reviewed By: sraikund16 Differential Revision: D70404528
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70404528 |
jj10306
added a commit
to jj10306/kineto
that referenced
this pull request
Mar 4, 2025
…pytorch#1054) Summary: Pull Request resolved: pytorch#1054 `baseTimeNanoseconds` is currently put at the end of the trace after `traceEvents` which makes efficiently parsing this trace metadata with `ijson` difficult. This diff moves "baseTimeNanoseconds" and "displayTimeUnit" before "traceEvents" - we intentionally leave `traceName` at the end of the trace for the time being to avoid having to make a more sprawling change to correctly handle trailing commas. Reviewed By: sraikund16 Differential Revision: D70404528
jj10306
force-pushed
the
export-D70404528
branch
2 times, most recently
from
414b586 to
6ddda35
Compare
jj10306
added a commit
to jj10306/kineto
that referenced
this pull request
Mar 4, 2025
…pytorch#1054) Summary: `baseTimeNanoseconds` is currently put at the end of the trace after `traceEvents` which makes efficiently parsing this trace metadata with `ijson` difficult. This diff moves "baseTimeNanoseconds" and "displayTimeUnit" before "traceEvents" - we intentionally leave `traceName` at the end of the trace for the time being to avoid having to make a more sprawling change to correctly handle trailing commas. Reviewed By: sraikund16 Differential Revision: D70404528
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70404528 |
jj10306
added a commit
to jj10306/kineto
that referenced
this pull request
Mar 4, 2025
…pytorch#1054) Summary: `baseTimeNanoseconds` is currently put at the end of the trace after `traceEvents` which makes efficiently parsing this trace metadata with `ijson` difficult. This diff moves "baseTimeNanoseconds" and "displayTimeUnit" before "traceEvents" - we intentionally leave `traceName` at the end of the trace for the time being to avoid having to make a more sprawling change to correctly handle trailing commas. Reviewed By: sraikund16 Differential Revision: D70404528
jj10306
force-pushed
the
export-D70404528
branch
from
6ddda35 to
6298541
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70404528 |
jj10306
force-pushed
the
export-D70404528
branch
from
6298541 to
12c7ef5
Compare
jj10306
added a commit
to jj10306/kineto
that referenced
this pull request
Mar 4, 2025
…pytorch#1054) Summary: Pull Request resolved: pytorch#1054 `baseTimeNanoseconds` is currently put at the end of the trace after `traceEvents` which makes efficiently parsing this trace metadata with `ijson` difficult. This diff moves "baseTimeNanoseconds" and "displayTimeUnit" before "traceEvents" - we intentionally leave `traceName` at the end of the trace for the time being to avoid having to make a more sprawling change to correctly handle trailing commas. Reviewed By: sraikund16 Differential Revision: D70404528
jj10306
force-pushed
the
export-D70404528
branch
from
12c7ef5 to
6dfe9d8
Compare
jj10306
added a commit
to jj10306/kineto
that referenced
this pull request
Mar 6, 2025
…pytorch#1054) Summary: `baseTimeNanoseconds` is currently put at the end of the trace after `traceEvents` which makes efficiently parsing this trace metadata with `ijson` difficult. This diff moves "baseTimeNanoseconds" and "displayTimeUnit" before "traceEvents" - we intentionally leave `traceName` at the end of the trace for the time being to avoid having to make a more sprawling change to correctly handle trailing commas. Differential Revision: D70404528
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70404528 |
jj10306
force-pushed
the
export-D70404528
branch
from
6dfe9d8 to
d5a63c9
Compare
jj10306
added a commit
to jj10306/kineto
that referenced
this pull request
Mar 6, 2025
…pytorch#1054) Summary: Pull Request resolved: pytorch#1054 `baseTimeNanoseconds` is currently put at the end of the trace after `traceEvents` which makes efficiently parsing this trace metadata with `ijson` difficult. This diff moves "baseTimeNanoseconds" and "displayTimeUnit" before "traceEvents" - we intentionally leave `traceName` at the end of the trace for the time being to avoid having to make a more sprawling change to correctly handle trailing commas. Differential Revision: D70404528
…pytorch#1054) Summary: `baseTimeNanoseconds` is currently put at the end of the trace after `traceEvents` which makes efficiently parsing this trace metadata with `ijson` difficult. This diff moves "baseTimeNanoseconds" and "displayTimeUnit" before "traceEvents" - we intentionally leave `traceName` at the end of the trace for the time being to avoid having to make a more sprawling change to correctly handle trailing commas. Reviewed By: aaronenyeshi Differential Revision: D70404528
jj10306
force-pushed
the
export-D70404528
branch
from
d5a63c9 to
cab63f7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70404528 |
Contributor
|
This pull request has been merged in 08fcb94. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
baseTimeNanosecondsis currently put at the end of the trace aftertraceEventswhich makes efficiently parsing this trace metadata withijsondifficult. This diff moves "baseTimeNanoseconds" and "displayTimeUnit" before "traceEvents" - we intentionally leavetraceNameat the end of the trace for the time being to avoid having to make a more sprawling change to correctly handle trailing commas.Differential Revision: D70404528