Fix torch._inductor.aoti_compile_and_package input #7400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7400
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit c14f801 with merge base f341da8 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67436429 |
dvorjackz
approved these changes
Dec 19, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
Summary: The inputs to `torch._inductor.aoti_compile_and_package` changed in pytorch/pytorch#140991. The `args` and `kwargs` do not need to be inputed anymore. The API will get them from `exported_program.example_inputs` Differential Revision: D67436429
facebook-github-bot
force-pushed
the
export-D67436429
branch
from
0a16dde to
e4a34eb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67436429 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
Summary: The inputs to `torch._inductor.aoti_compile_and_package` changed in pytorch/pytorch#140991. The `args` and `kwargs` do not need to be inputed anymore. The API will get them from `exported_program.example_inputs` Differential Revision: D67436429
facebook-github-bot
force-pushed
the
export-D67436429
branch
from
e4a34eb to
9ca54c5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67436429 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
Summary: The inputs to `torch._inductor.aoti_compile_and_package` changed in pytorch/pytorch#140991. The `args` and `kwargs` do not need to be inputed anymore. The API will get them from `exported_program.example_inputs` Differential Revision: D67436429
facebook-github-bot
force-pushed
the
export-D67436429
branch
from
9ca54c5 to
38c983f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67436429 |
dvorjackz
requested changes
Dec 19, 2024
| @@ -1 +1 @@ | |||
| 19eff28ff3f19b50da46f5a9ff5f4d4d213806fe | |||
| 288aa873831057b1eb7d747914ec4fdc76c23a80 | |||
There was a problem hiding this comment.
Should update this and the torch pin in a separate pr
There was a problem hiding this comment.
@dvorjackz but if I update the torch pin without other changes in the PR, the tests will fail due to the input to torch._inductor.aoti_compile_and_package changed?
There was a problem hiding this comment.
True actually, let's use this instead though actually #7273, seems better for the sake of updating the pin correctly
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
Summary: The inputs to `torch._inductor.aoti_compile_and_package` changed in pytorch/pytorch#140991. The `args` and `kwargs` do not need to be inputed anymore. The API will get them from `exported_program.example_inputs` Differential Revision: D67436429
facebook-github-bot
force-pushed
the
export-D67436429
branch
from
38c983f to
f450d8d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67436429 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
Summary: The inputs to `torch._inductor.aoti_compile_and_package` changed in pytorch/pytorch#140991. The `args` and `kwargs` do not need to be inputed anymore. The API will get them from `exported_program.example_inputs` Differential Revision: D67436429
facebook-github-bot
force-pushed
the
export-D67436429
branch
from
f450d8d to
8294a2f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67436429 |
Summary: The inputs to `torch._inductor.aoti_compile_and_package` changed in pytorch/pytorch#140991. The `args` and `kwargs` do not need to be inputed anymore. The API will get them from `exported_program.example_inputs` Differential Revision: D67436429
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
Summary: The inputs to `torch._inductor.aoti_compile_and_package` changed in pytorch/pytorch#140991. The `args` and `kwargs` do not need to be inputed anymore. The API will get them from `exported_program.example_inputs` Differential Revision: D67436429
facebook-github-bot
force-pushed
the
export-D67436429
branch
from
8294a2f to
26e9053
Compare
yushangdi
force-pushed
the
export-D67436429
branch
from
26e9053 to
c14f801
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67436429 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D67436429 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The inputs to
torch._inductor.aoti_compile_and_packagechanged in pytorch/pytorch#140991.The
argsandkwargsdo not need to be inputed anymore. The API will get them fromexported_program.example_inputsDifferential Revision: D67436429