Skip to content

Arm backend: Support dyn. shapes in rewrite_slice - #23053

Merged
oscarandersson8218 merged 1 commit into
pytorch:mainfrom
oscarandersson8218:dynamic_rewrite_slice_fix
Sep 23, 2026
Merged

oscarandersson8218 merged 1 commit into
pytorch:mainfrom
oscarandersson8218:dynamic_rewrite_slice_fix

Conversation

@oscarandersson8218

@oscarandersson8218 oscarandersson8218 commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Preserve symbolic and proxy slice bounds when normalizing start and end indices.

Build dynamic slice sizes from shape operators and relax TOSA SLICE validation for non-static start and size values.

cc @digantdesai @freddan80 @per @zingo @mansnils @Sebastian-Larsson @robell @rascani

Preserve symbolic and proxy slice bounds when normalizing start and end
indices.

Build dynamic slice sizes from shape operators and relax TOSA SLICE
validation for non-static start and size values.

Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Change-Id: I499bb523a4078de71e55501710ceda6bcc11820e
@pytorch-bot

pytorch-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23053

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Pending

As of commit 5992b17 with merge base c2e8d64 (image):

NEW FAILURE - The following job has failed:

  • Cadence Build & Test / Resolve CI docker image / resolve (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 23, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Sep 23, 2026
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes labels Sep 23, 2026
@oscarandersson8218

Copy link
Copy Markdown
Collaborator Author

Unrelated failures.

@oscarandersson8218
oscarandersson8218 merged commit d28c77e into pytorch:main Sep 23, 2026
452 of 465 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants