Skip to content

Bump PyTorch pin to nightly dev20260809 - #21708

Open
pytorchupdatebot wants to merge 1 commit into
mainfrom
automated/pytorch-pin-bump-dev20260809
Open

Bump PyTorch pin to nightly dev20260809#21708
pytorchupdatebot wants to merge 1 commit into
mainfrom
automated/pytorch-pin-bump-dev20260809

Conversation

@pytorchupdatebot

Copy link
Copy Markdown
Collaborator

Summary

Automated weekly PyTorch pin bump.

  • Updates NIGHTLY_VERSION in torch_pin.py to dev20260809
  • Updates .ci/docker/ci_commit_pins/pytorch.txt to the corresponding nightly commit hash
  • Syncs c10 headers from PyTorch into runtime/core/portable_type/c10/

This PR was created automatically. If CI fails, Claude will attempt to fix issues (up to 3 attempts). If CI still fails, human review will be requested.

cc @jakeszwe

@pytorch-bot

pytorch-bot Bot commented Aug 10, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21708

Note: Links to docs will display an error until the docs builds have been completed.

❌ 218 New Failures, 1 Pending, 16 Unclassified Failures

As of commit 233c02f with merge base fb5eedc (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 10, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@pytorchupdatebot

Copy link
Copy Markdown
Collaborator Author

@claude [ci-fix-attempt 1/3]

The trunk CI workflow has failed on this automated PyTorch pin bump PR.
Failed run: https://github.com/pytorch/executorch/actions/runs/31375060976

Please:

  1. Read the Dr. CI comment on this PR for a summary of which jobs failed and whether they are flaky. Ignore failures marked as FLAKY.
  2. Use your CI tools to download the failure logs for the non-flaky failing jobs
  3. Identify the root cause of the failure
  4. If this is a build or test failure caused by PyTorch API changes, fix the ExecuTorch code to be compatible with the new PyTorch version
  5. If this is a c10 header sync issue, the headers have already been synced by the pin bump script — the issue is likely in ExecuTorch code that uses those headers
  6. Run lintrunner -a on any files you change
  7. Push your fix as a new commit to this PR branch

Important constraints:

  • Do NOT modify torch_pin.py or .ci/docker/ci_commit_pins/pytorch.txt — the pin itself is correct
  • Do NOT modify files under runtime/core/portable_type/c10/ unless the sync introduced a new API that ExecuTorch code needs to adapt to
  • Focus on fixing ExecuTorch code to be compatible with the new PyTorch APIs
  • If this is a major BC-breaking change that requires architectural discussion, say so clearly and stop — do not attempt a fix

@claude

claude Bot commented Aug 10, 2026

Copy link
Copy Markdown

Claude finished @pytorchupdatebot's task in 2m 45s —— View job


CI Fix — PyTorch pin bump dev20260809 [attempt 1/3]

  • Read Dr. CI summary & identify non-flaky failures
  • Download failure logs & find root cause
  • Identify fix scope
  • Fix ExecuTorch codestopping: requires architectural decision (see below)

Root cause

The new nightly (dev20260809) raises PyTorch's minimum C++ standard from C++17 to C++20. Every target that includes ATen/torch headers now fails at preprocessing:

torch/include/ATen/ATen.h:5:2: error: C++20 or later compatible compiler is required to use ATen.
torch/include/torch/csrc/api/include/torch/all.h:5:2: error: C++20 or later compatible compiler is required to use PyTorch.

The scattered TensorBase.h:1034: expected ';' errors are the same cause — a C++20-only construct in a header being compiled as C++17.

This is not a c10-header-sync issue and not a narrow API change. It's a compiler-standard floor bump on PyTorch's side.

Why I'm not auto-fixing this

The failure spans essentially the entire matrix (pybind/editable installs, QNN, Arm, Vulkan, WebGPU, XNNPACK, Cortex-M, buck2, macOS). ExecuTorch still pins C++17 as the default in many independent build surfaces:

  • CMakeLists.txt:116-118 (set(CMAKE_CXX_STANDARD 17)) and ~20 other CMakeLists.txt files that default to 17
  • .buckconfig:26 (-std=c++17) and third-party/gtest_defs.bzl:5
  • .lintrunner.toml:217 (--std=c++17)
  • Embedded toolchains: examples/arm/ethos-u-setup/arm-none-eabi-gcc.cmake:42, examples/zephyr/...gcc.cmake:42, Cadence backends

Bumping ExecuTorch's minimum C++ standard to 20 is a BC-breaking, cross-cutting decision. It affects downstream consumers who set CMAKE_CXX_STANDARD=17, and — more importantly — the embedded/bare-metal targets (Cortex-M, Zephyr, Ethos-U), where moving to C++20 has real toolchain and code-size implications that shouldn't be decided by an automated pin-bump. A migration was already started (portable_lib, extension/llm/runner, extension/training, wheel config, and Windows CI already use 20), but completing it project-wide — especially for embedded — needs human/architectural sign-off.

Per the constraint "If this is a major BC-breaking change that requires architectural discussion, say so clearly and stop", I'm stopping here rather than pushing a sweeping standard bump.

Recommended path (for a human)

Decide whether to raise ExecuTorch's global minimum to C++20 in lockstep with PyTorch. If yes, the change is mechanical but broad: flip the default 1720 in the CMake files, .buckconfig, gtest_defs.bzl, .lintrunner.toml, and evaluate each embedded toolchain individually. cc @jakeszwe
· branch automated/pytorch-pin-bump-dev20260809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/pytorch-pin-bump ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants