periodic: stop running dl3 and edsr on the portable backend - #21693
Open
shoumikhin wants to merge 1 commit into
Open
periodic: stop running dl3 and edsr on the portable backend#21693shoumikhin wants to merge 1 commit into
shoumikhin wants to merge 1 commit into
Conversation
This PR needs a
|
shoumikhin
force-pushed
the
shoumikhin/skip-portable-dl3-edsr-in-periodic
branch
from
August 8, 2026 23:12
de189b9 to
ec554ca
Compare
shoumikhin
force-pushed
the
shoumikhin/skip-portable-dl3-edsr-in-periodic
branch
from
August 10, 2026 05:51
ec554ca to
09fd0ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21692.
What is broken
The scheduled
periodicworkflow always concludes ascancelled, even when everything real about the commit is fine.Why it is broken
Two jobs in that workflow never finish:
test-models-linux-basic (cmake, dl3, portable, linux.4xlarge.memory, 90)test-models-linux-basic (cmake, edsr, portable, linux.2xlarge, 90)Both hit the 90 minute job limit on every run since at least 2026-08-03 and are killed by GitHub. A job killed by the timeout reports
cancelled, and one cancelled job makes the whole workflow read as cancelled.In a recent periodic run these two were the only non-successes out of 59 jobs. The
xnnpackvariants of the same two models finished in about ten minutes each.So today this costs about nine runner hours a day (
periodicruns three times a day) and produces no result either way, while also hiding whether the rest of the periodic run was healthy.The fix
Stop gathering the
portablevariants ofdl3andedsr.gather_test_models.pyalready has two filters: one by event and one by target OS. Neither can express "this model on this backend", so this adds a third one,model_should_run_on_backend, in the same style as the existingyolo26skip.Coverage impact is small:
dl3andedsrare still tested through theirxnnpackvariants, and the portable path is still tested by every other model in the matrix.Not fixed here
Why portable export of these two got so slow. A dl3 log shows an 81 minute silent gap after the runner starts plus memory pressure warnings, so raising the timeout would not be honest. #21692 tracks the real investigation, and the skip should be removed once that is done.
How this was verified
gather_test_models.pywas run directly, with and without the change, for everyevent and target OS the workflows actually use, and the emitted matrices were
compared:
pull_requestpull_requestpushpushschedulescheduleThe
pull_requestandpushmatrices are byte for byte identical, so the pullrequest and trunk signal is untouched. The only entries missing from
scheduleare
dl3 / portableandedsr / portable. Thexnnpack-quantization-delegationvariants of both models are still there, so neither model loses coverage.
periodic.ymlis the only workflow that calls this script, so nothing else isaffected.