Skip to content

Zero grad_input in max_pool2d_with_indices_backward #21687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anurag2796 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

Zero grad_input in max_pool2d_with_indices_backward #21687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions kernels/portable/cpu/op_max_pool2d_with_indices_backward.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
#include <executorch/kernels/portable/cpu/util/kernel_ops_util.h>
#include <executorch/runtime/kernel/kernel_includes.h>

#include <cstring>

namespace torch {
namespace executor {
namespace native {
Expand Down Expand Up @@ -171,6 +173,13 @@ Tensor& max_pool2d_with_indices_backward_out(

static constexpr auto name = "max_pool2d_with_indices_backward.grad_input";

// max_pool_backward_impl scatter-adds into grad_input (`grad_input_ptr[maxindex] += ...`), writing
// only the argmax positions. resize_tensor does not clear the buffer and the memory planner recycles
// arena allocations across ops and iterations, so every other element would accumulate onto stale
// data. ATen zeroes gradInput before dispatching the identical loop
// (aten/src/ATen/native/DilatedMaxPool2d.cpp).
memset(grad_input.mutable_data_ptr(), 0, grad_input.nbytes());

ET_SWITCH_FLOATHBF16_TYPES(input.scalar_type(), ctx, name, CTYPE, [&]() {
max_pool_backward_impl<CTYPE, false>(grad_input, grad_output, indices);
});
Expand Down
Loading