Skip to content

[ExecuTorch][WebGPU] Add Gemma 4 MTP operator and route support - #21675

Open
JCNTH wants to merge 1 commit into
gh/JCNTH/215/basefrom
gh/JCNTH/215/head
Open

[ExecuTorch][WebGPU] Add Gemma 4 MTP operator and route support#21675
JCNTH wants to merge 1 commit into
gh/JCNTH/215/basefrom
gh/JCNTH/215/head

Conversation

@JCNTH

@JCNTH JCNTH commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Add the backend-only operator surface required by Gemma 4 MTP k2_round. The diff introduces exact-shape staged TopK, duplicate-safe generic Scatter, a provenance-certified unique-index WG64 Scatter route, long-context 2D dispatch closure, integer subtraction metadata, and a guarded raw-fp32 M=3 Q4 path.

Key changes:

  • TopK implements official fp32 [1,1,2048] to [1,1,32] values/indices with WG64 metadata.
  • Scatter keeps aten.scatter.src duplicate-safe and exposes parallel execution only through certified et_vk.scatter_src_unique.default.
  • Quantized linear/subtraction adds the MTP M=3 Q4 route and constant-scalar projection with generic fallback.
  • Codegen strips comments before workgroup parsing and regenerates headers/registry entries.

MTP delegation is instance-scoped; plain Gemma exposes neither TopK nor certified Scatter.

Co-authored-with: Claude Code.

Differential Revision: D115234084

[ghstack-poisoned]
@JCNTH
JCNTH requested a review from SS-JIA as a code owner August 7, 2026 18:57
@pytorch-bot

pytorch-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21675

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Pending

As of commit 60a9937 with merge base ceca90f (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 7, 2026
@meta-cla

meta-cla Bot commented Aug 8, 2026

Copy link
Copy Markdown

Hi @JCNTH!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant