Skip to content

Conversation

@metascroy
Copy link
Contributor

Summary:
This diff decomposes SDPA to fix iOS26 numerics in Core ML.

It also removes repeat interleave to further optimize performance on Core ML by about 10-15%, depending on the hardware.

Differential Revision: D88705980

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16144

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 83c8d50 with merge base c9f6df1 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 9, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 9, 2025

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88705980.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

metascroy added a commit to metascroy/executorch that referenced this pull request Dec 9, 2025
Summary:

This diff decomposes SDPA to fix iOS26 numerics in Core ML.

It also removes repeat interleave to further optimize performance on Core ML by about 10-15%, depending on the hardware.

Differential Revision: D88705980
@metascroy metascroy changed the title Fix CoreML iOS26 numerics in attention Fix CoreML iOS26 numerics in static attention Dec 9, 2025
metascroy added a commit to metascroy/executorch that referenced this pull request Dec 9, 2025
Summary:

This diff decomposes SDPA to fix iOS26 numerics in Core ML.

It also removes repeat interleave to further optimize performance on Core ML by about 10-15%, depending on the hardware.

Reviewed By: billmguo

Differential Revision: D88705980
@metascroy metascroy requested a review from billmguo December 9, 2025 19:17
Summary:

This diff decomposes SDPA to fix iOS26 numerics in Core ML.

It also removes repeat interleave to further optimize performance on Core ML by about 10-15%, depending on the hardware.

Reviewed By: billmguo

Differential Revision: D88705980
@metascroy metascroy merged commit 9eaea4a into pytorch:main Dec 10, 2025
294 of 298 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants