-
Notifications
You must be signed in to change notification settings - Fork 752
Fix CoreML iOS26 numerics in static attention #16144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16144
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 83c8d50 with merge base c9f6df1 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88705980. |
This PR needs a
|
Summary: This diff decomposes SDPA to fix iOS26 numerics in Core ML. It also removes repeat interleave to further optimize performance on Core ML by about 10-15%, depending on the hardware. Differential Revision: D88705980
18009fd to
d7dd45d
Compare
Summary: This diff decomposes SDPA to fix iOS26 numerics in Core ML. It also removes repeat interleave to further optimize performance on Core ML by about 10-15%, depending on the hardware. Reviewed By: billmguo Differential Revision: D88705980
d7dd45d to
d237c0e
Compare
Summary: This diff decomposes SDPA to fix iOS26 numerics in Core ML. It also removes repeat interleave to further optimize performance on Core ML by about 10-15%, depending on the hardware. Reviewed By: billmguo Differential Revision: D88705980
d237c0e to
83c8d50
Compare
Summary:
This diff decomposes SDPA to fix iOS26 numerics in Core ML.
It also removes repeat interleave to further optimize performance on Core ML by about 10-15%, depending on the hardware.
Differential Revision: D88705980