Skip to content

QConv: Use buffer storage for weights #16139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SS-JIA wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −6
Open

QConv: Use buffer storage for weights #16139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backends/vulkan/runtime/graph/ops/glsl/conv2d_q8_utils.glslh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ ivec4 load_weight_block(
const int Kw,
const int Kh,
const int OC4) {
#ifdef PACKED_INT8_WEIGHTS_BUFFER
#ifdef WEIGHT_BUFFER
const int block_x = oc4 * Kw + kx;
const int block_y = ky * IC4 + ic4;
return t_packed_int8_weight[block_y * (Kw * OC4) + block_x];
Expand Down
2 changes: 2 additions & 0 deletions backends/vulkan/runtime/graph/ops/glsl/conv2d_q8ta_q8csw_q8to.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ conv2d_q8ta_q8csw_q8to:
combination:
parameter_names: [IO_STORAGE, WEIGHT_STORAGE]
combos:
- parameter_values: [buffer, buffer]
- parameter_values: [buffer, texture2d]
- parameter_values: [texture3d, buffer]
- parameter_values: [texture3d, texture2d]
DTYPE:
- VALUE: float
Expand Down
6 changes: 1 addition & 5 deletions backends/vulkan/runtime/graph/ops/impl/QuantizedConvolution.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,11 +442,7 @@ ValueRef prepack_quantized_conv2d_weight(

std::vector<int64_t> packed_weight_sizes{output_height, output_width};

utils::StorageType storage_type = utils::kTexture2D;
uint32_t max_extent = graph.context()->adapter_ptr()->max_texture2d_dim();
if (output_width > max_extent * 4 || output_height > max_extent) {
storage_type = utils::kBuffer;
}
utils::StorageType storage_type = utils::kBuffer;

ValueRef packed_weight = graph.add_tensor(
packed_weight_sizes,
Expand Down
Loading