Skip to content

Conversation

@Ben0mega
Copy link
Contributor

@Ben0mega Ben0mega commented Dec 8, 2025

Summary:
The underlying goal is that all files in fbcode have owners annotated. This file has been identified as defining builds or tests that are frequently used, but don't have an oncall annotation.

The purpose of the proper oncall is to ensure that the right people are notified on build or test breakages and that automated codemods (e.g. ai diffs) get proper review by the owners of the file or files.

The oncall was determined by looking at other annotations nearby (e.g. the src files, files in the parent folders).

Differential Revision: D87476364

Summary:
The underlying goal is that all files in fbcode have owners annotated.  This file has been identified as defining builds or tests that are frequently used, but don't have an oncall annotation.

The purpose of the proper oncall is to ensure that the right people are notified on build or test breakages and that automated codemods (e.g. ai diffs) get proper review by the owners of the file or files.

The oncall was determined by looking at other annotations nearby (e.g. the src files, files in the parent folders).

Differential Revision: D87476364
@Ben0mega Ben0mega requested a review from cccclai as a code owner December 8, 2025 20:34
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16135

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit e37a515 with merge base 62dccf1 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 8, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 8, 2025

@Ben0mega has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87476364.

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync bot merged commit f26f228 into pytorch:main Dec 9, 2025
144 of 161 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants