Skip to content

Conversation

@shoumikhin
Copy link
Contributor

@shoumikhin shoumikhin commented Dec 8, 2025

Added a guardrail step to prevent overwriting existing branches in the Apple workflow to avoid accidental binaries overwrite on S3.

Added a guardrail step to prevent overwriting existing branches in the Apple workflow to accidental avoid binaries overwrite on S3.
Copilot AI review requested due to automatic review settings December 8, 2025 18:10
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16132

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 3b7a11a with merge base 488d761 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 8, 2025
@shoumikhin shoumikhin added ciflow/trunk and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Dec 8, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a guardrail check to the Apple workflow that prevents overwriting existing branches and associated S3 binaries. The check runs early in the set-version job before expensive build operations begin, verifying that the generated swiftpm-{VERSION} branch doesn't already exist on the remote repository.

Key Changes:

  • Added guardrail step in set-version job to check for existing remote branches
  • Prevents workflow execution when a version-specific branch already exists
  • Provides clear error message instructing users to delete the branch before re-running

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 8, 2025 18:15
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

run: |
VERSION="1.1.0.$(TZ='PST8PDT' date +%Y%m%d)"
echo "version=$VERSION" >> "$GITHUB_OUTPUT"
- name: Guardrail
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The step name "Guardrail" is vague. Consider a more descriptive name like "Check for existing branch" or "Prevent branch overwrite" to better indicate the step's purpose.

Suggested change
- name: Guardrail
- name: Check for existing branch

Copilot uses AI. Check for mistakes.
Copy link
Member

@GregoryComer GregoryComer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Copilot nit about the name seems reasonable but it's your call.

@shoumikhin shoumikhin merged commit 152ea3e into main Dec 10, 2025
330 of 333 checks passed
@shoumikhin shoumikhin deleted the shoumikhin-patch-2 branch December 10, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants