Skip to content

Conversation

@ArmRyan
Copy link
Collaborator

@ArmRyan ArmRyan commented Dec 5, 2025

Conv3d is not supported by vela so it can not be supported
in u55 or u85.

  • Adds Conv3D support for FP32, Int8 and int16A8W
  • Reworks to_tosa_memory_format_pass.py to handle spatial rank 3 tensors (DHW)
  • Adds support for rank 5 tensors to analyze_output_utils.py
  • Reworks conv2d passes to handle conv3d and renames them to be more generic

Change-Id: I0c888b46afe7bdfa0a26c26d5281ab02b945b528

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@ArmRyan ArmRyan requested a review from digantdesai as a code owner December 5, 2025 09:59
@ArmRyan ArmRyan added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Dec 5, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16093

Note: Links to docs will display an error until the docs builds have been completed.

❌ 34 New Failures, 4 Unrelated Failures

As of commit c2dffaa with merge base d968e47 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 5, 2025
 Conv3d is not supported by vela so it can not be supported
 in u55 or u85.

 * Adds Conv3D support for FP32, Int8 and int16A8W
 * Reworks to_tosa_memory_format_pass.py to handle
   spatial rank 3 tensors (DHW)
 * Adds support for rank 5 tensors to analyze_output_utils.py
 * Reworks conv2d passes to handle conv3d and renames them
   to be more generic

Signed-off-by: Ryan O'Shea <[email protected]>
Change-Id: I0c888b46afe7bdfa0a26c26d5281ab02b945b528
Signed-off-by: Ryan O'Shea <[email protected]>
Change-Id: I9b096c71da7e1bf943857c04c5606e22ba35da4f
Signed-off-by: Ryan O'Shea <[email protected]>
Change-Id: Ibce8fdf18a8e3fb2f16a9f5cb0c07d167ba2514c
@ArmRyan ArmRyan force-pushed the experimental/conv3d_support branch from 7a4b5ab to 40a4202 Compare December 8, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants