-
Notifications
You must be signed in to change notification settings - Fork 722
Do not restore constant_buffer, and use bytes instead of Buffer #15802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/lucylq/127/base
Are you sure you want to change the base?
Conversation
All constants are serialized in the segment (none in the Program). This PR: 1. Places constant data into the PTEFile class instead of restoring it into the Program. 2. Use List[bytes] instead of List[Buffer] for constant and mutable data. Buffer was initially used to maintain alignment; now, constants are serialized with alignment in the segment, and Buffer is not required. Update tests. After this, we can mark 'constant_buffer' as deprecated, as it's no longer being used in deserialization or emitter. Differential Revision: [D86913756](https://our.internmc.facebook.com/intern/diff/D86913756/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15802
Note: Links to docs will display an error until the docs builds have been completed. ❌ 14 New Failures, 2 Unrelated FailuresAs of commit 0b2ffea with merge base 7600df8 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
All constants are serialized in the segment (none in the Program). This PR: 1. Places constant data into the PTEFile class instead of restoring it into the Program. 2. Use List[bytes] instead of List[Buffer] for constant and mutable data. Buffer was initially used to maintain alignment; now, constants are serialized with alignment in the segment, and Buffer is not required. Update tests. After this, we can mark 'constant_buffer' as deprecated, as it's no longer being used in deserialization or emitter. Differential Revision: [D86913756](https://our.internmc.facebook.com/intern/diff/D86913756/) ghstack-source-id: 322868586 Pull Request resolved: #15802
This PR needs a
|
Stack from ghstack (oldest at bottom):
All constants are serialized in the segment (none in the Program).
This PR:
Update tests.
After this, we can mark 'constant_buffer' as deprecated, as it's no longer being used in deserialization or emitter.
Differential Revision: D86913756