Remove internal executorch dependency on torchao.quantization.subclass #15223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15223
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit e497573 with merge base 4cff294 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@andrewor14 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84921134. |
This PR needs a
|
andrewor14
force-pushed
the
export-D84921134
branch
from
e910d6d to
7019ce6
Compare
andrewor14
added a commit
to andrewor14/executorch
that referenced
this pull request
Oct 17, 2025
pytorch#15223) Summary: **Summary:** This is a really old quantization API that we recently removed in torchao (D84842047). No one should be calling it anymore. For BC, let's just copy the base class into executorch for now. We should delete this in the future. **Test Plan:** CI Differential Revision: D84921134
pytorch#15223) Summary: **Summary:** This is a really old quantization API that we recently removed in torchao (D84842047). No one should be calling it anymore. For BC, let's just copy the base class into executorch for now. We should delete this in the future. **Test Plan:** CI Differential Revision: D84921134
andrewor14
added a commit
to andrewor14/executorch
that referenced
this pull request
Oct 17, 2025
pytorch#15223) Summary: **Summary:** This is a really old quantization API that we recently removed in torchao (D84842047). No one should be calling it anymore. For BC, let's just copy the base class into executorch for now. We should delete this in the future. **Test Plan:** CI Differential Revision: D84921134
andrewor14
force-pushed
the
export-D84921134
branch
2 times, most recently
from
c029373 to
e497573
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Summary: This is a really old quantization API that we
recently removed in torchao (D84842047). No one should be
calling it anymore. For BC, let's just copy the base class
into executorch for now. We should delete this in the future.
Test Plan: CI
Differential Revision: D84921134