Refactor _get_source_transforms to remove args #10519
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10519
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 51a0583 with merge base 2837867 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jackzhxng
force-pushed
the
jz/refactor_source_transforms
branch
from
26ce4dc to
ff5e6d9
Compare
jackzhxng
force-pushed
the
jz/refactor_source_transforms
branch
from
ff5e6d9 to
51a0583
Compare
|
@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
iseeyuan
reviewed
Apr 28, 2025
| @@ -1196,12 +1259,25 @@ def _get_source_transforms( # noqa | |||
| transformations based on the given checkpoint first. In those cases, | |||
| this wil be a no-op. | |||
| """ | |||
| modelname = f"{modelname}_e" | |||
| # Create a mock args object with the necessary attributes | |||
There was a problem hiding this comment.
Is it to limit the extend of changes? It's better than Namespace, but I'm wondering if eventually we need to group args, and there can still be passing the entire args even not all fields are needed.
iseeyuan
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
It's a great improvement from passing Namespace directly. Thanks @jackzhxng !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
_get_source_transforsmto remove args