Arm backend: Make run.sh run without setup.sh #10515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit lets the user run run.sh without running setup.sh manually. As long as the FVP eula has been accepted. Setup.sh can still be run manually and with another scratchdir set by the user. But if setup.sh is sourced the scratchdir cannot be set. Setup.sh has been give some cleanup to handle scratchdir being set by user and code has been moved into functions. Change-Id: I628974fbac2d730ff8e74f6953bd4a42937113c9
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10515
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fcd41ee with merge base 7054b1f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
perheld
added
partner: arm
zingo
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit lets the user run run.sh without running setup.sh manually. As long as the FVP eula has been accepted.
Setup.sh can still be run manually and with another scratchdir set by the user. But if setup.sh is sourced the scratchdir cannot be set.
Setup.sh has been give some cleanup to handle scratchdir being set by user and code has been moved into functions.
Change-Id: I628974fbac2d730ff8e74f6953bd4a42937113c9
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218