Skip to content

Add device type (public, private) and id #10496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/scripts/extract_benchmark_results.py
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,10 @@ def transform(
# Overwrite the device name here with the job name as it has more information about
# the device, i.e. Samsung Galaxy S22 5G instead of just Samsung
for r in benchmark_results:
r["deviceInfo"]["device"] = job_name
is_private_device = job_report.get("is_private_instance", False)
r["deviceInfo"]["device"] = (
f"{job_name} (private)" if is_private_device else job_name
)

# From https://github.com/pytorch/pytorch/wiki/How-to-integrate-with-PyTorch-OSS-benchmark-database
return [
Expand All @@ -363,6 +366,7 @@ def transform(
"benchmark_config": json.dumps(benchmark_config),
"job_conclusion": "SUCCESS",
"job_arn": job_report.get("arn", ""),
"instance_arn": job_report.get("instance_arn", ""),
},
},
"model": {
Expand Down
16 changes: 7 additions & 9 deletions .github/workflows/apple-perf-private-device-experiment.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,16 @@
name: apple-perf (private devices)

on:
# TODO (huydhn): Disable the schedule run until we land the change to add device pool and device name
# to separate between public and private iOS devices
# schedule:
# - cron: 0 0,4,8,12,16,20 * * *
schedule:
- cron: 0 0,4,8,12,16,20 * * *
pull_request:
paths:
- .github/workflows/apple-perf-private-device-experiment.yml
# push:
# branches:
# - main
# paths:
# - .github/workflows/apple-perf-private-device-experiment.yml
push:
branches:
- main
paths:
- .github/workflows/apple-perf-private-device-experiment.yml
# Note: GitHub has an upper limit of 10 inputs
workflow_dispatch:
inputs:
Expand Down
Loading