Skip to content

Arm backend: Add TOSA VGF encapsulated compilation target. #10476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2025

Conversation

robell
Copy link
Collaborator

@robell robell commented Apr 25, 2025

Add TOSA VGF encapsulated compilation target.

This change enables support for "vgf" files which wrap TOSA output and include memory planning for target devices which can JIT TOSA to the target ISA on-device.

  • Add a VgfQuantizer (same as TOSAQuantizer)
  • Add a VgfBackend and VgfPartitioner to produce TOSA wrapped in a VGF
  • Requires yet to be released converter_backend

Signed-off-by: Rob Elliott [email protected]
Change-Id: I764c32c33c503eb44200e9a7d98caa8fae8a4882

Test plan

As this is a new encapsulation with a tool that's not yet released, integration with unit tests will come in a subsequent commit.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@robell robell requested a review from digantdesai as a code owner April 25, 2025 14:34
Copy link

pytorch-bot bot commented Apr 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10476

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 2 Pending, 1 Unrelated Failure

As of commit cc9684b with merge base e5874fa (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 25, 2025
@robell robell added the release notes: arm Changes to the ARM backend delegate label Apr 25, 2025
@robell robell requested a review from per April 25, 2025 14:35
@zingo zingo added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Apr 25, 2025
@zingo zingo changed the title Add TOSA VGF encapsulated compilation target. Arm backend: Add TOSA VGF encapsulated compilation target. Apr 25, 2025
@zingo
Copy link
Collaborator

zingo commented Apr 29, 2025

Hi @robell this seems to need a proper rebase after latest merges to main in the build /test scrips. I tried an "Update branch" here in GitHub but get fails in the Arm runners, so it probably needs a proper check.

robell added 4 commits April 29, 2025 09:32
Signed-off-by: Rob Elliott <[email protected]>
Change-Id: Id96933b727015502cced3c4dcc48535895c55cf7
 - Add a VgfQuantizer (same as TOSAQuantizer)
 - Add a VgfBackend and VgfPartitioner
 - Requires yet to be released converter_backend

Signed-off-by: Rob Elliott <[email protected]>
Change-Id: I764c32c33c503eb44200e9a7d98caa8fae8a4882
Signed-off-by: Rob Elliott <[email protected]>
Change-Id: I9f121252bd009250c61fe136fcf8d278c480133f
@robell
Copy link
Collaborator Author

robell commented Apr 29, 2025

Hi @robell this seems to need a proper rebase after latest merges to main in the build /test scrips. I tried an "Update branch" here in GitHub but get fails in the Arm runners, so it probably needs a proper check.

Done now - there was some minor issue with restructuring of the quantizers/ import behaviours.

@zingo - can you review please? the internal review's done so it should just be sign-off for merge.

@robell robell requested a review from zingo April 29, 2025 10:47
@zingo
Copy link
Collaborator

zingo commented Apr 29, 2025

llava/llama fails are unrelated!

@zingo zingo merged commit 66314e4 into pytorch:main Apr 29, 2025
266 of 269 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants