Simpler file chunking #1188
Closed
Simpler file chunking #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Ping @ejguan |
|
@pmeier can you review since you reviewed pytorch/vision#7673 too? |
pmeier
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Thanks @adamjstewart, LGTM if CI is green. Although I can review, I don't have merge rights here. So we need to wait for the maintainers.
|
Ping ping @ejguan |
|
Sorry to be the bearer of the bad news here, but it seems this PR won't go anywhere in the near future: #1196 |
|
Thanks for the heads up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Python 3.8 is the minimum supported version, we can use the new assignment expression syntax to simplify how we read files chunk-by-chunk.