Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify buffer_size across TorchData DataPipes #1077

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexanderbattig
Copy link

@alexanderbattig alexanderbattig commented Mar 11, 2023

Fixes: #335

As draft, since the tests don't run for me at the moment.

Also, CLA pending at the moment.

@facebook-github-bot
Copy link
Contributor

Hi @alexanderbattig!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2023
@ejguan ejguan changed the title Unify buffer_size, following the convention suggested in https://github.com/pytorch/data/issues/335 Unify buffer_size across TorchData DataPipes Mar 13, 2023
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the summary and PR title. And, I have an early comment that we might want to add a constant DEFAULT_BUFFER_SIZE to torchdata/_constants.py. And, reference all of usage to this place. Then, we can add a function/context manager to update it if users need to change all buffer size at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BE] Unify buffer_size across datapipes
3 participants