[ROCm] Rework LoadHIP.cmake to be based purely on CMAKE_PREFIX_PATH. #3945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Eliminates dependence on `/opt/rocm` and path based heuristics. * Normalizes package finding for Rocm 6.5+ layout. * Workaround cmake >= 4.0 for hiprtc Co-authored-by: Scott Tsai <[email protected]> Co-authored-by: Aaryaman Vasishta <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3945
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jammm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/opt/rocmand path based heuristics.This will help with windows support. I understand that audio is in a maintenance phase, but I highly recommend this to be merged in order to allow torchaudio to be built on for AMD systems on Windows.
Technically, this still doesn't really compile the CUDA kernels because USE_ROCM doesn't include some of those .cu files. But it still does allow building the wheels and getting things functionally running.