-
Notifications
You must be signed in to change notification settings - Fork 352
Fix setup.py to skip CPU kernels on Windows #3187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3187
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (2 Unrelated Failures)As of commit a3d79ab with merge base ca99c1c ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
CI is broken. Failures are not related to this PR. |
|
@mingfeima Please review. Thanks. |
|
Hi @vkuzo @jerryzh168 @metascroy @mingfeima @Valentine233 Please review this PR. Thanks. |
|
Hi @vkuzo @jerryzh168 @metascroy Can you please review this PR? Thanks. |
1 similar comment
|
Hi @vkuzo @jerryzh168 @metascroy Can you please review this PR? Thanks. |
|
could you add a test plan detailing how this was tested for correctness? Thank you! |
Hi @vkuzo If there is a CI workflow that builds Torchao on Windows, this will be tested. Do you have a plan to enable that in CI? Thanks. |
Fixes #3175
CPU kernel files in the
torchao/csrc/cpu/aten_kernels/directory are not skipped correctly on Windows because the path string matching fails (\vs/). This PR fixes this issue.Test plan
We need a CI flow that tests building Torchao on Windows