Skip to content

Conversation

@Xia-Weiwen
Copy link
Collaborator

@Xia-Weiwen Xia-Weiwen commented Oct 16, 2025

Fixes #3175

CPU kernel files in the torchao/csrc/cpu/aten_kernels/ directory are not skipped correctly on Windows because the path string matching fails (\ vs /). This PR fixes this issue.

Test plan
We need a CI flow that tests building Torchao on Windows

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3187

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (2 Unrelated Failures)

As of commit a3d79ab with merge base ca99c1c (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2025
@Xia-Weiwen Xia-Weiwen added topic: not user facing Use this tag if you don't want this PR to show up in release notes and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Oct 16, 2025
@Xia-Weiwen Xia-Weiwen requested a review from vkuzo October 16, 2025 05:08
@Xia-Weiwen Xia-Weiwen marked this pull request as ready for review October 16, 2025 05:08
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2025
@Xia-Weiwen
Copy link
Collaborator Author

CI is broken. Failures are not related to this PR.

@Xia-Weiwen
Copy link
Collaborator Author

@mingfeima Please review. Thanks.

@Xia-Weiwen Xia-Weiwen requested a review from jerryzh168 October 17, 2025 01:17
@Xia-Weiwen
Copy link
Collaborator Author

Hi @vkuzo @jerryzh168 @metascroy @mingfeima @Valentine233 Please review this PR. Thanks.

@Xia-Weiwen
Copy link
Collaborator Author

Hi @vkuzo @jerryzh168 @metascroy Can you please review this PR? Thanks.

1 similar comment
@Xia-Weiwen
Copy link
Collaborator Author

Hi @vkuzo @jerryzh168 @metascroy Can you please review this PR? Thanks.

@vkuzo
Copy link
Contributor

vkuzo commented Oct 23, 2025

could you add a test plan detailing how this was tested for correctness? Thank you!

@Xia-Weiwen
Copy link
Collaborator Author

Xia-Weiwen commented Oct 24, 2025

could you add a test plan detailing how this was tested for correctness? Thank you!

Hi @vkuzo If there is a CI workflow that builds Torchao on Windows, this will be tested. Do you have a plan to enable that in CI? Thanks.

@Xia-Weiwen
Copy link
Collaborator Author

Hi @vkuzo I have submitted an issue here #3237 Can we add such a workflow in CI to test it? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Windows][build]it will meet build failures when build with pytorch xpu version on windows

4 participants