Skip to content

fix(executorch): do not resize a 0-d delegate output #4469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shoumikhin wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −4
Open

fix(executorch): do not resize a 0-d delegate output #4469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions cpp/src/torch_tensorrt/executorch/TensorRTBackend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,10 +522,17 @@ Error TensorRTBackend::execute(BackendExecutionContext& context, DelegateHandle*
for (int d = 0; d < actual_dims.nbDims; ++d) {
new_sizes[d] = static_cast<SizesType>(actual_dims.d[d]);
}
Error resize_err = executorch::runtime::resize_tensor(et_out, {new_sizes, static_cast<size_t>(actual_dims.nbDims)});
if (resize_err != Error::Ok) {
ET_LOG(Error, "TensorRTBackend::execute: resize_tensor failed for output '%s'", name.c_str());
return resize_err;
// A 0-d output has an immutable rank of zero, and TensorRT reports it as a
// 1-element 1-D shape, so resizing would be rejected. Skip it when the
// element count already agrees.
const bool scalar_output = et_out.dim() == 0 && actual_dims.nbDims == 1 && actual_dims.d[0] == 1;
if (!scalar_output) {
Error resize_err =
executorch::runtime::resize_tensor(et_out, {new_sizes, static_cast<size_t>(actual_dims.nbDims)});
if (resize_err != Error::Ok) {
ET_LOG(Error, "TensorRTBackend::execute: resize_tensor failed for output '%s'", name.c_str());
return resize_err;
}
}

void* bind_ptr = nullptr;
Expand Down
Loading