Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: Add example usage script for Function/Module-level acceleration #2103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

examples: Add example usage script for Function/Module-level acceleration #2103

wants to merge 1 commit into from

Conversation

gs-olive
Copy link
Collaborator

Description

  • Add detailed tutorial for excluding modules or functions from tracing in Dynamo compile and writing custom converters for those excluded modules or functions

Fixes #1984

Type of change

  • Example scripts

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive added component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths Story: Dynamo Compile Improvements Issues relating to improvement of the Dynamo compile path labels Jul 12, 2023
@gs-olive gs-olive requested a review from narendasan July 12, 2023 17:40
@gs-olive gs-olive self-assigned this Jul 12, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 12, 2023
github-actions[bot]
github-actions bot approved these changes Jul 12, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Jul 12, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Jul 12, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Jul 12, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

narendasan
narendasan reviewed Jul 12, 2023
View reviewed changes
examples/dynamo/dynamo_module_level_acceleration.py Outdated
"ceil_mode": False if len(args) < 6 else args[5],
}

return acc_ops_converters.acc_ops_max_pool1d(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples should use either impl versions or from TRT api versions

@gs-olive gs-olive linked an issue Jul 13, 2023 that may be closed by this pull request
Add example scripts for module/function level acceleration #1984
Closed
@gs-olive gs-olive force-pushed the dynamo_examples_gallery branch from 2684dd9 to ec35106 Compare July 25, 2023 17:35
@gs-olive
examples: Add example usage script for module-acc
22feaf8 
- Add detailed tutorial for excluding modules or functions from tracing
in Dynamo and writing custom converters for those excluded modules
@gs-olive gs-olive force-pushed the dynamo_examples_function_acceleration branch from edda3d9 to 22feaf8 Compare August 8, 2023 23:42
@gs-olive gs-olive changed the base branch from dynamo_examples_gallery to main August 8, 2023 23:42
@gs-olive gs-olive mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths documentation Improvements or additions to documentation Story: Dynamo Compile Improvements Issues relating to improvement of the Dynamo compile path
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add example scripts for module/function level acceleration
3 participants
@gs-olive @narendasan @facebook-github-bot