Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReplaceImportsTransformer #27

Closed
wants to merge 1 commit into from
Closed

Conversation

kit1980
Copy link
Contributor

@kit1980 kit1980 commented Mar 9, 2024

Resolve a TODO of replacing ad-hoc _UpdateFunctorchImports with more generic ReplaceImportsTransformer.
This fixes #24 and unblocks work on the visitors that need updating imports.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 9, 2024
@kit1980 kit1980 requested a review from malfet March 9, 2024 00:53
@kit1980 kit1980 force-pushed the sdym/replace-imports branch from 8447683 to f16567a Compare March 9, 2024 01:01
@kit1980 kit1980 marked this pull request as ready for review March 9, 2024 01:02
@kit1980 kit1980 requested a review from izaitsevfb March 9, 2024 01:03
@kit1980
Copy link
Contributor Author

kit1980 commented Mar 11, 2024

Now I think the problem should be solved very differently, closing this PR for now.

@kit1980 kit1980 closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add functionality to remove no longer needed imports
2 participants