Add TorchScopedLibraryVisitor #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
zou3519
reviewed
Feb 5, 2024
| @@ -0,0 +1 @@ | |||
| 3:11 TOR901 Use `torch.library._scoped_library` instead of `torch.library.Library` in PyTorch tests files. See https://github.com/pytorch/pytorch/pull/118318 for details. | |||
There was a problem hiding this comment.
Is there is a way to suppress the lint? We'll probably want to allow some usages of torch.library.Library (just to test that API).
There was a problem hiding this comment.
It's disabled by default. When we enable it for some files, usual flake8 noqa comments can be used to ignore some lines.
zou3519
reviewed
Feb 5, 2024
| cst.metadata.WhitespaceInclusivePositionProvider, node | ||
| ) | ||
|
|
||
| self.violations.append( |
There was a problem hiding this comment.
what limits this rule to files under test/ ?
There was a problem hiding this comment.
The rule is disabled by default. We can enable it for test/ in the CI config in pytorch/pytorch.
zou3519
approved these changes
Feb 5, 2024
clee2000
approved these changes
Feb 5, 2024
huydhn
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new category of rules, 'internal': rules that are used for PyTorch code itself, not for PyTorch users.
These rules starts with TOR9 and are not enabled by default.
The TorchScopedLibraryVisitor rule is based on pytorch/pytorch#118318 and a lint-only for now.
I'll try to add a codemod for it in the next PR. Codemod would be somewhat complicated, but probably worth it as the
pytorch/test/test_python_dispatch.pyfile is thousands of lines of code.