This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
delete swap_linear_with_dynamic from fsdp2 eager test case
#311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: clean up some tech debt, the `swap_linear_with_dynamic` function is redundant with `swap_linear_with_float8_linear` Test Plan: ``` python ./test/test_fsdp2/test_fsdp2_eager.py ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jul 9, 2024
facebook-github-bot
added
the
CLA Signed
weifengpy
approved these changes
Jul 9, 2024
drisspg
approved these changes
Jul 9, 2024
Summary: clean up some tech debt, the `swap_linear_with_dynamic` function is redundant with `swap_linear_with_float8_linear` Test Plan: ``` python ./test/test_fsdp2/test_fsdp2_eager.py ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 3fe7c4a. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
swap_linear_with_dynamicfrom fsdp2 eager test case #311Summary:
clean up some tech debt, the
swap_linear_with_dynamicfunction is redundant with
swap_linear_with_float8_linearTest Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D59685259