Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Updates with new scaled-mm api #284

Closed
wants to merge 1 commit into from
Closed

Updates with new scaled-mm api #284

wants to merge 1 commit into from

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Jun 14, 2024

Summary

This updates the calls to _scaled_mm to the new signature from this PR: pytorch/pytorch#128683

This is needed to unblock inductor work on scaled_mm.

❯ ./test/test_everything.sh
	.
	.
	.

test/test_fsdp2/test_fsdp2_eager.py .......                                   [100%]

================================ 7 passed in 27.66s =================================
all tests successful

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 14, 2024
@drisspg drisspg requested a review from vkuzo June 14, 2024 23:51
@drisspg drisspg force-pushed the update-scaled-mm-api branch from 39e24dd to da3e8a1 Compare June 15, 2024 00:24
Copy link
Contributor

@vkuzo vkuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Does this need a PyTorch nightly version check to warn people if their version is out of date, or is there no good way to do that?

@drisspg
Copy link
Contributor Author

drisspg commented Jun 15, 2024

We have been pretty fast and loose with versioning. The only required runtime dependency we have is torch and we dont specify a version, but we do make explicit note of the need for nightly:
https://github.com/pytorch-labs/float8_experimental?tab=readme-ov-file#installation

I could(and probably should) update the dependency we have to specify we require newer versions of pytorch but still not perfect since, nightly doesnt follow semantic versioning

@facebook-github-bot
Copy link
Contributor

@drisspg has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@drisspg has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@drisspg merged this pull request in edae9a3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants