Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Add Docker Support for CUTLASS FP8 GEMM #36

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

SamirMoustafa
Copy link
Contributor

This pull request includes changes to the cutlass_gemm kernel, aimed at improving the setup, installation, and usage of the kernel. The most important changes include the addition of a Dockerfile for containerized builds, updates to the readme.md for clearer installation instructions, and improvements to the setup.py for better path handling and CUDA library linking.

  • kernels/cuda/cutlass_gemm/Dockerfile: Added a Dockerfile to facilitate building and running the project in a containerized environment. This includes instructions for building the image and running the container.

  • kernels/cuda/cutlass_gemm/readme.md: Updated the README with detailed installation instructions for both Docker and non-Docker environments, including prerequisites and steps for building and running the project.

  • kernels/cuda/cutlass_gemm/setup.py: Modified the setup script to dynamically determine the current location for include directories and to use CUDA_HOME for library directories, enhancing portability and ease of setup. [1] [2]

Minor Code Adjustments:

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 12, 2024
@SamirMoustafa
Copy link
Contributor Author

I can also add a benchmark script that compares against PyTorch data types, but this would make the PR slightly longer. Please let me know if it is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants