Skip to content

Conversation

eriknw
Copy link
Member

@eriknw eriknw commented Oct 15, 2025

  • support Python 3.14 and drop Python 3.8
  • some additional cleanup and modernization

Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (688a812) to head (60f0e8d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #607   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1178      1181    +3     
=========================================
+ Hits          1178      1181    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrocklin
Copy link
Member

mrocklin commented Oct 15, 2025 via email

@eriknw
Copy link
Member Author

eriknw commented Oct 16, 2025

Thanks for bringing us into the present Erik!

You bet! I'm sure it's long past due. The impetus for this was to be PEP 517 compliant, which tools will begin to require soon.

@mrocklin, do you have any thoughts on what to put in the project.authors field in pyproject.toml? Right now I don't include it. Previously, we had author as 'https://raw.github.com/pytoolz/toolz/master/AUTHORS.md'.

I added pre-commit hooks that do basic checks and light linting via pyupgrade. I'm not adding black or ruff formatting yet to try to avoid disrupting PRs, many of which can potentially go in and are pretty old. I also wouldn't be against adding black or ruff, but I think that should be done in a separate PR.

Anyway, it's always a pleasure to work on toolz--the tests run so fast! There's still more cruft to clean up, but this PR takes a big step forward.

@eriknw
Copy link
Member Author

eriknw commented Oct 16, 2025

Merging so I can continue to experiment with Trusted Publishing. I may do a release tomorrow (Thursday), so please provide any feedback here or as separate issue/PR as appropriate.

@eriknw eriknw merged commit a39cd67 into pytoolz:master Oct 16, 2025
18 checks passed
@mrocklin
Copy link
Member

do you have any thoughts on ...

No immediate thoughts from me.

I also wouldn't be against adding black or ruff, but I think that should be done in a separate PR.

Makes sense to me. My intuition here is that if either of us want to improve infrastructure here we should feel free to do so. I thnk that we probably shouldn't change much functionality in toolz these days (unless we're planning on being active again for a while) but that there are probably lots of low hanging fruit for infrastructure or procedural changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants