Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start with options #41

Merged
merged 4 commits into from
Mar 8, 2025
Merged

Start with options #41

merged 4 commits into from
Mar 8, 2025

Conversation

pythops
Copy link
Owner

@pythops pythops commented Mar 7, 2025

closes #40

orhun
orhun reviewed Mar 8, 2025
View reviewed changes
Copy link
Contributor

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried this (with -i wlp3s0) and it works well!

Adding a review for simplifying the implementation a bit.

@pythops pythops marked this pull request as ready for review March 8, 2025 11:44
orhun
orhun approved these changes Mar 8, 2025
View reviewed changes
Copy link
Contributor

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

@pythops pythops merged commit 4f02574 into main Mar 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun orhun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support starting with args
2 participants
@pythops @orhun