Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of asyncio coroutines. #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apollovy
Copy link

Hi.
This patch works for current versions of python, but breaks <3.3 where yield from is a syntax error and returning from generatior is not allowed.
I will just leave it here in case somebody would want to use this project in async world.
By now I don't see an easy way to deal with the situation except that making a dependency from tornado in 2.7 (and maybe 2.6) and use their machinery for coroutines. But by now I doubt it's worth spending a time on it 🤗
Fixes #161

Copy link
Collaborator

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! We just made some infrastructure changes that conflict with your PR. Would you mind rebasing and trying again? Also, adding some tests would be nice :)

from distutils.core import setup
import setuptools

import memory_profiler
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method to extract the version was changed.

license='BSD'

license='BSD',
install_requires=['asyncio>=3.4.3'] if sys.version_info < (3, 4) else [],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using PEP 426 markers instead? https://blog.ionelmc.ro/presentations/packaging/#slide:25

@OleksaVasylenko
Copy link

@apollovy Hi! Are you going to finish that? That would be a great benefit.

@apollovy
Copy link
Author

apollovy commented Sep 21, 2018 via email

@astrojuanlu
Copy link
Collaborator

@OleksaVasylenko if you want to take over, you could do like this on a local memory_profiler checkout:

$ git checkout -b apollovy-master e2a97b9
$ git rebase upstream master  # Fix conflicts
$ git pull https://github.com/apollovy/memory_profiler.git master

and we can continue the review from there. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants