Skip to content

Add login page - #4706

Draft
patrick91 wants to merge 1 commit into
2026-08-06-add-shadcnfrom
2026-08-06-add-login-page
Draft

Add login page#4706
patrick91 wants to merge 1 commit into
2026-08-06-add-shadcnfrom
2026-08-06-add-login-page

Conversation

@patrick91

Copy link
Copy Markdown
Member

No description provided.

@vercel

vercel Bot commented Aug 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Ready Ready Preview Aug 14, 2026 8:12pm

@claude

claude Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Adds a login page for the dashboard (Inertia + shadcn login form) backed by a new login/dashboard-login Django view, session-based auth guarding /dashboard, and open-redirect-safe next handling.

  • backend/dashboard/src/components/login-form.tsx: when the GraphQL response has top-level errors, the raw error.message strings from the server are shown directly to the user as form errors (payload.errors.map((error) => error.message)). If an unhandled exception message ever leaks through (e.g. with DEBUG on, or a future change to error masking), this surfaces internal details straight to the login form. Consider mapping to a generic message instead of relaying server error text verbatim.
  • backend/dashboard/src/components/nav-user.tsx logOut(): no credentials option is set (unlike the login fetch, which sets credentials: "same-origin"), and if response.ok is false the function silently does nothing — no error surfaced to the user, so a failed logout looks like a no-op click.

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.87%. Comparing base (16fb83b) to head (177fb7e).

Additional details and impacted files
@@                    Coverage Diff                    @@
##           2026-08-06-add-shadcn    #4706      +/-   ##
=========================================================
+ Coverage                  92.86%   92.87%   +0.01%     
=========================================================
  Files                        363      363              
  Lines                      11176    11192      +16     
  Branches                     894      896       +2     
=========================================================
+ Hits                       10379    10395      +16     
  Misses                       675      675              
  Partials                     122      122              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Shortcake-Parent: 2026-08-06-add-shadcn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant