Skip to content

avoid redundant attr name repetition with __set_name__ #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
graingert wants to merge 1 commit into
base: master
Choose a base branch
from
Open

avoid redundant attr name repetition with __set_name__ #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions 02-descriptors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@
class TypeChecker:
required_type = object

def __init__(self, name):
def __set_name__(self, owner, name):
old_name = getattr(self, 'name', None)
if old_name:
raise ValueError(f'reused from {old_name}')

self.name = f'_{name}'

def __get__(self, instance, owner=None):
Expand All @@ -21,8 +25,8 @@ class IntType(TypeChecker):


class Point:
x = IntType('x')
y = IntType('y')
x = IntType()
y = IntType()

def __init__(self, x, y):
self.x = x
Expand All @@ -44,8 +48,8 @@ class PointType(TypeChecker):


class Circle:
center = PointType('center')
radius = IntType('radius')
center = PointType()
radius = IntType()

def __init__(self, center, radius):
self.center = center
Expand Down