match Buffer inheritance to cpython Buffer #502
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 3.12+,
collections.abc.Buffer
usesmetaclass=ABCMeta
instead of inheriting fromABC
. Is there a reason whytyping_extensions.Buffer
doesn't do the same?In typeshed,
typing_extensions.Buffer
is Protocol, which means the stubs do havemetaclass=ABCMeta
but they don't inherit fromabc.ABC
, so this MR improves alignment with bothtyping.Buffer
and the stubs.