Fix Generic with ParamSpec not subscriptable with multiple arguments [non-generic-variant] #491
+154
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 23, 2024
|
Note changes here are the combined checks from |
| # we do not check the count | ||
| if (inspect.isclass(cls) and issubclass(cls, typing.Generic) | ||
| and len(cls.__parameters__) == 1 | ||
| and isinstance(cls.__parameters__[0], ParamSpec) |
There was a problem hiding this comment.
Do we need to check both typing.ParamSpec and typing_extensions.ParamSpec?
There was a problem hiding this comment.
I do not think so. For 3.10 the _TypeVarLikeMeta __instancecheck__ of typing_extensions.ParamSpec will check for the typing variant.
There was a problem hiding this comment.
I think it might be useful to have a test on 3.10+ that uses typing.Concatenate and typing.ParamSpec, which are different from the typing_extensions version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR assures that no TypeError is raised, however there are still multiple limitations for Python <3.11.3
I think some of the 3.10 cases could be a regression; I am still looking into that and will create a separate issue. #489 will fix most of the cases as a follow up of this PR.