-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support subscription of Callable[Concatenate[P], Any]
with ...
in Python 3.10
#479
Merged
JelleZijlstra
merged 7 commits into
python:main
from
Daraan:concatenate/ellipsis-3.10-v2
Oct 21, 2024
Merged
Support subscription of Callable[Concatenate[P], Any]
with ...
in Python 3.10
#479
JelleZijlstra
merged 7 commits into
python:main
from
Daraan:concatenate/ellipsis-3.10-v2
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
reviewed
Oct 3, 2024
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra
approved these changes
Oct 21, 2024
JelleZijlstra
approved these changes
Oct 21, 2024
That'll teach me to fix merge conflicts, I guess. |
AlexWaygood
reviewed
Oct 21, 2024
AlexWaygood
approved these changes
Oct 21, 2024
I am now blocked from merging, tossing it back to you @JelleZijlstra |
JelleZijlstra
approved these changes
Oct 21, 2024
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48 for python 3.10.3+
The first versions 3.10.0 - 3.10.2 did not enforce restrictions on the last parameter of _ConcatenateGenericAlias. 3.10.3-3.10.* only support ParamSpec, i.e. no Ellipsis, hence #48 also holds for these versions.
This PR adds a backport of
_ConcatenateGenericAlias
which overrrides the problematiccopy_with
method.Concatenate
but does not fix it fully (see the skipped test)