Copy the coroutine status in deprecated

[srittau]

No description provided.

[AlexWaygood]

On earlier versions of Python, there were two different functions, inspect.iscoroutinefunction and asyncio.coroutines.iscoroutinefunction. This was confusing, because they did two different things: inspect.iscoroutinefunction was strict about only returning True for functions that actually had the CO_COROUTINE code-flag set, whereas asyncio.coroutines.iscoroutinefunction also considered functions decorated with @types.coroutine to be coroutines, even though these functions did not have that code-flag set.

There's not much we can do for inspect.iscoroutinefunction on the earlier versions of Python (because, before the two iscoroutinefunction functions were merged, it was stricter than it is now), but we can hack asyncio.coroutines.iscoroutinefunction by doing decorated_function._is_coroutine = asyncio.coroutines._is_coroutine: https://github.com/python/cpython/blob/d542a9be51776e8d589363ee15164dec8dbd3a76/Lib/asyncio/coroutines.py#L17-L24

[srittau]

The 3.13 test fails, because this hasn't been implemented in 3.13 yet. It should be fixed with 3.13.rc1. What's the best course of action?

[AlexWaygood]

The 3.13 test fails, because this hasn't been implemented in 3.13 yet. It should be fixed with 3.13.rc1. What's the best course of action?

I'd add a decorator like the one we already have here (which we can probably delete at this point):

typing_extensions/src/test_typing_extensions.py

Lines 125 to 128 in 70cec91

	skip_if_py313_beta_1 = skipIf(
	sys.version_info[:5] == (3, 13, 0, 'beta', 1),
	"Bugfixes will be released in 3.13.0b2"
	)

Something like this:

 skip_if_py313_beta = skipIf( 
     sys.version_info[:4] == (3, 13, 0, 'beta'), 
     "Bugfixes will be released in 3.13.0rc1"
 )

[AlexWaygood]

It seems like the _is_coroutine thing also exists on the CPython main branch. I think it would be nice for @deprecated to work consistently across Python versions as much as possible, so maybe we could just add the _is_coroutine marker unconditionally, even though it isn't really necessary on py312+:

Suggested change

	if sys.version_info >= (3, 12):
	wrapper = inspect.markcoroutinefunction(wrapper)
	else:
	wrapper._is_coroutine = asyncio.coroutines._is_coroutine
	wrapper._is_coroutine = asyncio.coroutines._is_coroutine
	if sys.version_info >= (3, 12):
	wrapper = inspect.markcoroutinefunction(wrapper)

[srittau]

I'd be wary about this. Why access a private item when not necessary? Especially since it gets overwritten immediately after?

[AlexWaygood]

Fair enough, we can leave this.

[AlexWaygood]

Ah, well, it would fix the asyncio.coroutines.iscoroutinefunction() test that's currently failing on Python 3.13.0b4. But I suppose that test could easily just be skipped only if we're on Python >=3.13 and <3.13.0rc1

[srittau]

CI is passing now.